7 Mar 2019 |
| @mt:bau-ha.us joined the room. | 18:53:20 |
axn | hi @mt | 19:01:33 |
@mt:bau-ha.us | Hi @axn:matrix.org - @aparcar:matrix.org sent me here, just asked him about https://github.com/bmx-routing/bmx7/pull/42 - this fixes building bmx7 with mbedtls 2.16 for me on arch, basically a macro was missing for some deprecated functions and linking failed, the include in the ifdefs adds the new helper include that contains the macro, that's how I understood it, might be odd | 19:12:05 |
axn | macro compares CRYPTLIB against MBEDTLS_2_16_0 but MBEDTLS_2_16_0 is not defined anywhere in BMX7. How can that work? | 19:14:29 |
axn | Also for openwrt (which uses 2..18.0) it was not necessary to include mbedtls/platform_util.h. | 19:15:38 |
@mt:bau-ha.us | I have no idea, I suspect maybe mbedtls sets that define? | 19:15:42 |
@mt:bau-ha.us | okay, so maybe it's my fault, I have not much experience with c - I'll look again | 19:16:02 |
axn | Which CRYPTLIB did you define for building? | 19:16:27 |
axn | Would it be enough if I just change : #ifndef CRYPTLIB
#define CRYPTLIB MBEDTLS_2_8_0
#endif | 19:17:58 |
@mt:bau-ha.us | I just ran the defaults, without any defines | 19:18:15 |
axn | as suggested here: https://github.com/bmx-routing/bmx7/issues/41#issuecomment-467614813 | 19:18:59 |
axn | I guess your PR would break building for mbedtls < 2.16.0 | 19:20:36 |
@mt:bau-ha.us | axn: ah - I see! okay, so that looks like the better solution. shall I close the pull-request and link to that comment? | 19:20:52 |
@mt:bau-ha.us | axn: it's only included if that define is set - so I guess not but a solution without adding another ifdef is probably better anyway | 19:21:28 |
@mt:bau-ha.us | *define=ifdef | 19:21:36 |
axn | Maybe you could you try if it builds for you when changing crypt.h:42. to: | 19:21:50 |
axn | #define CRYPTLIB MBEDTLS_2_8_0 | 19:22:30 |
@mt:bau-ha.us | @axn: looks good! compiles and starts with that define | 19:25:43 |
axn | Cool. I'll change that later.... Have to leave now for an hour or so.. cu | 19:26:12 |
@mt:bau-ha.us | thx! | 19:27:20 |
13 Mar 2019 |
| @aparcar:matrix.org invited @luserx0:matrix.org. | 00:29:25 |
| @luserx0:matrix.org joined the room. | 00:31:55 |
15 Mar 2019 |
| @luserx0:matrix.org joined the room. | 13:32:00 |
| @luserx0:matrix.org joined the room. | 13:36:02 |
16 Mar 2019 |
@luserx0:matrix.org | Redacted or Malformed Event | 13:35:15 |
@d3vnil:matrix.org | hi | 13:44:47 |
@aparcar:matrix.org | In reply to @luserx0:matrix.org Heyo luserx0 is interested in implementing wireguard tunnels for bmx7 | 14:58:55 |
@aparcar:matrix.org | axn can you give him some pointers? | 14:59:29 |
@luserx0:matrix.org | Redacted or Malformed Event | 15:05:26 |
@luserx0:matrix.org | Redacted or Malformed Event | 15:17:24 |