11 Jan 2024 |
Tobias Roeser | * The UX should not change from the way it's currently enabled. Depends on if it can act as external module (https://mill-build.com/mill/Modules.html#_external_modules) or if it needs per-module configuration. | 15:18:09 |
fommil | it's just that one file from the gist, if I raise a PR adding that file can you please help to wire it up so that it compiles and explain how a user can enable it? | 15:19:48 |
fommil | I can try grepping for bloop or one of the existing contribs to work by example | 15:20:27 |
Tobias Roeser | Can you post a link to the gist, so I can have a look? | 15:21:05 |
Tobias Roeser | Oh, it's further up in the chat. Nevermind. | 15:21:49 |
Tobias Roeser | So, this is a normal module extending ScalaModule . Looks like you currently need to add it to your build.sc , right? | 15:22:56 |
fommil | it should have absolutely no impact on users that don't have the relevant ensime jar.
Yeah, installation involves quite a bit of imports which is why I'm not so keen on the UX. Does that get easier if it's in contrib ? | 15:24:00 |
Tobias Roeser | I think it's possible to make it an external module. Then all that's needed is a mill --import ivy:your:plugin your.plugin/whatever | 15:24:26 |
Tobias Roeser | Scala steward plugin is written that way for example | 15:25:04 |
Tobias Roeser | Or bloop, I think | 15:25:14 |
Tobias Roeser | https://github.com/scala-steward-org/mill-plugin | 15:26:32 |
Tobias Roeser | Looks like EnsimeModule needs to modify the scalac plugins, hence it's not trivial to make it an ExternalModule . At least not without having a dedicated compilation. | 15:33:05 |
Tobias Roeser | Maybe the way how we generate semanticDbData can be adapted to generate ensimeData . Does ensime run any mill command, or do you depend on magical metadata generated by the scalac plugin? | 15:35:52 |
12 Jan 2024 |
| telephonesanitiser changed their display name from TelephoneSanitiser to telephonesanitiser. | 13:16:14 |
| andimiller joined the room. | 15:35:54 |
| zhao_nan joined the room. | 17:01:58 |
| ragnar changed their display name from ragnar#4252 to ragnar. | 21:32:24 |
13 Jan 2024 |
| ose_369 joined the room. | 00:42:10 |
| ackory1 joined the room. | 02:20:37 |
| kiceyscream joined the room. | 05:20:07 |
| dplyukhin joined the room. | 18:08:17 |
15 Jan 2024 |
| @demonaddress:matrix.org joined the room. | 12:25:36 |
24 Jan 2024 |
| tobin6579 joined the room. | 06:39:54 |
28 Jan 2024 |
| darlingsodapop joined the room. | 21:30:30 |
4 Feb 2024 |
| @tommy_pac:matrix.org joined the room. | 13:21:01 |
| Bella Johnson joined the room. | 16:19:41 |
| Bella Johnson set a profile picture. | 16:40:49 |
5 Feb 2024 |
@tommy_pac:matrix.org | Redacted or Malformed Event | 01:47:44 |
6 Feb 2024 |
| @jojo404:matrix.org joined the room. | 18:59:03 |
| @jojo404:matrix.org left the room. | 19:25:49 |