6 Dec 2023 |
| padron6296 changed their display name from padron to padron6296. | 13:20:18 |
| worm.queen joined the room. | 15:01:12 |
| kimmmmmo joined the room. | 15:45:27 |
| worm.queen changed their display name from wormie to worm.queen. | 16:20:03 |
szeiger | This is the first codebase I've seen with -Ywarn-numeric-widen (and, of course, fatal warnings to make it extra annoying). What's the reason for this? Numeric widening to floating point types can be problematic but why would I ever want an error when passing an Int as a Long? | 16:47:40 |
sethtisue | I think a PR removing that would be accepted. | 16:49:11 |
sethtisue | a lot of cargo culting of compiler flags goes on out there. the commit message for the commit that added it is "Add recommended compiler flags" | 16:50:08 |
sethtisue | recommended by who | 16:50:15 |
sethtisue | * recommended by who... and why | 16:50:31 |
szeiger | Huh, the existing code has lots of warnings that are reported as such despite -Xfatal-warnings | 16:56:01 |
sethtisue | looks like -Xfatal-warnings is enabled on 2.12 but not on 2.13 | 17:26:06 |
sethtisue | def relaxNon212: Seq[Setting[_]] = Seq(
scalacOptions := {
val old = scalacOptions.value
scalaBinaryVersion.value match {
case "2.12" => old
case _ =>
old filterNot Set(
"-Xfatal-warnings",
"-deprecation",
"-Ywarn-unused",
"-Ywarn-unused-import"
)
}
}
) | 17:27:19 |
szeiger | Ah, right, I thought it was the other way around (which would probably be better at this point) | 17:45:38 |
som-snytt | The recommended flags are -Werror -Xlint . | 17:51:49 |
szeiger | If that was the default we could add an advanced flag to turn it off called -Yolo | 20:12:11 |
| styfros joined the room. | 20:17:26 |
7 Dec 2023 |
| marciocg joined the room. | 02:22:21 |
| merlinorg joined the room. | 06:13:11 |
| natsukagami changed their display name from @natsukagami to natsukagami. | 11:46:21 |
| tripleshotespresso joined the room. | 17:33:08 |
| littlewing87 joined the room. | 17:49:06 |
| rossfreeman joined the room. | 18:43:42 |
8 Dec 2023 |
| merlinorg changed their display name from wise_starfish_15473 to merlinorg. | 05:51:56 |
| oliver_brm changed their display name from Oliver Marienfeld to oliver_brm. | 08:33:58 |
| alexd1199 joined the room. | 10:09:38 |
lrytz | Seems -Ywarn-numeric-widen was added a long time ago in https://github.com/scala/scala/commit/fdfdd09d51 and basically left untouched and probably mostly unused. | 11:23:17 |
| leafywind2 joined the room. | 18:00:08 |
| paava007 joined the room. | 19:04:27 |
9 Dec 2023 |
| unarist joined the room. | 07:17:18 |
| jeengbe joined the room. | 13:31:05 |