| 26 Feb 2023 |
 Hotdog | So it's kinda like logging in with a Google account - the site doesn't handle any of the authentication really | 19:06:44 |
 javaimpact | * maybe we could just provide "storage" and "name" as parameters and have the impls figure out what they do with "storage" as we probably only ever care about "name", and maybe we could also have smth like "token" to not have the user log in every time they start the client, but i'm not sure if we need to include that in the abstraction or if we can just have that be an implementation detail of our impls | 19:06:56 |
 kuratius | a stopgap is a temporary measure meant to be used until a better method is available, i.e. while there's no azure server set up you could allow people to log in directly with a secret from a java client | 19:07:20 |
| Hotdog | Storage as in, persistent state that the impls might wanna keep track of? | 19:07:27 |
| javaimpact | yea | 19:07:35 |
| Hotdog | Oh right | 19:07:35 |
| javaimpact | its just some impl specific string | 19:07:55 |
| Hotdog | Well I don't see why we need a stopgap - it's not too difficult to set up a stopgap | 19:08:13 |
| Hotdog | Wait, can't we just make login, etc take &mut self and just use the structs for that instead of a storage type | 19:09:05 |
| kuratius | you probably mean server
people were complaining that there's no good documentation for it | 19:09:07 |
| Hotdog | Sorry I meant Azure app | 19:09:21 |
| Hotdog | And I've actually figured it out | 19:09:31 |
| Hotdog | As long as leafish devs maintain the config that I have, I think it'll work? | 19:09:44 |
 skillman623 | I agree it should go under a todo for other account systems.
Maybe even in addition to minecraft authentication | 19:44:51 |
| skillman623 | Can you sucessfully authenticate (you can test by using polyMC or multiMC adv options)?
If so if you can help me through setting up the azure I'd host it. | 19:47:09 |
| Hotdog | Uhhh, PrismLauncher seems to be able to launch but also does it if I give it a bullshit client ID so whatever's going on I'm not sure it proves whether my Azure app is working | 20:00:23 |
| Hotdog | I've tested with a Rust library, trying to setup proper authentication on Leafish rn | 20:00:39 |
| Hotdog | JavaImpact is there any documentation on how to implement join_server? | 20:19:53 |
| skillman623 | Deleta your account and readd to clear the cached auth token | 20:22:25 |
| skillman623 | Oh. If that works we're good. | 20:22:45 |
| skillman623 | Gimmie a minute, I'll make some. | 20:23:14 |
| Hotdog | This library reallly wants to be used in an async function | 20:23:40 |
| Hotdog | This is getting messy | 20:23:45 |
| skillman623 | Oauth2 can be blocking. | 20:24:36 |
| Hotdog | Yeah but I'm also using the specific microsoft authentication library that it wiki.vg lists as a reference implementation for Rust | 20:25:55 |
| Hotdog | Which likes being async | 20:25:58 |
| skillman623 | https://auth0.com/intro-to-iam/what-is-oauth-2 | 20:27:24 |
| skillman623 | https://auth0.com/docs/get-started/authentication-and-authorization-flow/authorization-code-flow-with-proof-key-for-code-exchange-pkce
This is the style that is best used. | 20:28:52 |
| Hotdog | Right now I'm mostly trying to just reword the example the library gave into the login function | 20:35:58 |
| Hotdog | To get something working to test if this will actually work | 20:36:18 |
