9 May 2022 |
Birb | entities should just work | 18:55:05 |
Birb | WmPipeline is easy to use and extensible | 18:55:15 |
Birb | * wgpu-mc is in a really good state now, honestly | 18:55:30 |
schitcrafter | * I'd need to make a fork and pull request, so if someone wants to codereview it and push directly that'd be nice EDIT: Oh yeah there's btw a fork called fix-varint-decoding already, but that doesn't fix it, so that should probably be deleted | 19:33:17 |
| ash (it/its) 🏳️⚧️ joined the room. | 23:13:30 |
10 May 2022 |
| Ivaniku joined the room. | 11:43:32 |
Ivaniku#4997 | Is Microsoft authentication supported yet? | 11:40:14 |
11 May 2022 |
skillman623 | Not quite. My schedule is freeing up so I'll be working on it soon. | 00:07:51 |
skillman623 | Okay so I'm confused. Looking more closely at this fork, the work is already done isn't it? With that being said, why have we copy and pasted from https://github.com/ALinuxPerson/mcsoft-auth instead of either forking it or adding it as a dependency? If someone can add comments to the 4 TODO sections to say what needs to be put there I can get a token to test and verify this implementation (and if this works, share it for testing and maybe have a donation page to offset the monthly hosting costs). | 00:36:36 |
skillman623 | * Okay so I'm confused. Looking more closely at this fork (Microsoft Auth), the work is already done isn't it? With that being said, why have we copy and pasted from https://github.com/ALinuxPerson/mcsoft-auth instead of either forking it or adding it as a dependency? If someone can add comments to the 4 TODO sections to say what needs to be put there I can get a token to test and verify this implementation (and if this works, share it for testing and maybe have a donation page to offset the monthly hosting costs). | 00:37:10 |
skillman623 | * Okay so I'm confused. Looking more closely at this fork (Microsoft Auth), the work is already done isn't it? With that being said, why have we copy and pasted from https://github.com/ALinuxPerson/mcsoft-auth instead of either forking it or adding it as a dependency? If someone can add comments to the 4 TODO (https://github.com/Lea-fish/Leafish/blob/f236e8c8c1b5e8b3ccb82ab5de769c285355c9fa/protocol/src/protocol/microsoft2.rs#L33-L42) sections to say what needs to be put there I can get a token to test and verify this implementation (and if this works, share it for testing and maybe have a donation page to offset the monthly hosting costs). | 00:38:41 |
skillman623 | ALinuxPerson If the authentication code is your code perhaps could you give me a pointer? If I know what it's expecting I can put certainly get the data, I'd do it but I'm having a very hard time wrapping my mind around the spaghetti code that this project has for variables. | 00:40:45 |
JavaImpact#1250 | First of all: the thing with this impl is that it isn't a proper library, this means that there is 1. no proper docs, 2. it's not clear what we'd have to change and 3. how to properly use it, i think i attempted to add one impl (i don't remember if it was this one) to our auth methods | 13:29:42 |
| uku#8192 changed their profile picture. | 15:59:30 |
12 May 2022 |
| uku#8192 changed their display name from uku#8192 to uku#0057. | 14:11:11 |
13 May 2022 |
| uku#8192 changed their display name from uku#0057 to uku#8192. | 07:40:34 |
| uku#8192 changed their profile picture. | 09:55:48 |
14 May 2022 |
| WowItsKaylie#8102 changed their display name from libregoat#8102 to WowItsKaylie#8102. | 21:58:02 |
| WowItsKaylie#8102 changed their profile picture. | 21:58:19 |
15 May 2022 |
| WowItsKaylie#8102 changed their profile picture. | 08:14:43 |
| Ivaniku changed their profile picture. | 19:20:14 |
| Ivaniku changed their profile picture. | 19:27:00 |
| Ivaniku changed their profile picture. | 19:28:25 |
| Ivaniku#4997 changed their profile picture. | 19:30:01 |
16 May 2022 |
| @idahotokens:matrix.org joined the room. | 11:26:37 |
| @idahotokens:matrix.org left the room. | 16:24:57 |
17 May 2022 |
| uku#8192 changed their profile picture. | 06:48:24 |
| Hotdog joined the room. | 11:40:48 |
| evilhotdog (she/they) joined the room. | 11:49:42 |
| uku#8192 changed their profile picture. | 19:45:07 |