9 Aug 2020 |
mcarlton | it's really more of a client skeleton than an api client, but semantics | 01:06:23 |
Oddstr13 | also, I think we have like 4? entrypoints into the code, and all of them are importing everything and stuff is handled by try: pass everywhere to make that not poop itself | 01:06:32 |
Oddstr13 | yea, I think we need a new Python API client | 01:07:15 |
Oddstr13 | been holding off that due to the upcoming API changes tho | 01:07:35 |
Oddstr13 | that's going to be pure hell getting the kodi addon updated for | 01:07:57 |
iwalton3 | I mean the API client itself is fine, just the way it is created in Kodi is confusing. | 01:08:14 |
Oddstr13 | I honestly haven't gone looking too much thru the code except from fixing bugs and styling issues when I come over them | 01:09:21 |
Oddstr13 | that, and adding logging. a bunch of logging. | 01:09:43 |
iwalton3 | Speaking of logging, the latest version of MPV Shim doesn't log API keys to the console anymore.
It makes it a lot easier to ask for logs. | 01:10:19 |
Oddstr13 | there where so many silent try blocks eating all them exceptions when we started | 01:10:27 |
Oddstr13 | do we sanitize API keys? | 01:10:59 |
mcarlton | i'd actually looked into sanitizing logs in mpv shim a few weeks ago, but since you don't have a centralized logger i got lost. | 01:11:03 |
Oddstr13 | I know we do that for IP by default | 01:11:12 |
mcarlton | yeah, kodi sanitizes both server and api_key | 01:11:14 |
Oddstr13 | well, for the exceptions we're able to catch anyways | 01:11:43 |
iwalton3 | All of the logging goes through a custom formatter now that removes API keys.
Previously it used basicConfig, but that doesn't let you control output as much.
https://github.com/iwalton3/jellyfin-mpv-shim/blob/master/jellyfin_mpv_shim/log_utils.py | 01:12:21 |
mcarlton | https://github.com/jellyfin/jellyfin-kodi/blob/master/jellyfin_kodi/helper/loghandler.py#L57-L62 | 01:12:46 |
Oddstr13 | I wonder how the git blame of that file looks :P | 01:13:22 |
Oddstr13 | I've touched most of the lines in loghandler it seems 😆 | 01:14:31 |
mcarlton | btw iwalton3 sneak peak of the survey results, we're a bit under 1800 responses and 13.5% of responders say they use mpv shim. no pressure 🤣 | 02:26:39 |
iwalton3 | I'm not surprised. I've looked at the download stats. | 02:27:23 |
sparky | Yeah. No pressure at all lol | 02:27:50 |
iwalton3 | https://somsubhra.com/github-release-stats/?username=iwalton3&repository=jellyfin-mpv-shim | 02:28:41 |
iwalton3 | There was also a PyPI stats page, but it is giving me errors. | 02:29:02 |
mcarlton | pypi stats are super unreliable | 02:29:35 |
iwalton3 | There is this, but yeah I wonder sometimes how much of that is bots and mirrors.
https://pepy.tech/project/jellyfin-mpv-shim | 02:30:25 |
iwalton3 | Although those numbers are believable. | 02:32:12 |
mcarlton | well I have 32 stars on github and the survey says I have 12 users, but that site says I have 1200 downloads in the lsat 30 days. riiiiiiiiight | 02:32:22 |
mcarlton | for mopidy* | 02:32:28 |
iwalton3 | The confusing thing about those stats is it shows downloads for old versions. | 02:34:19 |