17 Apr 2020 |
@neilalexander:matrix.org | then oh boy do I have a synapse bug for you | 13:14:52 |
@neilalexander:matrix.org | (maybe, I'm not sure yet) | 13:15:09 |
richvdh | oh good | 13:15:18 |
@neilalexander:matrix.org | Incidentally, what does Synapse do if an auth event is missing (regardless of whether it should be)? | 13:18:27 |
@neilalexander:matrix.org | Does it just fail the auth check or does it go looking for the event over federation? | 13:18:38 |
richvdh | no real idea :/ | 13:28:21 |
@neilalexander:matrix.org | Apr 17 13:43:09 photon-machine docker-compose[20048]: dendrite_monolith | time="2020-04-17T13:43:09.957577156Z" level=info msg="Checking event signatures for 7716 events of room state" func="Check\n\t" file=" [/go/pkg/mod/github.com/matrix-org/gomatrixserverlib@v0.0.0-20200417133955-a7b91d86e8d3/federationtypes.go:332]" req.id=LsfZRleJCPoJ req.method=POST req.path="/_matrix/client/r0/join/#irc:half-shot.uk" user_id="@neilalexander:dendrite.neilalexander.dev" Apr 17 13:43:14 photon-machine docker-compose[20048]: dendrite_monolith | time="2020-04-17T13:43:14.371418566Z" level=warning msg="Failed to join room using server" func="joinRoomUsingServers\n\t" file=" [/build/clientapi/routing/joinroom.go:291]" error="respSendJoin: gomatrixserverlib: missing auth event with ID $iN8vlyWxpyv7fAvkJYV116R/+KTj7E5XV/2g4o8qH/g for event $N4nUOWJWF2Gl1LiDP6tZeaNtaCI7WMDcbCDnqSGQNKo" req.id=LsfZRleJCPoJ req.method=POST req.path="/_matrix/client/r0/join/#irc:half-shot.uk" server=kapsi.fi user_id="@neilalexander:dendrite.neilalexander.dev" | 13:45:26 |
@neilalexander:matrix.org | Hmm | 13:45:49 |
@neilalexander:matrix.org | Different servers are returning different missing auth events, which is useful | 13:47:05 |
richvdh | yay | 13:51:40 |
@neilalexander:matrix.org | I'm currently making absolutely sure that dendrite isn't doing something stupid parsing the send_join response before I waste any of your time | 13:53:18 |
richvdh | I will not be at all surprised when you discover a whole load of bugs in synapse's join-over-federation behaviour | 13:53:15 |
richvdh | it was mostly written long before any specs existed | 13:53:41 |
@neilalexander:matrix.org | :D | 13:54:34 |
@neilalexander:matrix.org | Okay, I think I can point the finger at dendrite now partly, but in this particular instance that I'm looking at, synapse is returning the problem auth event in send_join three times :D | 13:57:49 |
@neilalexander:matrix.org | I bet this is one of those topological sorting things | 13:58:42 |
@neilalexander:matrix.org | Apr 17 15:09:08 photon-machine docker-compose[23197]: dendrite_monolith | time="2020-04-17T15:09:08.893283691Z" level=warning msg="Failed to join room using server" func="joinRoomUsingServers\n\t" file=" [/build/clientapi/routing/joinroom.go:291]" error="respSendJoin: gomatrixserverlib: event with ID \"$UuV85l8S5EzEsWdfq78Xps6Pj9G5R5sJKN1bO4j/LYU\" is not allowed by its auth_events: eventauth: \"@appservice-irc:matrix.org\" is not allowed to change the membership of \"@cg505:matrix.org\" from \"join\" to \"leave\"" req.id=UqIxkwOnEr6u req.method=POST req.path="/_matrix/client/r0/join/#irc:half-shot.uk" server=kapsi.fi user_id="@neilalexander:dendrite.neilalexander.dev" | 15:09:23 |
@neilalexander:matrix.org | heh well this is a new and interesting one | 15:09:26 |
@neilalexander:matrix.org | Redacted or Malformed Event | 15:11:33 |
| jcgruenhage joined the room. | 15:26:24 |
18 Apr 2020 |
Nico | Hi, could it happen that some PDU received by homeserver A contain event where prev_events or auth_events refer to events which are not yet known by this homeserver A ? If yes, what should A do with this event (reject) ? | 07:07:03 |
Nico | hi guess no, because all prev_events and auth_events should have been sent in previous PDUs. So that case should be treated as invalid/rejected event ? | 07:54:46 |
Ahmed Charles | I don't think the spec requires that servers get pdu's in a specific order. If one is missing, I assume that's what the api's are for that allow requesting specific events from other servers. | 08:12:48 |
@neilalexander:matrix.org | In reply to @nico:beerfactory.org Hi, could it happen that some PDU received by homeserver A contain event where prev_events or auth_events refer to events which are not yet known by this homeserver A ? If yes, what should A do with this event (reject) ? The other server can try to request the missing events before the auth checks | 08:23:27 |
Nico | Fine. | 08:24:47 |
Nico | Thanks. | 08:24:51 |
| morgan-trench joined the room. | 15:17:34 |
19 Apr 2020 |
Timo | Hey guys, I'm trying how delegated server domains work. If my username ends in :koesters.xyz, but my synapse server is on matrix.koesters.xyz, how does this redirection happen? Afaict, this endpoint https://matrix.org/docs/spec/server_server/r0.1.3#get-well-known-matrix-server is on koesters.xyz and links to matrix.koesters.xyz and all other endpoints are on that domain | 08:12:41 |
@neilalexander:matrix.org | Usually using a DNS SRV record | 08:13:44 |
@neilalexander:matrix.org | * Usually using a DNS SRV record on koesters.xyz | 08:14:12 |