| 24 Jan 2024 |
|  davetapley (Dave Tapley) joined the room. | 22:06:07 |
| 2 Apr 2024 |
 radez | @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: https://github.com/cherrypy/cherrypy/pull/2027 First stab at adding test coverage on the objects that will be effected by the cgi.parse_header copy into compat. Sry took me a while, work got heavy and I've just gotten back to taking a look at it. | 21:23:22 |
 @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
@webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: https://github.com/cherrypy/cherrypy/pull/2027 First stab at adding test coverage on the objects that will be effected by the cgi.parse_header copy into compat. Sry took me a while, work got heavy and I've just gotten back to taking a look at it. No problem! I'll check it out when able. Currently, I need to do some maintenance around Cheroot and get the release out of the door — the TLS fixes are really important. Everything else has lower priority for right now.. | 21:52:02 |
| 3 Apr 2024 |
| radez | In reply to @webknjaz:matrix.org
No problem! I'll check it out when able. Currently, I need to do some maintenance around Cheroot and get the release out of the door — the TLS fixes are really important. Everything else has lower priority for right now.. Sounds good, no rush. Thanks for the response. I imagine there's work to do on that patch, but I wanted to get something posted for us to start from. ttys | 02:42:20 |
| radez | @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: I was looking at the pep257 errors, most of them are missing docstrings. If I were to generate docstrings for these would you prefer to have docstrings with a TODO in them or a very basic "Init method for ClassXYZ" to meet the pep257 errors? | 15:48:34 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
@webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: I was looking at the pep257 errors, most of them are missing docstrings. If I were to generate docstrings for these would you prefer to have docstrings with a TODO in them or a very basic "Init method for ClassXYZ" to meet the pep257 errors? I usually do Initialize ClassName. in the title line of the initializer method docstrings. Sphinx-style params list would be nice. | 16:02:08 |
| radez | I'll probably pick at that here and there and see if I can get baseline reqs to get the pep257 stuff to succeed | 16:03:21 |
| 19 Apr 2024 |
| radez | hey @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState re: https://github.com/cherrypy/cherrypy/pull/2028 is the update for the sdist names just updating setup.py's name param or is there another place that this is declared? I'm not familiar with how the CI infrastructure is setup | 13:22:49 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
hey @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState re: https://github.com/cherrypy/cherrypy/pull/2028 is the update for the sdist names just updating setup.py's name param or is there another place that this is declared? I'm not familiar with how the CI infrastructure is setup No, don't change the packaging. Just find a variable with .tar.gz in GHA workflows that has a titlecased string. That's what needs lowercasing. | 15:13:00 |
| radez | @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: ok, https://github.com/cherrypy/cherrypy/pull/2030 appears to have fixed the issue with sdist name. I didn't put much of a commit message in there. Please let me know if you want me to put more in there. I rebased https://github.com/cherrypy/cherrypy/pull/2028 ontop of #2030 and CI runs green now re: pep257. There were a bunch of those pep257 violations so I didn't do too much more than put simple comments in that patch. Lemme know if you'd like anything in particular to be more properly satisfied than the siple comments that I've got in there. | 15:33:01 |
| radez | * @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: ok, https://github.com/cherrypy/cherrypy/pull/2030 appears to have fixed the issue with sdist name. I didn't put much of a commit message in there. Please let me know if you want me to put more in there. I rebased https://github.com/cherrypy/cherrypy/pull/2028 ontop of #2030 and CI runs green now re: pep257. There were a bunch of those pep257 violations so I didn't do too much more than put simple comments in that patch. Lemme know if you'd like anything in particular to be more properly satisfied than the simple comments that I've got in there. | 15:33:36 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
@webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: ok, https://github.com/cherrypy/cherrypy/pull/2030 appears to have fixed the issue with sdist name. I didn't put much of a commit message in there. Please let me know if you want me to put more in there. I rebased https://github.com/cherrypy/cherrypy/pull/2028 ontop of #2030 and CI runs green now re: pep257. There were a bunch of those pep257 violations so I didn't do too much more than put simple comments in that patch. Lemme know if you'd like anything in particular to be more properly satisfied than the simple comments that I've got in there. No, it actually broke the CI and no jobs started. | 18:24:47 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | That's not a valid syntax in GHA | 18:25:04 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | The original constant needs to be adjusted earlier in the process, you can't lowercase it dynamically and probably shouldn't since there would be more places likely. | 18:26:23 |
| radez | ah, ok I see the error now. I've not used GHA before :) I'll fiddle with it some more | 22:35:33 |
| radez | Successfully built cherrypy-18.9.1.dev33+g163b1be9.tar.gz and CherryPy-18.9.1.dev33+g163b1be9-py3-none-any.whl
776
looks like the tar ball and the wheel are built with different cases :/
| 22:44:54 |
| radez | * Successfully built cherrypy-18.9.1.dev33+g163b1be9.tar.gz and CherryPy-18.9.1.dev33+g163b1be9-py3-none-any.whl
looks like the tar ball and the wheel are built with different cases :/
| 22:45:09 |
| 20 Apr 2024 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
ah, ok I see the error now. I've not used GHA before :) I'll fiddle with it some more Yep, some things are not obvious when you don't know where to look upfront :) | 10:09:22 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | In reply to @radez:matrix.org
Successfully built cherrypy-18.9.1.dev33+g163b1be9.tar.gz and CherryPy-18.9.1.dev33+g163b1be9-py3-none-any.whl
looks like the tar ball and the wheel are built with different cases :/ Yep. IIRC I had two different "variables" for them (at least, in some projects like ansible/pylibssh and sphinx-contrib/towncrier) since for some projects, the names diverged even before setuptools changed the sdist normalization method.. | 10:12:04 |
| 25 Apr 2024 |
|  @sergiomassa:sibnsk.net removed their profile picture. | 23:01:28 |
| 26 Apr 2024 |
| @sergiomassa:sibnsk.net removed their display name Sergio Massa. | 00:16:54 |
| @sergiomassa:sibnsk.net left the room. | 00:23:33 |
| 21 May 2024 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | radez I'll try to dedicate some more attention to your PRs while I'm at the PyCon US Sprints this week. I'll pick them up myself where I can, if I have enough time in between talking to various people here... | 19:26:41 |
| radez | Sounds good, let me know if I can help in any way. | 19:48:46 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | radez so I rewrote the last test in the way you intended it to work and paused for now. Would you mind looking into fixing the params there? | 20:15:37 |
| 27 May 2024 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | radez so I didn't get to complete the docstrings PR review/updates during the sprints. Evidently, it takes a lot of time to go file-by-file and make meaningful edits. I'll be doing it as time permits and I meanwhile you can focus on #2027 which isn't blocked on my reviews currently. | 20:34:45 |
| 2 Jul 2024 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | radez: I've finally completed and merged the docstrings PR. It was a huge chunk of work that I never could get to completing. So thank you for starting the process and spending the time!
I also looked into #2027 and confirmed that some tests there are failing. Could you, please, check what needs to be done there?
| 12:37:33 |
| radez | @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState: very cool to hear! glad that work could benefit the project :) I'll put #2027 on my list to take a look at sometime this week hopefully and I'll be back in touch. Thanks for the update | 13:08:50 |
| @webknjaz 🇺🇦 #StandWithUkraine | https://stand-with-ukraine.pp.ua | #russiaIsANaziState | No problem! | 14:00:55 |
| 3 Jul 2024 |
|  @bmxp-56fbf07f85d51f252abba19d:gitter.im left the room. | 11:26:29 |
