19 May 2022 |
bridge-bot | <Amin>@mateodaza @MoeNick @Cherik Sentry has an ignore button for each issue
https://cdn.discordapp.com/attachments/707035703074357259/976835455330955354/unknown.png | 13:15:21 |
bridge-bot | <MoeShehab>Hey guys <@&899732819499155527> I have enabled discord notifications from Sentry for the below projects:
- giveth-dapp-production
- giveth-dapps-v2-productions
- bridge-trace
- giveth-trace-backend
- impact-graph
You can check the logs in the Monitoring section in discord under monitoring-sentry-givethio (Might change this name later to sentry-alerts) | 13:33:30 |
bridge-bot | <Giantkin>Name changed to #sentry-alerts | 14:05:17 |
20 May 2022 |
bridge-bot | <MoeShehab>Thanks @Giantkin ♥️ | 08:34:25 |
25 May 2022 |
bridge-bot | <MoeNick>Hey @divine_comedian can we use autopilot for sending the verification email?
@Carlos096 fyi, related to verification epic. | 14:08:22 |
bridge-bot | <Carlos096>I think we can, it's creating the event and the params. The rest is configured in autopilot | 14:09:00 |
bridge-bot | <divine_comedian>yesss @WhyldWanderer and @Cotabe are currently managing autopilot | 14:09:28 |
bridge-bot | <divine_comedian>but anything segment related I can help | 14:09:34 |
bridge-bot | <MoeNick>It should be timing in the backend after requesting verification triggred, so in this period of time they have to respond and verify, if not, they have to ask again, and impact graph may have this services and the cerification code somewhere.
https://cdn.discordapp.com/attachments/707035703074357259/979023865005096970/unknown.png | 14:11:19 |
bridge-bot | <Carlos096>When in the flow does it send the email? when it submits the form? | 14:13:48 |
bridge-bot | <Carlos096>I can add it | 14:14:23 |
bridge-bot | <Carlos096>to the PR | 14:14:25 |
bridge-bot | <MoeNick>in this step actually
https://cdn.discordapp.com/attachments/707035703074357259/979024993134469140/unknown.png | 14:15:48 |
bridge-bot | <WhyldWanderer>Its possible...
What are the requirements? Does the user need to click a unique link to verify? or are they sent a code?
What is the flow? | 14:16:12 |
bridge-bot | <MoeNick>1- PM clicks on the verify email button in personal info
2- PM giot and email with hidden code in the link
3- in a specific period of time, PM should click on the link.
4- PM gets back to a page that says the email is verified and if they come back to this step they can see the email as verified and disabled field. | 14:18:32 |
bridge-bot | <MoeNick>https://github.com/Giveth/giveth-dapps-v2/issues/746#issuecomment-1137279603 | 14:19:43 |
bridge-bot | <MoeNick>We mentioned you here already for confirmation 🙂 | 14:20:09 |
bridge-bot | <WhyldWanderer>Hmm... I'm unsure how to put this functionality on the button...
Maybe @Cotabe has an idea of how we can set this up in autopilot. | 14:24:25 |
bridge-bot | <MoeNick>I think @Carlos096 already approved he can use the endpoint 😉
But I only need to make sure about expiration of this verification code on the backed @Carlos096
so one service is email verification requested, code gererated with a expiration date, and another is call-back from user to make it verified. | 14:29:41 |
bridge-bot | <Cotabe>🤔 🤔 🤔 I think it's adding a link to the button. However I am not sure if each link will be personalized or will be the same "verified-link" but it opens already in the account? | 14:41:22 |
bridge-bot | <WhyldWanderer>I think it would have to be personalized since each link is unique... | 14:51:33 |
bridge-bot | <MoeNick>Yes exactly, we pass the params in the link, for each person-request. | 14:52:34 |
bridge-bot | <Cotabe>Then, I'm not sure how to automate it either, but @ahmad described something similar we could do for automating donors course POAPs | 15:09:08 |
bridge-bot | <Cotabe>https://discord.com/channels/679428761438912522/790268394251354143/978396734415855656 | 15:09:37 |
bridge-bot | <MoeNick>Does it make sense @Carlos096 ? Where do I have to put it under the epic ? 🙂 | 15:31:24 |
bridge-bot | <Carlos096>I think make it an issue, since this is not in the pr of Mohammad, I am adding that. It would be like Implement email verification flow for the form | 15:32:33 |
bridge-bot | <MoeNick>here you are:
https://github.com/Giveth/giveth-dapps-v2/issues/804 | 15:45:45 |
bridge-bot | <MoeNick>pls lemme know if you need more information, | 15:46:02 |
bridge-bot | <Carlos096>do we have a design for the "sorry this verification code expired" | 15:46:57 |
bridge-bot | <Carlos096>or what happens when that occurs | 15:47:01 |