| 14 Dec 2018 |
| 15:16:49 |  richvdh | which would mean that your synapse branch would continue to pass against sytest develop, even if the reverse isn't true |
| 15:21:59 |  Github [@erikj:jki.re] | [matrix-org/synapse] hawkowl opened pull request #4298: Make the dependencies more like a standard Python project and hook up the optional dependencies to setuptools [open] - https://github.com/matrix-org/synapse/pull/4298 |
| 15:25:58 |  neil | In reply to @richvdh:sw1v.org
however... we probably want to preserve backwards compatibility on this 👍 |
| 15:26:22 |  hawkowl | neil: in docs/admin/ or something, there's an api doc |
| 15:26:31 | hawkowl | which will also need updating |
| 15:26:38 | neil | yes |
| 15:30:30 | richvdh | otherwise just a couple of nitpicks |
| 15:30:41 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 15:34:20 | Github [@erikj:jki.re] | [matrix-org/synapse] hawkowl synchronize pull request #4298: Make the dependencies more like a standard Python project and hook up the optional dependencies to setuptools [open] - https://github.com/matrix-org/synapse/pull/4298 |
| 15:41:09 | richvdh | hawkowl: I'm kinda coming to the conclusion that the "loading from a file" thing (as opposed to loading from the pythonpath) doesn't really work with -j |
| 15:41:26 | richvdh | do you think it would be too horrible to just set PYTHONPATH=. when running the tests? |
| 16:02:44 | hawkowl | richvdh: then you're loading the uninstalled, not the installed, synapse |
| 16:03:04 | hawkowl | the least awful way is to have tests not be some random folder but as part of the synapse package |
| 16:12:12 | richvdh | hrm |
| 16:12:23 | richvdh | I may just copy the tests somewhere for now |
| 16:41:55 | Github [@erikj:jki.re] | [matrix-org/synapse] hawkowl synchronize pull request #4298: Make the dependencies more like a standard Python project and hook up the optional dependencies to setuptools [open] - https://github.com/matrix-org/synapse/pull/4298 |
| 16:50:59 | hawkowl | https://github.com/matrix-org/synapse/pull/4215 < richvdh this is also ready for a review |
| 16:51:10 | hawkowl | and passes the tests |
| 16:56:44 | Github [@erikj:jki.re] | [matrix-org/synapse] hawkowl review_requested pull request #4298: Make the dependencies more like a standard Python project and hook up the optional dependencies to setuptools [open] - https://github.com/matrix-org/synapse/pull/4298 |
| 16:58:35 | Github [@erikj:jki.re] | [matrix-org/synapse] hawkowl edited pull request #4298: Make the dependencies more like a standard Python project and hook up the optional dependencies to setuptools [open] - https://github.com/matrix-org/synapse/pull/4298 |
| 17:18:09 | richvdh | aha |
| 17:18:10 | richvdh | cool |
| 17:18:11 | richvdh | thanks |
| 17:23:53 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 17:24:16 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 17:24:16 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 17:24:27 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 17:39:53 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 17:47:37 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile synchronize pull request #4141: create support user [open] - https://github.com/matrix-org/synapse/pull/4141 |
| 18:21:01 | Github [@erikj:jki.re] | [matrix-org/synapse] neilisfragile closed pull request #4141: create support user [closed] - https://github.com/matrix-org/synapse/pull/4141 |
