 | dev-chat | 1736 Members |
| 26 Servers |
| dev-chat | 1736 Members |
| 26 Servers |
| Sender | Message | Time |
|---|---|---|
| 31 May 2024 | ||
 DAVE | Cool, I'll check back then | 04:58:44 |
 sandreas | DAVE: Compiling isn't too hard... | 04:59:11 |
| sandreas | Once you got it working, you always have the latest version. | 04:59:29 |
| DAVE | Sure, but I am both patient and lazy | 05:00:33 |
| DAVE | Is the process documented somewhere? Maybe I'll give it a go | 05:02:06 |
| sandreas | In reply to @dayofthedave:matrix.orgThat's something I'm working on. I did ask, it seems that there are no dev docs at the moment, but I'm waiting for a merge / feedback for my pull request (https://github.com/advplyr/audiobookshelf-app/pull/1218) until I spend more time on this. | 05:04:19 |
| sandreas | I plan to collect everything I know in a dev.md and submit another PR for this. | 05:05:04 |
| DAVE | Thanks! | 05:06:06 |
 advplyr | When we got spam from matrix before it's because I had some of the channels of the server listed publicly and didn't realize it | 13:18:52 |
| advplyr |  Download image.png | 13:20:03 |
| advplyr | There have been some requests related to the search page in showing more items so a refactor might be good. All those requests should be tagged now https://github.com/advplyr/audiobookshelf/issues?q=is%3Aopen+is%3Aissue+label%3Asorting%2Ffiltering%2Fsearching+ | 18:21:59 |
 burghys | please add this https://gitlocalize.com/ for translate a calibreweb project is much simple | 19:04:13 |
| burghys | an example: https://github.com/mikespub-org/seblucas-cops/issues/86 | 19:47:11 |
 nyxholas | We investigated that a while ago but chose not to sue the site | 20:28:11 |
| nyxholas | * We investigated that a while ago but chose not to use the site | 20:28:18 |
| burghys | Can I ask why? now the translation forces me to go through all the lines one by one every time | 20:42:43 |
| nyxholas | It was a permissions and privacy thing, we couldn't find much information about Gitalocalize and GitLocalize required full account access to the owner account, it wouldn't work if it was given permission to a collaborator account to open PRs. We looked at Weblate as well, but never got that set up. | 20:53:54 |
| nyxholas | In the meantime you could do something like "view history" to see what lines changed in commits that touch the file | 20:54:28 |
| advplyr | Some users still prefer the STANDARD view. I think we should keep it. It adds some complexity to the categorized view but could be simplified in a refactor I'm sure. I added on the DETAIL view and maybe even before square covers were supported | 21:55:32 |
| advplyr | We could eliminate it from the search actually | 21:57:53 |
| advplyr | No reason the search needs to use the same categorized bookshelf component | 21:58:13 |
| advplyr | If the refactor is functioning the same as it currently does then it wouldn't make sense to make a new component. If it was being refactored in some way a new component could be made that doesn't include the standard view | 22:14:41 |
| 1 Jun 2024 | ||
| sandreas | In reply to @_discord_920732593710841917:t2bot.ioWe could at least a little script that adds a translation to save time: npm run add-translation "MyTranslation" "This is a new translation" | 04:08:39 |
| nyxholas | @sandreas not sure if mikiher's messages were coming through, there was another conversation going on after the translation talk | 04:13:15 |
| sandreas | In reply to @_discord_476196266183884800:t2bot.ioIs the topic solved? Because I did also not enjoy adding things manually :-) | 04:15:15 |
| sandreas | A little helper script add-translation.js would have been a neat time saver | 04:16:36 |
| nyxholas | I'm not sure what you mean? Advplyr runs a script that copies all of the missing keys from English to the other languages automatically and keeps all translation keys alphabetical | 04:20:12 |
| nyxholas | So if it doesn't exist in a translation file then it does not exist in en-us.json yet and needs to be added there/removed from the normal source code | 04:20:59 |
| sandreas | I mean that this could be done via client, so I could at least translate english and german (I'm a german native) | 04:21:11 |
| sandreas | Is it documented somewhere, how to add translations the correct way? Maybe I missed it. | 04:22:02 |