 | dev-chat | 1736 Members |
| 26 Servers |
| dev-chat | 1736 Members |
| 26 Servers |
| Sender | Message | Time |
|---|---|---|
| 1 Jun 2024 | ||
 sandreas | even the next few kilobytes of the audio could be cached, so that the connection could be made in the background. | 16:18:39 |
 advplyr | Yeah there are solutions that make sense but haven't been build out yet | 16:19:02 |
| sandreas | advplyr: I could take a look at it... but not until my first PR is through :-) | 16:23:20 |
| sandreas | I have to get familiar with the conventions and the other parts of the code first | 16:23:42 |
| sandreas | I'm very interested in making the app better, because it is the only one that really supports the kind of stuff I use most. | 16:27:01 |
| sandreas | Another thing is an old Fiio M6. The app does not run at all, but I'm willing to fix this :-) | 16:27:21 |
| sandreas | There is also the "app crashes" thing. I have a device where I can reproduce it. Since I added WAKE_LOCK permission to AndroidManifest.xml, it no longer occured, but I would like to be sure about this. | 16:28:29 |
 nyxholas | Also advplyr , I spent some time playing with Weblate last night/this morning, and looks like it'll work out pretty well. It only needed access to my GH e-mail, and is able to work without push access to the repo (this would require manual download/commit), or we can give it access to open PRs. We currently have about ~21k translation units for the web repo including all languages, and the apps will be around 18k units. They do offer free hosting for up to 160k units for public projects, so we should be able to support ~80 langugaes unless we add more strings/web docs (about 2k units per language). Mind if I continue down this path, or do you still want the manual JSON files? | 16:29:45 |
| advplyr | I don't think old android versions should be supported because it is not something I will be testing on for every release. I wrote about this more on a PR that made updates to supported android 7 I think it was | 16:29:54 |
| advplyr | Do they have an API to use to setup our own workflow to merge updates? | 16:32:34 |
| sandreas | In reply to @_discord_920732593710841917:t2bot.ioNah this is not something you'd have to take care about... I would only submit patches that are non destructive for newer devices / features. | 16:33:35 |
| advplyr | I assumed the old device you mentioned would be using an older Android version | 16:36:03 |
| sandreas | In reply to @_discord_920732593710841917:t2bot.ioIt does... (Android 7.0) but I would just fix "exceptions" that stop audiobookshelf-app from working in a way that does not break newer devices. | 16:37:46 |
| sandreas | But I did not look into this yet. Let's first make it work for my Unihertz Jelly 2e :-) | 16:38:14 |
| sandreas | Android 11 is better. | 16:38:28 |
| sandreas | Android 7 does not support Headset clicks well enough (there are no differences between keyup and keydown). | 16:38:56 |
| sandreas | Ah by the way: Do we have a Server to self-host stuff? If so, maybe you could also take a look at https://tolgee.io for translations. It's self-hostable | 16:40:53 |
| sandreas | Tolgee tech stack is similar to audiobookshelf stack | 16:41:57 |
| nyxholas | They do have an API, so we could probably set something custom up to merge Weblate -> GH, or use the "open a PR" option from a fork or something https://docs.weblate.org/en/latest/admin/continuous.html#push-changes. Looks like a common way to do it is "nightly" instead of on every commit Weblate can automatically update from GH using notification hooks https://docs.weblate.org/en/latest/admin/continuous.html#automatically-receiving-changes-from-github | 17:04:16 |
| nyxholas | This is the example project I had made https://hosted.weblate.org/projects/audiobookshelf-test/abs-web-client/ | 17:05:41 |
| nyxholas | Looks like we can also just install the "Weblate App" to the audiobookshelf organization on GH and it should handle the syncing automatically https://github.com/apps/weblate | 17:30:51 |
| nyxholas | We would need to move the main server and app repo though, but maybe we could just use the main website for testing out the translation workflow? | 17:33:52 |
| nyxholas |  Download image.png | 17:50:21 |
| nyxholas | Oooh. I do like this "automatic checks" thing. Sorry, I'll stop sending messages about it | 17:50:21 |
| nyxholas | Okay, looks like should be able to just add a new collaborator of hosted@weblate.org to the repositories, and it would only need read access to the repository. This should allow PRs to be opened without needing push access https://docs.weblate.org/en/latest/vcs.html#accessing-repositories-from-hosted-weblate | 19:42:36 |
 dieseltech | Yeah weblate makes that easy | 20:08:33 |
| dieseltech | We have the same setup for Kavita | 20:08:39 |
| sandreas | In reply to @_discord_336088571410907136:t2bot.ioKavita is AWESOME :-) | 20:17:28 |
 DAVE | May I have an invitation code for the iOS TestFlight? Also agreed: Kavita is awesome 😁 | 21:28:51 |
| dieseltech | The codes aren't controlled by the project | 21:31:52 |