25 Mar 2024 |
Mikoto ⚡️ | could this help with upgrading? haven't used it myself but sed has its limits when performing regressions | 14:52:31 |
| Mikoto ⚡️ changed their display name from mikoto ⚡️ to Mikoto ⚡️. | 19:04:49 |
Jonas Platte | In reply to @mikoto:kurosaki.cx Because I didnt have time to open it yet :D Then yes, you can open an issue for the thing you want to implement if there isn't one. Or you can push what you have and make a WIP PR. | 19:53:10 |
Jonas Platte | In reply to @mikoto:kurosaki.cx could this help with upgrading? haven't used it myself but sed has its limits when performing regressions I don't think that the upgrade will include many mechanical changes to many different code places such that automation would be helpfuil | 20:00:12 |
Jonas Platte | In reply to @mikoto:kurosaki.cx could this help with upgrading? haven't used it myself but sed has its limits when performing regressions * I don't think that the upgrade will include many mechanical changes to many different code places such that automation would be helpful | 20:00:15 |
26 Mar 2024 |
Mikoto ⚡️ | In reply to @jplatte:flipdot.org Did you see that my code snippet in #680 also contains suggested impl blocks alongside the trait declarations? I will try to have another look at this today | 15:11:56 |
Mikoto ⚡️ | Although Im already not sure what makes Raw distinct from RawExt | 15:12:16 |
Mikoto ⚡️ | Latter is just a trait to convert to the former? | 15:12:37 |
Jonas Platte | RawExt is an extension trait for the Raw type | 17:25:00 |
27 Mar 2024 |
strawberry (it/pup/she/they) 🏳️⚧️ 🦴💜🩷 | for the relation endpoints in the ruma-client-api crate, why is recursion_depth Response field private?
https://github.com/ruma/ruma/commit/1d66031f8bda793beb64504e690a38eabaef338d
conduit doesn't use the new constructor, they specify the other fields like next_batch explicitly too, so this field being private makes it impossible to upgrade ruma past this point
// src/api/client_server/relations.rs
Ok(get_relating_events_with_rel_type::v1::Response {
chunk: res.chunk,
next_batch: res.next_batch,
prev_batch: res.prev_batch,
})
i could be wrong, but im not sure how to set recursion_depth in the Response struct to None if the field is private now and i can't use the constructor because we need to specify the next and prev batches.
| 16:29:01 |
Kévin Commaille | In reply to @strawberry:puppygock.gay
for the relation endpoints in the ruma-client-api crate, why is recursion_depth Response field private?
https://github.com/ruma/ruma/commit/1d66031f8bda793beb64504e690a38eabaef338d
conduit doesn't use the new constructor, they specify the other fields like next_batch explicitly too, so this field being private makes it impossible to upgrade ruma past this point
// src/api/client_server/relations.rs
Ok(get_relating_events_with_rel_type::v1::Response {
chunk: res.chunk,
next_batch: res.next_batch,
prev_batch: res.prev_batch,
})
i could be wrong, but im not sure how to set recursion_depth in the Response struct to None if the field is private now and i can't use the constructor because we need to specify the next and prev batches.
A mistake | 16:32:12 |
strawberry (it/pup/she/they) 🏳️⚧️ 🦴💜🩷 | ah ok, i was leaning towards that but i felt like i just didn't understand | 16:32:35 |
strawberry (it/pup/she/they) 🏳️⚧️ 🦴💜🩷 | i submitted a PR with a couple other relations stuff, can i fix that there? | 16:33:00 |
Kévin Commaille | Sure | 16:40:54 |
| @kaiyou:tedomum.net left the room. | 17:05:25 |
Mikoto ⚡️ | https://spec.matrix.org/unstable/appendices/#historical-user-ids | 20:46:05 |
Mikoto ⚡️ | * https://spec.matrix.org/unstable/appendices/#user-identifiers | 20:46:44 |
Mikoto ⚡️ | failed to create account e=Matrix(FromHttpResponse(Server(MatrixError { status_code: 400, body: Json(Object {"errcode": String("M_INVALID_USERNAME"), "error": String("User ID may not begin with _")}) })))
| 20:46:58 |
Mikoto ⚡️ | hmmm? | 20:47:00 |
Mikoto ⚡️ | user_id: "@=ok:matrix.localhost" | 20:48:30 |
Mikoto ⚡️ | other symbols like = seem to be allowed | 20:48:39 |
Mikoto ⚡️ | weird | 20:48:41 |
Matthias | User ID may not begin with _
Very odd, since that isn't what's happening. | 20:52:02 |
Kévin Commaille | In reply to @mikoto:kurosaki.cx
failed to create account e=Matrix(FromHttpResponse(Server(MatrixError { status_code: 400, body: Json(Object {"errcode": String("M_INVALID_USERNAME"), "error": String("User ID may not begin with _")}) })))
Are you testing with Synapse? | 21:02:25 |
Mikoto ⚡️ | In reply to @zecakeh:tedomum.net Are you testing with Synapse? Yup | 21:28:35 |
Mikoto ⚡️ | Seems to be Synapse-specific | 21:28:43 |
Mikoto ⚡️ | A bit annoying to not have these deviations from the spec listed somewhere, was lucky enough to catch it by chance | 21:29:33 |
Kévin Commaille | Looking at Synapse's code, it does only check for _ for this error. So it must be a bug somewhere | 21:40:19 |
28 Mar 2024 |
| @benjib:element.io left the room. | 14:37:35 |
| ryanb485 joined the room. | 18:20:22 |