Hello all! Have a support question about monkeypatching Decidim Decidim::AccountForm. Seems any method I try to use brings up a validation error: /activemodel-6.0.4.1/lib/active_model/validations/validates.rb:121:in `rescue in block in validates': Unknown validator: 'ValidEmail2::EmailValidator' (ArgumentError) . Apparently as soon as I reopen or call Decidim::AccountForm to place the patch, wither using class_eval, prepend or include it fails to load the validator on line 23: validates :email, presence: true, 'valid_email_2/email': { disposable: true }. Has happened with other patches too, for example, if I try to patch Decidim::User it'll fail to validate has_one_attached :avatar even thought I am not touching that validator with my patch.I guess it is not loading the files properly. Does anybody have a clue as to what is the better procedure to monkeypatch in this way? I put together a simple example:

https://gist.github.com/basicavisual/fe0030c68c44f9a4e1898b0f613d11cf

Hello all! Have a support question about monkeypatching Decidim, for example, Decidim::AccountForm. Seems any method I try to use brings up a validation error: /activemodel-6.0.4.1/lib/active_model/validations/validates.rb:121:in `rescue in block in validates': Unknown validator: 'ValidEmail2::EmailValidator' (ArgumentError) . Apparently as soon as I reopen or call Decidim::AccountForm to place the patch, wither using class_eval, prepend or include it fails to load the validator on line 23: validates :email, presence: true, 'valid_email_2/email': { disposable: true }. Has happened with other patches too, for example, if I try to patch Decidim::User it'll fail to validate has_one_attached :avatar even thought I am not touching that validator with my patch.I guess it is not loading the files properly. Does anybody have a clue as to what is the better procedure to monkeypatch in this way? I put together a simple example:

https://gist.github.com/basicavisual/fe0030c68c44f9a4e1898b0f613d11cf

Hello all! Have a support question about monkeypatching Decidim, for example, Decidim::AccountForm. Seems any method I try to use brings up a validation error: /activemodel-6.0.4.1/lib/active_model/validations/validates.rb:121:in `rescue in block in validates': Unknown validator: 'ValidEmail2::EmailValidator' (ArgumentError) . Apparently as soon as I reopen or call Decidim::AccountForm to place the patch, either using class_eval, prepend or include it fails to load the validator on line 23: validates :email, presence: true, 'valid_email_2/email': { disposable: true }. Has happened with other patches too, for example, if I try to patch Decidim::User it'll fail to validate has_one_attached :avatar even thought I am not touching that validator with my patch.I guess it is not loading the files properly. Does anybody have a clue as to what is the better procedure to monkeypatch in this way? I put together a simple example:

https://gist.github.com/basicavisual/fe0030c68c44f9a4e1898b0f613d11cf

Hello all! Have a support question about monkeypatching Decidim, for example, Decidim::AccountForm. Seems any method I try to use brings up a validation error: /activemodel-6.0.4.1/lib/active_model/validations/validates.rb:121:in `rescue in block in validates': Unknown validator: 'ValidEmail2::EmailValidator' (ArgumentError) . Apparently as soon as I reopen or call Decidim::AccountForm to place the patch, either using class_eval, prepend or include it fails to load the validator on line Decidim::AccountForm:23 validates :email, presence: true, 'valid_email_2/email': { disposable: true }. Has happened with other patches too, for example, if I try to patch Decidim::User it'll fail to validate has_one_attached :avatar even thought I am not touching that validator with my patch.I guess it is not loading the files properly. Does anybody have a clue as to what is the better procedure to monkeypatch in this way? I put together a simple example:

https://gist.github.com/basicavisual/fe0030c68c44f9a4e1898b0f613d11cf

hi ali, all good?
Let say you are overriding AccountForm with the module you sent.
The override contains map_model that will replace the Decidim::AccountForm#map_model. When you call super, it will call map_model of the Decidim::AccountForm parent (Decidim::Form).

So at the end, your form does not have the right mapping and raise a validation error

To do this, I create an alias in the override:
'''
alias :decidim_original_map_model, :map_model

def map_model(model)
decidim_original_map_model(model)

your logics

end
'''

Warning: I am in my phone doing by head, might have some errors there

Hey Hadrien! long time no see! thanks for the response. I'll check exactly if map_model is even inherited because it is not present in AccountForm, however if I remove the super keyword I get get the same error.

Just double checked if I go the prepend or include route i'll get undefined method attribute' for Decidim::AccountFormOverride:Module (NoMethodError) Did you mean? attr_writer mind you this code worked in :classic mode, it is only after switching to :zeitwerk (yes... i know) that it is breaking so I suspect I'm missing something obvious

Hey Hadrien! long time no see! thanks for the response. I'll check exactly if map_model is even inherited because it is not present in AccountForm, however if I remove the super keyword I get get the same error.

Just double checked if I go the .prepend or .include route i'll get undefined method attribute' for Decidim::AccountFormOverride:Module (NoMethodError) Did you mean? attr_writer mind you this code worked in :classic mode, it is only after switching to :zeitwerk (yes... i know) that it is breaking so I suspect I'm missing something obvious

sorry, didn't check the code of the AccountForm. Indeed your code looks correct and the error you get is strange.
So from what I understand you make a patch directly in the app that run the decidim. That's something I never did :)

I read things here https://rewind.com/blog/zeitwerk-autoloader-rails-app/ that tells me it is nothing trivial to inject code in a rails engine, as each engine have its own inflector.

soooo I am afraid I can't help in this one ;)

but hey, never had this issue, and I did not started to move to 0.28 our modules yet. Sooo maybe it does not resolve your issue.

When I have these edge case, I look at decidim-awesome engines and overwrites, most of the time it gives me the insights to move forward my patches. Maybe having.a read on the last develop version there gives you some hints

hi! how are you with this?
Just having an idea. What if you reference account with its absolute form?

::Decidim::AccountForm.prepend Decidim::AccountFormOverride

Reading more about zeitwerk, it looks like this kind of reference does make a difference.