17 Dec 2019 |
@x:riot.ovh | the dropdowns are for Language and Phone Number country in Settings | 14:32:47 |
Nolan | Yeah, timeline issue definitely happening in Firefox/Orca. Came here to ask about it. | 14:37:23 |
Nolan | Sad that there appear to be some Orca-specific issues. I still get pretty aggressively stuck in the message entry field. I imagine that's Orca/AT-SPI-related but I know next to nothing about hacking either and don't really have time to learn. :( | 14:38:32 |
Nolan | But glad things work under Windows. That probably means Riot is as correct as it can be. | 14:38:59 |
Marco Zehe | Ah, great, those work great now as well. | 14:58:40 |
Marco Zehe | Escape seems to be a bit overcealous.In the dropdowns, pressing Escape I expect to just close the dropdown and land back on the button that activated it. Instead, the whole dialog closes and I am back on the Profile menu button. | 14:59:33 |
@x:riot.ovh | Interesting, I thought I tested that, should be simple fix | 15:03:33 |
@x:riot.ovh | made a PR to fix it | 15:16:28 |
| @guido:feneas.org joined the room. | 23:01:37 |
18 Dec 2019 |
@x:riot.ovh | How should an emoji picker (shown as a context menu from the message action bar button, and in future maybe also next to composer) present itself to aria? Graphically at the top it has "tabs" which act as jump-anchors to the relevant section, they are also highlighted based on which section is currently in the visible viewport. Then there is a search field and below that are the emojis themselves, grouped into categories. I presume arrow keys should be used to navigate between tabs and also across the emojis but would up/left and right/down do the same thing? | 13:48:12 |
@x:riot.ovh | or should it be grid like even though you can't easily tell the width of the grid | 13:49:17 |
@x:riot.ovh | the picker is based on emoji-mart and rugk commented there with a proposed solution which seems to have positive feedback, should I implement something along those lines? https://github.com/missive/emoji-mart/issues/348 | 13:50:02 |
Peter Vágner | I think visually those are tabs but they are not loading different content into the page control the tabs cause the grid to scroll selected category of emojis into view. So exposing those tabs as radio buttons or links might be enough.
How the grid will be controlled via the keyboard is a question for you looking at the emojis visually I think. I.e. do you think it's a good idea to move in all four directions? If yes then it should be marked as a grid with corresponding keyboard controls. If moving in all directions over the emojis in a grid is not expected then it might be conveyed the way combobox is. I.e. entering the text into the edit field filters out the results and using arrow keys navigates in the list. | 14:08:09 |
@x:riot.ovh | Peter Vágner: multiple tabs can be "active" at once if the grid is in between two categories so radios wouldn't play too well | 14:22:24 |
@x:riot.ovh | so I do think full four-way grid arrow key control will be much faster for sighted keyboard power-users, but would that not be jarring for non-sighted folk? | 14:23:16 |
Peter Vágner | It might be a bit surprising for blind users but I think if the container will get role = grid they can easily understand that they should navigate in all the directions. | 14:26:18 |
Peter Vágner | Additionally perhaps the search field should get an aria-label saying filter emojis similar how filtering room and chat filtering is working now. | 14:28:16 |
Peter Vágner | Or perhaps let's wait a bit what Marco Zehe thinks of it | 14:29:24 |
Marco Zehe | Emoji pickers that work in all four directions are not uncommon. The Windows 10 emoji picker, WindowsKey+Period, for example, works that way. It contains navigation to one category, though, so you have tabs that select one category, and only that category can then be navigated. Or you can search by typing, even though there is no explicit search field, only a search tab. | 14:35:53 |
Marco Zehe | The ideas on that EmojiMart issue sound reasonable. I see that Nolan Lawson also commented on it, I think he was thinking of using this for Pinafore at some point, but then did something else because of accessibility. | 14:39:53 |
@x:riot.ovh | How did I not know about WindowsKey+Period :D | 14:43:05 |
@x:riot.ovh | thank you both, I think I have enough information to proceed :) | 14:43:46 |
Marco Zehe | Awesome! | 14:44:56 |
19 Dec 2019 |
@x:riot.ovh | Interestingly the Emoji Picker in Pinafore IS emoji-mart, with its sub-par accessibility (arrow keys scroll the viewport, tab to go between the thousands of emojis) | 08:02:23 |
Marco Zehe | Hah, interesting. See how often I actually use that. 🙂 I always use the Windows one apparently. | 09:25:39 |
@x:riot.ovh | So I tried using a grid for it and it was too noisy with columns and such | 09:27:14 |
@x:riot.ovh | i'm looking at slack and they use listbox + rowgroup + row + button | 09:27:24 |
@x:riot.ovh | which works really well IMO | 09:27:30 |
@x:riot.ovh | biggest issue with grid was the gridcell + button combination got read out twice
EMOJI_NAME column N, EMOJI_NAME button not selected | 09:28:10 |
Marco Zehe | Oh, right. Yeah the Slack implementation works well. No harm in borrowing from them. :-) | 09:53:04 |