16 Sep 2024 |
Catherine | we should do raise ConnectionError(...) from layout_err | 17:16:10 |
zyp | in 0.6, we'd suppress it and give a deprecation warning | 17:17:14 |
Catherine | in the reference-level explanation, it might make more sense to explain it in terms of what's accepted, not what's rejected | 17:19:12 |
Catherine | the current wording is kind of confusing | 17:19:19 |
zyp | I figured since the RFC proposes to reject things that were accepted before, listing the rejections makes it more clear what is changing, and then the documentation afterwards are written in terms of what's accepted | 17:21:33 |
Catherine | I'm fine with it either way really | 17:22:07 |
Catherine | anything else? we did have a point from Wanda on it increasing language (stdlib, I guess) complexity, which is true | 17:22:28 |
Catherine | without necessarily structuring the complexity well | 17:22:45 |
Catherine | I feel that at some point we'll have to rethink the existing ValueCastable/ShapeCastable system a bit, in a largely-backwards-compatible way, to make it more nicely structured, but I also don't feel like we're at that point yet | 17:23:35 |
Wanda | I'm fine with this RFC as long as the enum thing is fixed to accept any ValueCastable with the same shape | 17:24:18 |
zyp | how do I word it?
If other is a ValueCastable , reject the assignment if self.shape() != other.shape() something like that?
| 17:26:30 |
zyp | * how do I word it?
If other is a ValueCastable , reject the assignment if self.shape() != other.shape()
something like that?
| 17:26:35 |
Catherine | Wanda? | 17:30:51 |
Wanda | yeah looks good | 17:31:01 |
zyp | I'm happy with that change | 17:32:19 |
Catherine | okay, please respond with your disposition for RFC #73: merge or close | 17:33:12 |
Catherine | mine is merge | 17:33:14 |
jfng | merge | 17:33:24 |
Catherine | disposition on RFC 73: merge | 17:55:05 |
_whitenotifier-1 | [rfcs] whitequark commented on pull request #73: Add RFC for stricter connections. - https://github.com/amaranth-lang/rfcs/pull/73#issuecomment-2353557025 | 17:56:14 |
_whitenotifier-1 | [amaranth] zyp opened issue #1511: Tracking issue for RFC 73: Stricter connections. - https://github.com/amaranth-lang/amaranth/issues/1511 | 18:00:56 |
_whitenotifier-1 | [rfcs] whitequark closed pull request #73: Add RFC for stricter connections. - https://github.com/amaranth-lang/rfcs/pull/73 | 18:06:11 |
_whitenotifier-1 | [amaranth-lang/rfcs] whitequark pushed 5 commits to main [+2/-0/±3] https://github.com/amaranth-lang/rfcs/compare/4352e0d663e3...2979ebfbefe6 | 18:06:13 |
_whitenotifier-1 | [amaranth-lang/rfcs] zyp b2c2204 - RFC #73: Stricter connections. | 18:06:14 |
_whitenotifier-1 | [amaranth-lang/rfcs] zyp d195662 - RFC #73: Use `Layout.cast()` when checking for matching layouts. | 18:06:16 |
_whitenotifier-1 | [amaranth-lang/rfcs] zyp d660bfc - RFC #73: Add checks to `lib.enum` too. | 18:06:17 |
_whitenotifier-1 | [amaranth-lang/rfcs] ... and 2 more commits. | 18:06:19 |
_whitenotifier-1 | [rfcs] whitequark commented on pull request #73: Add RFC for stricter connections. - https://github.com/amaranth-lang/rfcs/pull/73#issuecomment-2353575763 | 18:06:21 |
_whitenotifier-1 | [amaranth-lang/amaranth-lang.github.io] whitequark pushed 1 commit to main [+1/-0/±57] https://github.com/amaranth-lang/amaranth-lang.github.io/compare/67c0cb495ef4...8841c9ad346b | 18:06:37 |
_whitenotifier-1 | [amaranth-lang/amaranth-lang.github.io] whitequark 8841c9a - Deploying to main from @ amaranth-lang/rfcs@2979ebfbefe6c9b64f48696b1d4d3ca2c402a91e 🚀 | 18:06:38 |