| 13 Apr 2021 |
 psi29a#3708 | Then we shouldn't have this ability in the game-engine I believe; a slider for lights maybe... but if we're going to jacking up the rendering manager to fit this one use-case, then what's the point? | 22:58:18 |
 AnyOldName3#5223 | I think there's maybe a version of recreate shaders somewhere that applies shader visitors to the whole scene, but I don't think it's likely to be something we're using like that. | 22:58:55 |
 wazabear_notabear#7403 | It's not one use, you need to do that if you want the shadows tab back. | 22:59:03 |
| psi29a#3708 | Most games, when dealing with advanced features usually have you restart anyway. | 22:59:07 |
| AnyOldName3#5223 | It's only toggling shadows and toggling one lighting mode that need a restart. It's reasonable to save the setting and display a popup saying it won't apply until the engine's restarted. | 23:00:11 |
| AnyOldName3#5223 | All the other shadow settings can be done at runtime without invasive changes. | 23:01:14 |
| AnyOldName3#5223 | Same with all the lighting ones. | 23:01:23 |
| psi29a#3708 | That's fine then. | 23:01:30 |
| psi29a#3708 | Another coverity scan inbound | 23:05:58 |
| wazabear_notabear#7403 | Should I remove the combobox from the launcher or keep it? | 23:15:35 |
| wazabear_notabear#7403 | Some settings are doubled in launcher (like viewing distance) so not sure the standard for this. | 23:16:46 |
|  Ian Ironstorm joined the room. | 23:54:48 |
| 14 Apr 2021 |
 Tauin#4754 | impossible | 01:35:33 |
| Tauin#4754 | * impossible | 01:35:38 |
|  Pharod joined the room. | 02:54:35 |
|  skymind joined the room. | 05:28:09 |
| psi29a#3708 | Analysis Summary:
New defects found: 4
Defects eliminated: 21
Nice work guys! | 07:36:56 |
| psi29a#3708 | * Snapshot taken after fixes came in and Lights were merged.
Analysis Summary:
New defects found: 4
Defects eliminated: 21
Nice work guys! | 07:37:30 |
| Tauin#4754 | cool | 07:53:40 |
 akortunov#7058 | MSVC spams these warnings about ESM::Variant now: | 07:55:07 |
| akortunov#7058 | C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\variant(538): warning C4582: 'std::_Variant_storage_<false,int,float,std::string>::_Tail': constructor is not implicitly called (compiling source file C:\projects\openmw\MSVC2017_64\apps\opencs\view\doc\moc_runlogsubview.cpp) [C:\projects\openmw\MSVC2017_64\apps\opencs\openmw-cs.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\variant(527): warning C4583: 'std::_Variant_storage_<false,float,std::string>::_Tail': destructor is not implicitly called (compiling source file C:\projects\openmw\MSVC2017_64\apps\opencs\view\doc\moc_runlogsubview.cpp) [C:\projects\openmw\MSVC2017_64\apps\opencs\openmw-cs.vcxproj]
| 07:55:19 |
| akortunov#7058 | * C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\variant(538): warning C4582: 'std::_Variant_storage_<false,int,float,std::string>::_Tail': constructor is not implicitly called (compiling source file C:\projects\openmw\MSVC2017_64\apps\opencs\view\doc\moc_runlogsubview.cpp) [C:\projects\openmw\MSVC2017_64\apps\opencs\openmw-cs.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\variant(527): warning C4583: 'std::_Variant_storage_<false,float,std::string>::_Tail': destructor is not implicitly called (compiling source file C:\projects\openmw\MSVC2017_64\apps\opencs\view\doc\moc_runlogsubview.cpp) [C:\projects\openmw\MSVC2017_64\apps\opencs\openmw-cs.vcxproj]
| 07:55:51 |
| akortunov#7058 | May be ab another bug in Microsoft libraries, though. | 07:56:12 |
| akortunov#7058 | Also for some reason I do not see constructors for all supported types: | 08:04:28 |
| akortunov#7058 | explicit Variant(const std::string& value) : mType(VT_String), mData(value) {}
explicit Variant(std::string&& value) : mType(VT_String), mData(std::move(value)) {}
explicit Variant(int value) : mType(VT_Long), mData(value) {}
explicit Variant(float value) : mType(VT_Float), mData(value) {}
| 08:04:37 |
| akortunov#7058 | No VT_Int or VT_Short. | 08:04:53 |
| akortunov#7058 | * May be an another bug in Microsoft libraries, though. | 08:09:14 |
| akortunov#7058 | elsid, can we get a situation when MSVC does something stupid and we will get platform-specific issues here? | 08:10:46 |
| psi29a#3708 | Crappy... on Mac Big Sur 11.0, having issues with /extern/osgQt with Qt5:
In file included from /Users/bret/Workspace/private/openmw/extern/osgQt/GraphicsWindowQt.cpp:14:
In file included from /Users/bret/Workspace/private/openmw/extern/osgQt/GraphicsWindowQt:22:
In file included from /usr/local/opt/qt@5/lib/QtCore.framework/Headers/QSet:1:
/usr/local/opt/qt@5/lib/QtCore.framework/Headers/qset.h:136:16: error: 'deprecated' attribute cannot be applied to types
inline QT_DEPRECATED_VERSION_5_15 iterator &operator--() { --i; return *this; }
^
/usr/local/include/QtCore/qglobal.h:355:45: note: expanded from macro 'QT_DEPRECATED_VERSION_5_15'
# define QT_DEPRECATED_VERSION_5_15 QT_DEPRECATED
^
/usr/local/include/QtCore/qglobal.h:272:25: note: expanded from macro 'QT_DEPRECATED'
# define QT_DEPRECATED Q_DECL_DEPRECATED
^
/usr/local/include/QtCore/qcompilerdetection.h:1152:31: note: expanded from macro 'Q_DECL_DEPRECATED'
# define Q_DECL_DEPRECATED [[deprecated]]
^
| 08:46:36 |
| psi29a#3708 | Ah, seems to be that cmake found.my Qt6 headers and used those instead of Qt5, suck. Fixed... moving on. | 08:53:54 |
