27 Apr 2024 |
albertfree | vs code also provides completions, as it knows what names exist | 15:10:30 |
lewri | Wait what, lua is meant to use 3 spaces indent as standard? | 15:10:34 |
albertfree | is it? | 15:10:51 |
lewri | http://sputnik.freewisdom.org/en/Coding_Standard | 15:10:48 |
albertfree | no idea, I'd prefer 4 :p | 15:11:55 |
lewri | Actually 3 seems to be strange even to Lua itself, it uses 2 in the PIL stuff | 15:12:32 |
lewri | 4? what is this, python? | 15:12:50 |
albertfree | I am not sure why we have 2, I mean, the screen is wide enough, why this minimal differences in indents. It's complicating to find matching lines | 15:14:03 |
albertfree | we can also use TAB, and everybody can change tab size to their liking :) | 15:14:38 |
lewri | Probably tradition | 15:14:47 |
albertfree | people still living in the 80s with 80x24 :p | 15:15:37 |
lewri | I'm just happy that vscode shows nesting much better than Brackets did with the vertical lines | 15:15:40 |
albertfree | our functions are too long, we should use more functions with shorter bodies | 15:17:14 |
albertfree | lol, a dark-green jungle theme :) | 15:27:19 |
| sannd0w joined the room. | 18:26:06 |
| Nettles | 21:09:47 |
lewri | Are the changes to 2541 okay to merge now? | 21:50:45 |
28 Apr 2024 |
thecycoone | I think we talked before about conforming to the lua doc style of some of the vscode extensions. A never ending mission chasing IDE specific conventions - I forget the name of the editor our lua was first coded for | 00:43:23 |
thecycoone | yes that PR is good to merge | 00:46:25 |
thecycoone | I've replaced the download link with https | 00:50:13 |
thecycoone | unblocks libcurl? | 00:50:18 |
thecycoone | and I fiddled so it no longer tries and fails to do the check when disabled and no longer shows that it's not doing the check if not compiled in. | 01:21:14 |
thecycoone | only if it is compiled in and disabled in config | 01:21:25 |
thecycoone | probably good | 01:21:43 |
albertfree | changing luadoc style is fine, I am more worried about the extension not understanding that different files are related even without require, not recognizing X:X() as constructor, and possibly not understanding overloading | 06:07:20 |
albertfree | They did pick a nice solution though. The user gives all type information, the code just has to check that the user also complies with that information. No need to derive type information across methods from scratch. | 06:09:55 |
| leenyboon joined the room. | 11:39:12 |
| xploitocelot joined the room. | 18:04:45 |
29 Apr 2024 |
tobylane | Cyco I have this ffmpeg linking with ssl error problem from turning updates off, with more commits on top. https://github.com/tobylane/CorsixTH/actions/runs/8868620366/job/24348399487#step:6:51 I think it's caused by securetransport, 2/3 of the way through this line https://github.com/tobylane/CorsixTH/actions/runs/8868620366/job/24348399487#step:5:515 from https://github.com/TheCycoONE/vcpkg-registry/blob/lua_cmake/ports/ffmpeg/portfile.cmake#L400 | 11:55:32 |
thecycoone | I don't know that the vcpkg-registry ffmpeg works outside of windows. I replaced it with the upstream one temporarily on my branch | 21:54:22 |