14 Apr 2021 |
hanno_jg | thus we will very likely start contributing to the matrix core package | 05:59:03 |
hanno_jg | Why the change? It appears to us that using matrix natively doesn't bring that much of an advantage as sending all chat data over the RN bridge causes big lags, because ... well, so many data.
Today I am testing whether just doing it on the JS side performs better (and it looks like it so far) | 05:59:59 |
hanno_jg | one thing that came immediately to my mind:
it is using async storage, which is currently not the fastest.
We would like to use the fastest solution available, which one of our engineers build: https://github.com/mrousavy/react-native-mmkv
can someone point me to files where it would be possible to exchange the storage used? Will open a PR :) | 06:01:30 |
hanno_jg | also, I feel like ditto is missed a bit by people as its not hosted on github π€ | 06:02:09 |
hanno_jg |
I see quite huge JS thread fps drops, when opening a chat / when sending/receiving a message. Is that something you guys already acknowledged?
| 06:08:27 |
TimeWalker | For rn-matrix stuff, probably Annie E. can give the best information to this | 11:09:01 |
TimeWalker | Never heard of mmkv, that seems like a pretty cool thing! Is it actually a drop-in replacement for async storage? | 11:10:40 |
hanno_jg | i guess there is a ditto developer chat? maybe these types of messages are better put there | 11:11:12 |
TimeWalker | I think that's the only Ditto chat for now π | 11:11:25 |
hanno_jg | yeah, its just a different storage library, but implemented in C++ so its blazing fast | 11:11:28 |
hanno_jg | * yeah, its just a different storage library, but implemented in C++ so its blazing fast | 11:11:52 |
TimeWalker | Neat! I'm keeping this in mind for my personal stuff, haha. Depends if Annie finds it useful too | 11:11:55 |
TimeWalker | Also do you mean the huge fps drops on Ditto Chat? I have noticed that and have tried to mitigate this with optimizing the redraws which unfortunately always regrabbed the information and dropped the performance a lot before. Should be merged in the latest master if you only tried the release version for now | 11:12:25 |
TimeWalker | * Also do you mean the huge fps drops on Ditto Chat? I have noticed that and have tried to mitigate this with optimizing the redraws which unfortunately always regrabbed the information and dropped the performance a lot. Should be merged in the latest master if you only tried the release version for now | 11:12:29 |
TimeWalker | * Also do you mean the huge fps drops on Ditto Chat? I have noticed that and have tried to mitigate this with optimizing the redraws which unfortunately always regrabbed the information and dropped the performance a lot before. Should be merged in the latest master if you only tried the release version for now | 11:12:44 |
hanno_jg | yes, I tried the latest master version. Currently I am "rebuilding" somewhat the matrix core, as the ditto matrix core is not written in TS. And we need TS. I will have a look where bottlenecks/issues come from and will write them here once I found them. Best would be if the ditto matrix core would be (even more) documented + written in TS | 11:14:12 |
hanno_jg | (so we can all use the same impl :)) | 11:14:30 |
hanno_jg |
regrabbed the information
| 11:14:49 |
hanno_jg | what do you mean by that? What happens exactly | 11:14:56 |
hanno_jg | (the core implementation I am building also uses mmkv, maybe that gives some more performance) | 11:16:37 |
TimeWalker | Hmm, it has been a while since I looked into it. Maybe it's something fully different than the issue you mentioned since when it was redrawing it tried to re-request messages and images via rn-matrix core again. | 11:16:44 |
TimeWalker | I've been starting to use Typescript at work personally and I agree, Typescript is π. I totally wouldn't mind TS typings for the project | 11:17:28 |
TimeWalker | * I've been starting to use Typescript at work personally and I agree, Typescript is π. I totally wouldn't mind TS typings for the project | 11:17:48 |
hanno_jg | okay, I've just stopped writing an own typescript implementation.
Now i write types for @rn-matrix/core
In the long-run we should type the whole core codebase (AirBnb says that 60% of their bugs were prevent through the introduction of proper typing/TS usage) | 13:17:51 |
hanno_jg | What is the newest version of @rn-matrix/core ?
0.0.33 or 0.1.0-alpha.1 ? | 13:31:49 |
hanno_jg | got it | 13:41:45 |
hanno_jg | am i seeing it correctly that you try to remove the rxjs stuff and exchange it against hooks? | 13:46:05 |
Annie E. | Oh wow I missed a bit! Yeah letβs move to a developer chat :) all exciting stuff!! | 15:01:05 |
| David Mason joined the room. | 19:23:02 |
16 Apr 2021 |
| David Mason changed their profile picture. | 14:41:56 |