!lbPXqyjXDnvnfogGYA:matrix.org

Fedora Devel

883 Members
Fedora developers channel |​ end users: please ask for help in #fedora |​ Infra status http:/​/​status.​fedoraproject.​org/​ |​ s390x now in primary koji for rawhide30 Servers

Load older messages


SenderMessageTime
24 Jan 2022
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
Could you please sponsor me as well? My first package for inclusion to Fedora is here: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2022991
Have you fixed all issues with your SPEC?
16:48:54
@xvitaly:fedora.imxvitaly Oleg Girko: 1. Missing %changelog. -> no go. 16:49:38
@steved:libera.chatsteved joined the room.16:49:57
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
Oleg Girko: 1. Missing %changelog. -> no go.
I explained that it's not missing.
16:50:00
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
I explained that it's not missing.
I opened your SPEC https://obs.infoserver.lv/package/view_file/i2p/i2pd/i2pd.spec?expand=1 and it is missing.
16:50:20
@xvitaly:fedora.imxvitalyIf you don't want to follow Fedora guidelines, we can't sponsor you.16:51:26
@AdaLovelace:libera.chatAdaLovelace joined the room.16:51:26
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
I opened your SPEC https://obs.infoserver.lv/package/view_file/i2p/i2pd/i2pd.spec?expand=1 and it is missing.
Because it's just a part of spec file. There is another part with changelog. Once I commit changes to Fedors repo, the spec file will contain both parts.
16:51:34
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
Because it's just a part of spec file. There is another part with changelog. Once I commit changes to Fedors repo, the spec file will contain both parts.
Spec URL: must be fully qualified and self-contained.
16:52:14
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
If you don't want to follow Fedora guidelines, we can't sponsor you.
Are there any guidelines that prohibit from showing these two parts separately in a web interface?
16:52:17
@xvitaly:fedora.imxvitaly And Spec URL: must be in text/plain format. No web interfaces are allowed. 16:52:48
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
And Spec URL: must be in text/plain format. No web interfaces are allowed.
Do you want me to just put this full spec file (that is more difficult to read than what I'm providing now) somewhere else on web?
16:54:22
@xvitaly:fedora.imxvitaly %{__mv} <- please don't use private macroses in your SPEC. 16:54:35
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
Do you want me to just put this full spec file (that is more difficult to read than what I'm providing now) somewhere else on web?
Yes. fedora-review tool requires text/plain SPECs and SRPM without redirects.
16:55:14
@xvitaly:fedora.imxvitaly

%{!?cmake_build:%define cmake_build %{make_build}}
%{!?cmake_install:%define cmake_install %{make_install}}

Remove these.

16:55:43
@Airwave:libera.chat@Airwave:libera.chat left the room.16:56:49
@xvitaly:fedora.imxvitaly
%pre
getent group i2pd >/dev/null || %{_sbindir}/groupadd -r i2pd
getent passwd i2pd >/dev/null || \
  %{_sbindir}/useradd -r -g i2pd -s %{_sbindir}/nologin \
                      -d %{_sharedstatedir}/i2pd -c 'I2P Service' i2pd

You should use modern method of creating users: https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/

16:57:42
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im

%{!?cmake_build:%define cmake_build %{make_build}}
%{!?cmake_install:%define cmake_install %{make_install}}

Remove these.

No. There is no guideline prohibiting compatibility with other distributions.
16:58:54
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
No. There is no guideline prohibiting compatibility with other distributions.
Fedora packages don't care about the other distributions (except RHEL).
16:59:35
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
%pre
getent group i2pd >/dev/null || %{_sbindir}/groupadd -r i2pd
getent passwd i2pd >/dev/null || \
  %{_sbindir}/useradd -r -g i2pd -s %{_sbindir}/nologin \
                      -d %{_sharedstatedir}/i2pd -c 'I2P Service' i2pd

You should use modern method of creating users: https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/

Again, I'd prefer to keep this legacy method for now, because the same spec file is used to build packages for CentOS 7.
16:59:44
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
Fedora packages don't care about the other distributions (except RHEL).
And this is excaty for RHEL/CentOS 7.
17:00:17
@zbyszek:libera.chat@zbyszek:libera.chat left the room.17:00:58
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
Again, I'd prefer to keep this legacy method for now, because the same spec file is used to build packages for CentOS 7.
You must follow Fedora guidelines for all your Fedora packages.
17:01:02
@xvitaly:fedora.imxvitalyYou can add use epel7 branch with legacy behavior.17:01:22
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
You must follow Fedora guidelines for all your Fedora packages.
Please show me a guideline that prohibit this legacy method.
17:01:43
@xvitaly:fedora.imxvitaly
In reply to @ol:infoserver.lv
Please show me a guideline that prohibit this legacy method.
https://docs.fedoraproject.org/en-US/packaging-guidelines/UsersAndGroups/
17:02:03
@jvanek:libera.chat@jvanek:libera.chat left the room.17:02:12
@sgallagh:fedora.imStephen Gallagher changed their display name from Stephen Gallagher to sgallagh.17:03:08
@sgallagh:fedora.imStephen Gallagher changed their display name from sgallagh to Stephen Gallagher.17:04:09
@ol:infoserver.lvOleg Girko
In reply to @xvitaly:fedora.im
You can add use epel7 branch with legacy behavior.
I build packages for Fedora and CentOS from the same source already. I build packages in my own OBS, install them from there, test them. If I include a package in Fedora, this is not just one-time effort. This is a long-term commitment to support this package. As I already support i2pd package using my own infrastructure, I don't want to duplicate my efforts and support different branches for Fedora and CentOS to build different packages in my own infrastructure and in Fedora infrastructure. This will lead to more manual labour, loss of synchronisation between packages, and I'll keep missing updates for Fedora as a result.
17:14:31

There are no newer messages yet.


Back to Room List