| 20 Mar 2023 |
 lecris | Oh wait, it worked without it...?
https://copr.fedorainfracloud.org/coprs/lecris/spglib/build/5686143/ | 18:39:17 |
 xvitaly | In reply to @lecris:matrix.org
Is that not picked up by %pyproject_buildrequires even if it worked? https://github.com/spglib/spglib/blob/develop/pyproject.toml#L14-L16 | 18:39:30 |
| lecris | Error there is about missing pytest which I guess it is because of -w not working with -x | 18:39:57 |
| lecris | For now I'm trying to submit bohdi build:
- I don't find
python-scikit-build-core for rawhide. No need to worry about that?
- I can't link to bugzilla 2179414 about the new package. Can do that manually?
- Taskotron checks?
| 18:45:34 |
| xvitaly | In reply to @lecris:matrix.org
For now I'm trying to submit bohdi build:
- I don't find
python-scikit-build-core for rawhide. No need to worry about that?
- I can't link to bugzilla 2179414 about the new package. Can do that manually?
- Taskotron checks?
Rawhide build will be pushed automatically. You need to create a new update only for branched Fedora releases.
You can link review ticket only manually. Just enter its number and add it. | 18:49:08 |
| lecris | Ok, all up https://bodhi.fedoraproject.org/updates/FEDORA-2023-85fb81543e. No need to worry about Taskotron for now? | 18:51:39 |
| xvitaly | In reply to @lecris:matrix.org
Ok, all up https://bodhi.fedoraproject.org/updates/FEDORA-2023-85fb81543e. No need to worry about Taskotron for now? Taskotron can be enabled to run additional tests. Your package has no such tests, so only a few standard packaging tests will be executed. | 18:53:46 |
| lecris | In reply to @xvitaly:fedora.im
Not implemented yet. Any issue link to subscribe for this? | 19:01:05 |
| lecris | I guess I should add a .rpmlint to hide these issues?
python3-scikit-build-core.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/scikit_build_core/setuptools/__init__.py /usr/lib/python3.11/site-packages/scikit_build_core/_compat/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/model/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/resources/find_python/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/settings/__init__.py
| 19:07:01 |
| lecris | * I guess I should add a .rpmlint to hide these issues?
python3-scikit-build-core.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/scikit_build_core/setuptools/__init__.py /usr/lib/python3.11/site-packages/scikit_build_core/_compat/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/model/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/resources/find_python/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/settings/__init__.py
Not sure about this one though:
python-scikit-build-core.src: W: strange-permission python-scikit-build-core.spec 600
My git looks normal on my side
| 19:08:33 |
| lecris | * I guess I should add a .rpmlint to hide these issues?
python3-scikit-build-core.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/scikit_build_core/setuptools/__init__.py /usr/lib/python3.11/site-packages/scikit_build_core/_compat/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/model/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/resources/find_python/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/settings/__init__.py
Not sure about this one though:
python-scikit-build-core.src: W: strange-permission python-scikit-build-core.spec 600
My git looks normal on my side (644)
| 19:08:45 |
| lecris | Hmm this one did not run any tests | 19:13:12 |
| lecris | * Hmm this build did not run any tests. Although the rawhide did | 19:13:35 |
|  blinxen left the room. | 19:14:46 |
| xvitaly | In reply to @lecris:matrix.org
Any issue link to subscribe for this? You should ask in the ML. | 19:15:13 |
| blinxen joined the room. | 19:15:21 |
| xvitaly | In reply to @lecris:matrix.org
I guess I should add a .rpmlint to hide these issues?
python3-scikit-build-core.noarch: W: files-duplicate /usr/lib/python3.11/site-packages/scikit_build_core/setuptools/__init__.py /usr/lib/python3.11/site-packages/scikit_build_core/_compat/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/file_api/model/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/resources/find_python/__init__.py:/usr/lib/python3.11/site-packages/scikit_build_core/settings/__init__.py
Not sure about this one though:
python-scikit-build-core.src: W: strange-permission python-scikit-build-core.spec 600
My git looks normal on my side (644)
W: files-duplicate can be silenced, but W: strange-permission is looks like a bug in Koji or SRPM generator. It should be reported. | 19:16:40 |
| xvitaly | In reply to @lecris:matrix.org
Hmm this build did not run any tests. Although the rawhide did It will, but only after the update is pushed to testing. | 19:21:00 |
| lecris | Is it possible to run rpmlint automatically or copr? | 19:26:06 |
 Lalufu | there's a setting for that, yes | 19:27:01 |
| xvitaly | In reply to @lecris:matrix.org
Is it possible to run rpmlint automatically or copr? Taskotron will run it as a part of standard test suite. | 19:28:11 |
| lecris | But how about copr? | 19:28:41 |
| xvitaly | In reply to @lecris:matrix.org
But how about copr? Only for fedora-review COPR targets, I guess. | 19:38:06 |
| lecris | Any tips on how to delete files after %pyproject_install or %pyproject_save_files? I get some rpmlint errors:
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so.2.1.0
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc.1 ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so.2
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc.2 ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so
And more importantly:
spglib-python3-spglib.x86_64: E: explicit-lib-dependency spglib
| 19:43:17 |
| lecris | Oh, also realized that the name is ... | 19:43:51 |
| xvitaly | In reply to @lecris:matrix.org
Any tips on how to delete files after %pyproject_install or %pyproject_save_files? I get some rpmlint errors:
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so.2.1.0
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc.1 ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so.2
spglib-python3-spglib.x86_64: W: dangling-relative-symlink /usr/lib/.build-id/2b/6724081588a53775e80d4339a4f09b0407d0dc.2 ../../../../usr/lib64/python3.11/site-packages/spglib/libsymspg.so
And more importantly:
spglib-python3-spglib.x86_64: E: explicit-lib-dependency spglib
E: explicit-lib-dependency spglib is okay for Python packages. rpmbuild can automatically extract dependencies from binaries, but can't do the same from scripts. | 19:46:34 |
| xvitaly | W: dangling-relative-symlink belongs to -debuginfo subpackages. | 19:47:11 |
| lecris | Those are different because in the cmake build, I build the spglib library twice. Once with cmake and once with pip install .. I then %exclude the latter ones so only the system is picked up | 19:48:32 |
| lecris | Ideally though, I should delete them before %files so I don't have to make a special exception. | 19:49:41 |
| lecris | Also, where can I read about rpmlintrc? | 19:51:34 |
