8 Feb 2023 |
@fundar:matrix.org | I don't think the "PR draft/undraft signals the authors intent" holds up in reality. PR authors are free to do whatever they want and they don't conform to what github tells them. | 13:55:43 |
@fundar:matrix.org | I guess I should've used that as my sales pitch yesterday, but whatever. | 13:56:02 |
clason | nah, I it wasn't closed; I think numToStr deleted their fork while spring-cleaning, not realizing that this would nuke open PRs | 13:59:02 |
clason | (I have done the same) | 13:59:09 |
clason | * nah, it wasn't closed; I think numToStr deleted their fork while spring-cleaning, not realizing that this would nuke open PRs | 14:00:38 |
clason | and no amount of github tomfoolery will help against lack of response on our side, sadly | 14:01:15 |
clason | that's what we have padawans for | 14:01:37 |
@mfussenegger:matrix.org | It also looks like there was no other activity on the PR after the last comment? | 14:02:06 |
zeertzjq | It can be reopened | 14:02:33 |
clason | not (easily) if the fork is gone | 14:02:49 |
zeertzjq | But cannot be changed anymore after reopening | 14:02:50 |
clason | right | 14:02:57 |
zeertzjq | So it's possible to reopen it and merge it as-is | 14:04:23 |
clason | that is true | 14:04:37 |
clason | (which isn't really on the table, though) | 14:04:47 |
@fundar:matrix.org | In reply to @clason:matrix.org nah, it wasn't closed; I think numToStr deleted their fork while spring-cleaning, not realizing that this would nuke open PRs Hmm, maybe I interpreted it wrongly. | 14:13:26 |
@fundar:matrix.org | My bad. | 14:13:29 |
@fundar:matrix.org | In reply to @clason:matrix.org and no amount of github tomfoolery will help against lack of response on our side, sadly Hmm, maybe it's a bad bandaid, yeah | 14:13:48 |
clason | no worries, it's good to think about these things | 14:21:48 |
3N4N | In reply to @fundar:matrix.org 3N4N: great job on the nvim-qt PR. Thanks. I was tinkering with two other inconsequential things, which I was waiting to get Justin's feedback on, but he seems to be MIA (he is well, I hope?). I'll ping you on github in case you want to take a look. | 14:25:34 |
clason | he goes awol frequently | 14:25:59 |
clason | nothing unusual; he'll be back | 14:26:08 |
clason | but we never know when that'll be, so don't let yourself be blocked unnecessarily | 14:28:39 |
clason | PSA: I'm going to try upgrading the room version here, see if that fixes things on mobile | 15:53:27 |
clason | 5 | 15:53:42 |
clason | 4 | 15:53:49 |
clason | 3 | 15:53:54 |
clason | 2 | 15:53:59 |
clason | 1 | 15:54:04 |
| clasonchanged room power levels. | 15:54:25 |