| 10 Apr 2024 |
 sevenrats | anybody know what to make of this?
| 16:55:14 |
| sevenrats | 
Download image.png | 16:55:18 |
| sevenrats | this is media-kit failing on macos | 16:55:26 |
| sevenrats | i dont know anything about ld on mac | 16:55:39 |
|  iparks99 changed their display name from overflow3308 to iparks99. | 18:46:07 |
 EUPHIE IS SOOOO CUUUUUUUTE | Is it missing libmpv binaries? | 19:38:23 |
| EUPHIE IS SOOOO CUUUUUUUTE | If so there are prebuilt binaries that can be downloaded on Github | 19:38:38 |
| sevenrats | i found a fix. something something use master. | 19:51:28 |
| 11 Apr 2024 |
|  @blizzow:matrix.org left the room. | 18:25:25 |
| 12 Apr 2024 |
|  Jeff (Bot) banned  @orieprtwth:matrix.org (Nuked). | 03:39:38 |
 -x | any way to reset the filter in experimental view? the tag is gone and it isn't shown in list. No way to get rid of it. I see no storage with remote debugger to clear it. | 03:49:25 |
| -x | diff --git a/src/apps/experimental/components/library/filter/FiltersGenres.tsx b/src/apps/experimental/components/library/filter/FiltersGenres.tsx
index c0ffee123..c0ffee987 100644
--- a/src/apps/experimental/components/library/filter/FiltersGenres.tsx
+++ b/src/apps/experimental/components/library/filter/FiltersGenres.tsx
@@ -21,9 +21,13 @@ const FiltersGenres: FC<FiltersGenresProps> = ({
const value = event.target.value;
const existingGenres = libraryViewSettings?.Filters?.Genres ?? [];
- const updatedGenres = existingGenres.includes(value) ?
- existingGenres.filter((filter) => filter !== value) :
- [...existingGenres, value];
+ const filteredExistingGenres = existingGenres.filter(function(item) {
+ return genresOptions.includes(item);
+ });
+
+ const updatedGenres = filteredExistingGenres.includes(value) ?
+ filteredExistingGenres.filter((filter) => filter !== value) :
+ [...filteredExistingGenres, value];
setLibraryViewSettings((prevState) => ({
...prevState,
fixed the issue (change filters the stored against current available genre list) for me, but properly added on a central place for tags and everything else | 05:16:38 |
| -x | * diff --git a/src/apps/experimental/components/library/filter/FiltersGenres.tsx b/src/apps/experimental/components/library/filter/FiltersGenres.tsx
index c0ffee123..c0ffee987 100644
--- a/src/apps/experimental/components/library/filter/FiltersGenres.tsx
+++ b/src/apps/experimental/components/library/filter/FiltersGenres.tsx
@@ -21,9 +21,13 @@ const FiltersGenres: FC<FiltersGenresProps> = ({
const value = event.target.value;
const existingGenres = libraryViewSettings?.Filters?.Genres ?? [];
- const updatedGenres = existingGenres.includes(value) ?
- existingGenres.filter((filter) => filter !== value) :
- [...existingGenres, value];
+ const filteredExistingGenres = existingGenres.filter(function(item) {
+ return genresOptions.includes(item);
+ });
+
+ const updatedGenres = filteredExistingGenres.includes(value) ?
+ filteredExistingGenres.filter((filter) => filter !== value) :
+ [...filteredExistingGenres, value];
setLibraryViewSettings((prevState) => ({
...prevState,
fixed the issue (change filters the stored against current available genre list) for me, but properly added on a central place for tags and everything else. And maybe a better variable name | 05:17:06 |
 thornbill | Nice! Do you plan to open a pull request? | 05:44:09 |
| sevenrats | In reply to @thornbill:matrix.org
Nice! Do you plan to open a pull request? im getting the vibe that he just gave it to us. | 05:53:33 |
| sevenrats | im seeing so much more patch talk these days. I wonder if its me or the world. | 05:53:57 |
| -x | Just take it. Like i wrote, there are more cases like genres, tags, years... e.g. Filter for a strange year and you fix misidentified entity. Maybe a reset option would be nice. There are a lot of tags and scrolling and finding one active is hell. (Maybe i build a filter input, because there are so many tags) | 07:50:21 |
| -x | I have some pacthes. HTML Lazy loading, Trickplay with chapter markers and and chapter name in window, a lot of UI/CSS changes and i rebase on the main branch. I also plan to switch to CSS grid because the behavior is awesome. But the next Patch will be stuff in edit images and amount on mobile. 6 per page with scrolling and paging is pain. With loading lazy it is fine on a single page (also increased the modal/dialog size and preview on desktop). | 07:56:10 |
| thornbill | patches submitted via element are going to get lost in the shuffle and submitting as patches in general makes more work for our already very limited number of maintainers in web 😕 | 08:03:09 |
| -x | Yeah, i tried repo once. Only posted it because i fixed it afterwards. Also tried vue thing (performance nightmare), so i patched most stuff for myself, because a lot of thigns would never make it into main repo | 08:12:17 |
|  @angeloflove:matrix.org joined the room. | 16:58:45 |
| @angeloflove:matrix.org left the room. | 16:59:06 |
 grhallenbeck | Even if it's not a complete pull request that's actually ready to go, submitting as a pull request is still better because it's findable. Makes it easy for someone else to pick it up later and flesh out those support and edge cases. | 19:05:52 |
|  Dyo ⚡️ left the room. | 20:23:23 |
| Jeff (Bot) banned  @aghaaa007:matrix.org (Nuked). | 21:11:20 |
|  zibbp joined the room. | 21:53:16 |
|  ryanh2o3 joined the room. | 23:35:29 |
| 13 Apr 2024 |
|  Simon joined the room. | 16:41:59 |
| Jeff (Bot) banned  @blueflashh:matrix.org (Nuked). | 18:30:15 |
| Jeff (Bot) banned  @sweetalisa:matrix.org (Nuked). | 21:12:48 |
