Sender | Message | Time |
---|---|---|
3 Oct 2024 | ||
jimb | Something that's an S or M with high impact could probably be justified. | 16:34:40 |
7 Oct 2024 | ||
schell | I just ran into this problem https://github.com/gfx-rs/wgpu/issues/4551 | 19:34:12 |
schell | Does the suggested fix still make sense? I'm wondering that, if it does, would we need to do a similar operation to the atomic type upgrade? Or is this actually easier than that? | 19:36:49 |
schell | * Does the suggested fix still make sense? I'm wondering that, if it does, would we need to do a similar operation as the atomic type upgrade? Or is this actually easier than that? | 20:12:12 |
schell | I think it would be easier than that, actually | 20:12:31 |
schell | Oof, I don't know. Any time we have to "change the type" of something in the spv frontend I fear it requires a type upgrade. | 20:52:37 |
8 Oct 2024 | ||
schell | I've got a condidate PR for the issue above^ | 20:02:01 |
schell | But the resulting module fails to validate with "Inappropriate sample or level-of-detail index for texel access" | 20:02:23 |
schell | I'm not sure if it's that I've inserted the expressions incorrectly or if my shader is just wrong. Is it possible to textureLoad on a depth texture? | 20:03:14 |
schell | Here's the resulting WGSL (if I don't validate):
| 20:03:44 |
schell | Seems like it doesn't like vec2<u32>(_e5.x, _e5.y) ? | 20:04:47 |
schell | * I've got a candidate PR for the issue above^ | 20:05:02 |
schell | This is transpiled from a
| 20:06:39 |
schell | Though, applying the same strategy to image sampling (as opposed to image load) works just fine. | 20:20:09 |
schell | Ok, looks like that problem was on my side, I needed to specify the level of detail | 23:10:19 |
schell | Anyway https://github.com/gfx-rs/wgpu/pull/6384 is ready to go :) | 23:10:43 |
9 Oct 2024 | ||
chyyran | naga is choking on WGSL also produced by naga... am I being stupid here
🤔 only thing I could think of is i'm using trunk naga to generate wgsl, did the syntax change since wgpu 22? | 03:07:30 |
chyyran | * naga is choking on WGSL also produced by naga... am I being stupid here Shader 'fragment' parsing error: expected assignment or increment/decrement, found '_e795' ┌─ wgsl:2070:11 │ 2070 │ const _e795: vec2 = vec2(2f); │ ^^^^^ expected assignment or increment/decrement 🤔 only thing I could think of is i'm using trunk naga to generate the input wgsl, did the syntax change since wgpu 22? | 03:07:49 |
chyyran | * naga is choking on WGSL also produced by naga... am I being stupid here | 03:08:15 |
chyyran | * naga is choking on WGSL also produced by naga... am I being stupid here
🤔 only thing I could think of is i'm using trunk naga to generate the input wgsl, did the syntax change since wgpu 22? | 03:08:46 |
chyyran | switched everything to trunk wgpu and it works so I'm assuming it's a syntax update 🙃 | 03:32:40 |
cwfitzgerald | In reply to @chyyran:matrix.orgIf this is inside of a function, we only have recently supported const declarations Within functions | 04:15:14 |
chyyran | that would make a lot of sense | 04:21:16 |
chyyran | I was just testing to make sure my inverse polyfill pr wasn’t breaking anything | 04:23:16 |
10 Oct 2024 | ||
schell | teoxoy: https://github.com/gfx-rs/wgpu/pull/6384#issuecomment-2404464744 is ready to go :) | 21:51:51 |
chyyran | Download image.png | 22:30:16 |
chyyran | jimb: regarding https://github.com/gfx-rs/wgpu/pull/6385#pullrequestreview-2361520591 is it valid to emit a function with a reserved prefix? I checked with shader playground before and got this error when feeding something to wgsl-in with a __ prefix | 22:30:19 |
chyyran | * jimb: regarding https://github.com/gfx-rs/wgpu/pull/6385#pullrequestreview-2361520591 is it valid to emit a function with a reserved prefix? I checked with shader playground before and got this error when feeding something to wgsl-in with a __ prefix | 22:30:30 |
chyyran | Unless it's fine to add an exception for it in wgsl-in | 22:42:07 |
jimb | No, you're right, that's a good point. I'll reply in the issue | 23:07:43 |