!ePwsQChmTyRFwMijYe:matrix.org

groupincome

56 Members
www.groupincome.org24 Servers

Load older messages


SenderMessageTime
26 Apr 2021
@_slack_okturtles_U014E8SJQNT:matrix.orgcatarina_chavinha That sounds great! I found a couple of interesting profiles on LinkedIn, I can message them this week to see if they’d be interested 16:03:27
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01DQ4JGH9A might not catch your update until tomorrow, heading off to sleep soon (jet lag) 16:35:37
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm 02KCCG4S please update my current copy of the TODO list appropriately:
Add more Cypress tests for payments (ex: invalidating a payment) + Txn minimization

https://github.com/okTurtles/group-income-simple/pull/1056#discussion_r603473612

Fix removal of PAYMENT_COMPLETE guard WRT distributionEvents.

Fix distributionEvents[0] fiasco.

Change compareMonthstamps/compareISOTimestamps to be A-B.

Github comments.
17:09:24
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm I have been progressing slowly because all these tasks collectively imply many paradigm-shifting code changes, while I am trying to make minimal code changes at the same time. This part requires thinking (NOT software development). It is in my best interest to make sure all these tasks are complete before mid-July. 17:30:59
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm As far as "paradigm-shifting" goes: it's actually nothing too major (for instance SBP is still feasible), but there are some ambiguities in the communication between distribution and UI code. Careful consideration is required to correct this. 17:45:40
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm The silver lining of a completed prototype is clearly visible from my distribution code's perspective. I just need to do a few basic things to correct the UI code's communication with it. (Totally betting that the completed application's PR will come from 01PM8F8BSL's E2E-correcting code.) 17:57:23
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm Again: July is my target. 17:58:00
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm I should mention: we should definitely accept my PR before I start to introduce txn-minimization code to it. 18:02:19
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm Cherish my many months of software R&D appropriately, please; pragmatically incorporating "1 feature at a time" (with regards to the distribution algorithm) optimizes our team's chances of influencing its early development, and ultimate fairness value. 18:08:19
27 Apr 2021
@_slack_okturtles_U02KCD23D:matrix.organdrea So it's all in one place, here's what we're all working on this week (to the best of my understanding): - Greg: On vacation - Leihla: Review and help organize Github issues (in light of what's planned for the prototype) - Ian: Add more Cypress tests + Fix distributionEvents in PR - Pierre: Continuing work on the homepage - Catarina: Message professional fundraisers + Work on blog & GI shorts for "Addressing Sybil Attacks Through Dunbar's Number" - Andrea: Funding wiki + Filings page + Finances page - Snowteamer: XSS issue - Sven: On vacation till ~May 3rd let me know if anything should be changed 03:54:53
@_slack_okturtles_U02KCCG4S:matrix.orggreg 02KCD23D looks great to me! Thanks for getting on that! 06:25:51
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01DQ4JGH9A > 02KCCG4S please update my current copy of the TODO list appropriately: > Add more Cypress tests for payments (ex: invalidating a payment) + Txn β€’ Cypress tests: yes, but leave those for after you've finished with the higher priority items 06:26:51
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01DQ4JGH9A > 02KCCG4S please update my current copy of the TODO list appropriately: > Add more Cypress tests for payments (ex: invalidating a payment) + Txn minimization β€’ Cypress tests: yes, but leave those for after you've finished with the higher priority items β€’ Txn minimization - no, since we're leaving that until after this PR is merged, right?
https://github.com/okTurtles/group-income-simple/pull/1056#discussion_r603473612
Oh I don't remember what we decided to do with that. We had a call about that right? Didn't we talk about that and decide that maybe, if we want to at some point in time in the future to enable pro-rating, need to not do that? I.e. even the "unadjusted distribution" needs to be somewhat adjusted for pro-rating? So I think you can maybe skip this for now. Unless you've thought about it more and have decided that there is in fact a way to separate it out into unadjustedDistribution and adjustedDistribution, while still supporting the possibility for pro-rating via proRated: true somehow.
Fix removal of PAYMENT_COMPLETE guard WRT distributionEvents.
Can you expand on this? I don't remember what this refers to.
Fix distributionEvents[0] fiasco.
Yes, I would make this your #1 priority as the next thing you commit.
Change compareMonthstamps/compareISOTimestamps to be A-B.
Yes, I'd make this #2 priority, but in addition to that I would also do the thing that we talked about with regard to not doing this: if (Math.floor(lastEvent.data.cycle) !== Math.floor(cycleAtDate(new Date(), firstEvent.data.when))) Instead, compare the meta.createdDate etc. using the new compareISOTimestampAsMonth function that we talked about on the call that needs to be implemented. I might've even DM'd you some code for that. This should be #2 priority along with the above.
06:33:16
@_slack_okturtles_U01FNNKFJBH:matrix.orgpdatasystems In the chat component (namely in updateTextArea() in`SendArea.vue` ), the text is updated by setting the innerHTML property, so this text should obvioulsy be santized. However, does this mean that the user is supposed to be able to enter some simplified HTML in the chat? If so, which subset? Or do we only allow plain text for now, to keep it simple? 16:57:28
@_slack_okturtles_U01FNNKFJBH:matrix.orgpdatasystems It's important to know so that a correct dompurify configuration can be used. 17:00:35
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01FNNKFJBH great question! We're probably going to allow markdown only in the chat. Does that help guide you? 17:02:15
@_slack_okturtles_U01FNNKFJBH:matrix.orgpdatasystems Yes, so no HTML in the chat since markdown is plain text 17:02:49
@_slack_okturtles_U02KCCG4S:matrix.orggreg yep! 17:02:54
@_slack_okturtles_U01FNNKFJBH:matrix.orgpdatasystems thank you for the quick answer 17:03:14
@_slack_okturtles_U02KCCG4S:matrix.orggreg np 17:03:23
28 Apr 2021
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01DQ4JGH9A replying to some of your other comments now that my brain is less jet-lagged > I should mention: we should definitely accept my PR before I start to introduce txn-minimization code to it. Yep, that's the plan! πŸ‘ > Cherish my many months of software R&D appropriately, please; pragmatically incorporating "1 feature at a time" (with regards to the distribution algorithm) optimizes our team's chances of influencing its early development, and ultimate fairness value. Of course. We definitely cherish and appreciate all the incredible work you've been doing Ian. πŸ™‚ That simulator was a brilliant idea. πŸ˜„ πŸ‘ 05:22:57
1 May 2021
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01FNNKFJBH just saw your recent PR for closing #975, thanks for sending that in! https://github.com/okTurtles/group-income-simple/pull/1064 Is it ready to be reviewed? If so, I think I have some time later today to have a look 07:05:58
@_slack_okturtles_U02KCCG4S:matrix.orggreg Brilliant idea to implement disallow-vhtml-directive btw! 07:06:23
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm 02KCCG4S 'bout to push some of the requested changes. Running into an error where grunt test fails, but grunt dev+npm run cy:open succeeds: 12:58:19
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm This is the first of the cascading-errors in the cypress tests: 12:59:35
@_slack_okturtles_U02KCCG4S:matrix.orggreg 01DQ4JGH9A Your grunt test was previously passing, was it not? If so, I recommend doing a git diff between your current commit and the previously passing one 13:40:04
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm Sure thing. I think I might have garbled cypress itself somehow. I might try incrementally re-adding my changes to the latest commit until it breaks. 13:41:15
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm Fixed, 02KCCG4S. It appears I somehow modified my local node_modules folder and a fresh git clone/npm i/ adding changes /grunt test fixed it. Just pushed the changes. 14:40:22
2 May 2021
@_slack_okturtles_U02KCCG4S:matrix.orggreg Hey folks, I'm unable to attend this Monday's meeting, so if it's alright with y'all I'd like to reschedule it for Tuesday at 8am Pacific. If you're unable to attend it's OK, in which case please share your previous week's progress and what you're working on this week in the channel (either on Monday or on Tuesday, as you have time). Otherwise I'll see you on Whereby Tuesday at 8am Pacific! /cc 01D9TLS46B FKBGLWCV 01DQ4JGH9A 014E8SJQNT 02KCD23D 01PM8F8BSL (Sven, welcome back btw! Hope your vacation was great!) 10:24:41
@_slack_okturtles_U01DQ4JGH9A:matrix.orggeometricalgorithm I'll attend. 10:25:34

Show newer messages


Back to Room List