have getdata block invs return something (notfound or reject) on error. Silently dropping a reply makes clients time out and assume that the node is dead or slow

The Product Hunt badge links to the Nexa full Node Product Hunt page

Adding a Product Hunt badge helps increase the awareness of the Nexa full node.

-Include in relevant files

Overall in the wost case it can take 9 seconds (but typically just 6 seconds) to create a 100MB block template whereas with these improvements it only takes 4 seconds.

• only run TestBlockValidity() in DEBUG...we only need to check when we commit the block to the blockchain. This save about 2 seconds of time when creating a 100MB block
• prevent us from going through the addPackageTxes() loop more than we need to. Generally 1 iteration is all we need unless there are actual dirty chains present which is very rare. This saves about 3 seconds of template creation for a 100MB block.
• remove the repeated calls to GetBoolArg() for print priority and replace with a global

• We no longer need to take the cs_main lock along with cs_wallet. This cs_main lock was a left over which never got removed.

• this has remained here unused for many years and have since used a different way of prioritizing transactions and blocks. It seems time to remove this and save the few bytes and cpu cycles.

• We already have a read lock on the mempool further upstream so just use that one.

• For very large blocks this prevents us from having to pause tx admission longer than necessary.

• This is no longer any merkle branch to set and not for a long time however we still unnecessarily parse through the block index for every transaction we add to the wallet.