| 26 Jul 2019 |
 andrewsh | * Erik, richvdh: I haven’t looked at the issue itself, is the fix portable to the 0.99.something we have in stable? | 13:16:04 |
 Willem | Most rooms I'm in are still v1 | 13:16:03 |
| andrewsh | oh, good to know | 13:16:20 |
| andrewsh | * Erik, richvdh: I haven’t looked at the issue itself, is the fix portable to the 0.99.2 we have in stable? | 13:16:41 |
 Erik | In reply to @andrewsh:matrix.org
Erik, richvdh: I haven’t looked at the issue itself, is the fix portable to the 0.99.2 we have in stable? errr, some of the patches might be, we haven't really had a chance to look at it | 13:26:51 |
 richvdh | in principle I think they would be, but also it would be a bunch of work | 14:04:47 |
| richvdh | there's been quite a bit of churn in the codebase since 0.99.2 | 14:05:05 |
| andrewsh | how high is the risk? | 15:00:58 |
| richvdh | well, https://github.com/matrix-org/synapse/releases/tag/v1.2.1 describes the issues | 15:06:36 |
| richvdh | they aren't at "remote code exe" or "pwn a room" level, but they are definitely at "make a big nuisance of yourself" level | 15:07:36 |
| richvdh | especially the DoS | 15:07:44 |
 Linda | In reply to @tfheen:err.no
shipping broken software in stable is bad. it's not broken, it federates with versions in stable as intended. it's stable.
I agree with keeping it.
| 15:22:59 |
| Linda | backports is for shinies | 15:23:03 |
| Linda | Anyway, that version is what it is in stable because of buster freeze period landing on the same time as Synapse 0.99.x releases | 15:24:09 |
| Linda | * Anyway, that version is what it is in stable because of buster freeze period landing on the same time as Synapse 0.99.x and 1.0 releases | 15:24:27 |
 tfheen | Linda: I did not claim it was broken; andrewsh said it was unusable (due to only supporting v1 rooms) | 15:51:26 |
| andrewsh | well, v-1 rooms :) | 15:51:47 |
| andrewsh | I think the current version is not 2 🙂 | 15:52:03 |
| andrewsh | * well, v-1 rooms 🙂 | 15:52:14 |
| andrewsh | but I may be wrong | 15:58:03 |
| richvdh | you are right: https://github.com/matrix-org/synapse/blob/master/synapse/config/server.py#L39 | 16:00:58 |
| richvdh | but so are they there are plenty of v1 rooms still, and 0.99.2 will work fine in them | 16:01:36 |
| richvdh | and it will federate fine with other 0.99.2 servers | 16:01:55 |
| andrewsh | in other news, I have just uploaded 1.2.1 | 16:05:45 |
| richvdh | \o/ | 16:06:31 |
|  Gillian changed their display name from Gil Of The Wired to [@P6]LainChan. | 17:59:46 |
| andrewsh | richvdh: I just checked the patches, they don’t seem to be very difficult to port, but my knowledge of the codebase is not sufficient | 18:21:18 |
| andrewsh | richvdh: could please someone have a look? | 18:22:40 |
| richvdh | I'm afraid it's not something we're going to be able to make time for; we were always very clear that we would not provide backports to pre-1.0 synapse. | 21:35:00 |
| 27 Jul 2019 |
| Linda | In reply to @grin:grin.hu
I'd say it's not on topic here either.... I wrote since I wanted to suggest to package the new version and not to hint anything else or blame anyone. this was miscommunicated | 00:04:23 |
