| 15 Feb 2019 |
 Maximus | uhoreg: i'll move it | 23:31:20 |
| Maximus | https://github.com/matrix-org/synapse/issues/4656 | 23:34:05 |
 Linda | $ grep -ir "report_stats" debian/
debian/matrix-synapse-py3.postinst:CONFIGFILE_REPORTSTATS="/etc/matrix-synapse/conf.d/report_stats.yaml"
debian/matrix-synapse-py3.postinst: echo "report_stats: $RET" > $CONFIGFILE_REPORTSTATS
debian/build_virtualenv:# remove the report_stats setting, which is set in a separate file
debian/build_virtualenv:/^# report_stats:/ and $_ = "";
This is not how to configure that stuff... | 23:42:44 |
| Linda | Oh, sorry | 23:43:10 |
| Linda | $ grep -ir "report-stats" debian/
debian/matrix-synapse-py3.postinst: db_get matrix-synapse/report-stats
debian/config:db_input high matrix-synapse/report-stats || true
debian/templates:Template: matrix-synapse/report-stats
Template: matrix-synapse/report-stats
Type: boolean
Default: false
| 23:43:35 |
| Linda | Maximus: Looks like you answered "true" in fact, at least according to this +sid1 version. | 23:45:22 |
| Linda | But debian/config isn't configured to check the value from a previous configuration, so it can default to "false" even if it was previously true if debconf(1) cache has been purged. | 23:46:28 |
| Linda | Fucking Matrix.org packages, smh. | 23:46:33 |
| Maximus | Linda: back in 2018 I already opened an issue about this, because this is a system I never replied yes | 23:50:26 |
| Maximus | I always replied no | 23:50:42 |
| Linda | Maximus: Which distribution version? | 23:51:19 |
| Maximus | maybe the dpkg-reconfigure config is wrong, but that's not my problem as the package user. I never replied yes, and I don't expect the value to change if the file already exists, or to ever default to true whatever the situation is | 23:51:27 |
| Maximus | debian stable | 23:51:36 |
| Maximus | this is a known issue to the synapse's devs | 23:51:54 |
| Maximus | this never happened with the previous debian packages per example, even after updating | 23:52:27 |
| Linda | Right, I see the issue | 23:53:31 |
| Linda | db_get matrix-synapse/report-stats
if [ "$RET" ]; then
echo "report_stats: $RET" > $CONFIGFILE_REPORTSTATS
fi
I think that's meant to check if $RET is "true", not every time the input is checked. | 23:54:07 |
| Maximus | meanwhile, do you know a way for me to fix the template of dpkg? | 23:54:37 |
| Linda | db_get matrix-synapse/report-stats
if [ "$RET" = "true" ]; then
echo "report_stats: $RET" > $CONFIGFILE_REPORTSTATS
fi
sudo dpkg-reconfigure matrix-synapse-py3.
| 23:55:16 |
| Maximus | just dpkg-reconfigure matrix-synapse-py3 ? | 23:55:43 |
| Linda | I can explain the issue in detail, too | 23:55:39 |
| Maximus | or rather, how can I just totally delete those template files? not sure where they are stored | 23:56:38 |
| Linda |
- If there is no answer to the question, it asks. You choose no.
- The answer is "false" this time.
report_stats is not enabled, debconf(1) remembers this question in its cache.
- Next time you upgrade or reconfigure
matrix-synapse-py3, debconf(1) checks its cache for answer. If it is there, $RET will exit with a status code 10 or higher. Or effectively "true".
You can see where this goes. | 23:57:40 |
| 16 Feb 2019 |
| Linda | Maximus: Btw, the file is /etc/matrix-synapse/conf.d/report_stats.yaml. | 00:03:36 |
| Maximus | Did I report it wrong in the issue? it looks right to me | 00:04:23 |
| Maximus | Linda: thank you for finding out why this goes back to true | 00:05:06 |
| Maximus | and this will trigger GDPR issues again.... :/ now I need to re-check all my servers | 00:05:41 |
| Linda | It's kind of correct. It just doesn't consider caches, and seems to always ask that question again if the debconf cache is missing (even if you had it configured already). | 00:06:21 |
| Maximus | and go report for the breach to the officier | 00:06:19 |
| Linda | which is nonsense | 00:06:32 |
