23 Apr 2021 |
Calvin Xiao | I think I've finished my syscalls analysis for puma, time to read all the codes and understand how puma works in details. | 15:38:30 |
Calvin Xiao | In the mean time, I am looking at some issues to see what I can do. | 15:53:23 |
msp-greg | nateberkopec: I added 'Performance' to https://github.com/MSP-Greg/issue-pr-link. Since it's Puma specific, the change is to one's credential file. See the change to info.sample, the 'labels' line, which maps PR labels to History.md categories... | 16:03:44 |
24 Apr 2021 |
nateberkopec | OK folks, I'm thinking next release will be 5.3.0, roughly targeting Monday, May 3. If there's something you want in that release, get movin'! I've marked PRs with a 5.3.0 milestone that I think are realistic goals to get reviewed and merged by that time but of course other PRs can be merged too. | 13:44:23 |
nateberkopec | If you would like to help prepare 5.3.0: | 13:44:41 |
nateberkopec |
- Please review open PRs, particularly ones I've marked 5.3.0.
| 13:44:52 |
nateberkopec |
- Get anything you want in 5.3.0 opened ASAP so we have time to review it and merge.
| 13:45:18 |
nateberkopec | msp-greg: you've been crushing it lately and haven't named a release in a while... do you want to codename 5.3? | 13:45:54 |
msp-greg | I'd be honored. Keeping with the previous theme, 'Sweetnighter'. It's an old Weather Report album, people unfamiliar with it can probably find all or part of it on the internet.
That, and some of the math classes I had account for my brain being wired somewhat differently than most. Not good or bad, just different... | 14:34:25 |
dentarg | TIL https://github.blog/changelog/2021-04-22-github-actions-maintainers-must-approve-first-time-contributer-workflow-runs | 15:11:33 |
Calvin Xiao | People use GHA to do coin mining.🤐 | 15:21:31 |
dentarg | Yeah I just read https://github.blog/2021-04-22-github-actions-update-helping-maintainers-combat-bad-actors/ | 15:21:51 |
nateberkopec | msp-greg: lovely, make the PR with the change whenever you're ready | 23:22:09 |
25 Apr 2021 |
| Todd Lynam joined the room. | 03:32:48 |
Y | Download image.png | 10:08:24 |
Y | My workflows are stucked while trying to run github actions manually forked from puma repository. Is it normal? Does it need someone to manually approve from original repo?
| 10:08:26 |
26 Apr 2021 |
msp-greg | Y: Sorry, a little late. I see you've got Actions running in your fork and passing. I'll have a look at the code tomorrow, I'm -0500 | 02:34:08 |
| nateberkopecchanged room power levels. | 14:29:12 |
| nateberkopecchanged room power levels. | 14:29:37 |
| nateberkopecchanged room power levels. | 14:29:46 |
| nateberkopecchanged room power levels. | 14:29:57 |
| nateberkopecchanged room power levels. | 14:30:03 |
msp-greg | JFYI, GitHub Actions Windows Rubies 2.2 thru 2.4 are broken right now. I'm fixing 2.4 soon, 2.2 & 2.3 may take longer, as I can't do the commits for those. Nothing to do with Puma. | 14:55:45 |
27 Apr 2021 |
nateberkopec | Just wanted to give a little 👏 and recognition to Calvin Xiao for contributing at a very high level so soon after getting started with working on Puma. It's really impressive! | 16:36:09 |
Calvin Xiao | Cheers! | 16:44:24 |
Calvin Xiao | I found a way to repro this issue https://github.com/puma/puma/issues/2552 | 16:44:48 |
Calvin Xiao |
- run bundle exec bin/puma -w 24 -t 1:1 -C test/config/app.rb --fork-worker
- close the terminal (WSL2)
| 16:45:08 |
Calvin Xiao | forked workers became zombies. | 16:45:32 |
Calvin Xiao | Probably the main process is being kill by os. | 16:45:51 |
28 Apr 2021 |
| Dino joined the room. | 15:19:51 |