!aVApiNMtnstWbwDcVU:matrix.org

pulp-dev

79 Members
Complete the Pulp Community Survey: https://forms.gle/yiExzmD1dbDBjNEZ86 Servers

Load older messages


SenderMessageTime
30 Jul 2021
@lubosmj:matrix.orglmjachky
  • this one https://github.com/pulp/pulpcore/commit/07340fd04047141f30c216517778010193a0e555 😶
18:00:54
@goosemania:matrix.orggoosemaniaah it was backported18:01:20
@lubosmj:matrix.orglmjachkyso, the timeline is as follows: 1. a year ago, we were moving files within settings.MEDIA_ROOT (/var/lib/pulp/), 2. then we changed settings.MEDIA_ROOT to /var/lib/pulp/media/ and introduced settings.DEPLOY_ROOT (/var/lib/pulp/), 3. then someone realized that temporary files within the pulp's working directory are not being removed, 4. I updated the old brian's code by replacing settings.MEDIA_ROOT (/var/lib/pulp/media) with settings.DEPLOY_ROOT (/var/lib/pulp), 5. now we are here again in the same state as we were a year ago18:04:31
@lubosmj:matrix.orglmjachky * so, the timeline is as follows: 1. a year ago, we were moving files within settings.MEDIA_ROOT (/var/lib/pulp/), 2. then we changed settings.MEDIA_ROOT to /var/lib/pulp/media/ and introduced settings.DEPLOY_ROOT (/var/lib/pulp/), 3. then someone realized that temporary files within the pulp's working directory are not being removed, 4. I updated the old brian's code by replacing settings.MEDIA_ROOT (/var/lib/pulp/media) with settings.DEPLOY_ROOT (/var/lib/pulp), 5. now we are here again in the same state as we were a year ago18:05:39
@goosemania:matrix.orggoosemania dalley: I think I won't rewrite the issue, since katello is not affected by the migration issue, I'll open a new one, but I'll try to reproduce it first 18:06:47
@mikedep333:matrix.orgMichael DePaulo bmbouter, fao89: Please confirm before I release 3.7.7: https://github.com/pulp/pulp_installer/pull/708#issuecomment-890084603 18:46:09
@goosemania:matrix.orggoosemania lmjachky, bmbouter , dralley , I have good news, things are not as bad as the comment looks :) At least I can't reproduce a problem with uploading from /var/lib/pulp/* or with a migration. I think the key is that we check for the temporary_file_path on line 65 https://github.com/pulp/pulpcore/commit/fbe2d7f9c85008e8223fec8fcfdb87e665e06881 and it seems to belong only to a specific django object https://docs.djangoproject.com/en/3.2/ref/files/uploads/#django.core.files.uploadedfile.TemporaryUploadedFile.temporary_file_path, and our upload is smart enough not to remove the original file regardless of the location. That's my explanation, and I'm glad I proved myself wrong :) 18:56:53
@goosemania:matrix.orggoosemania maybe the comment to the _save method can be updated, it looks scary 18:57:18
@goosemania:matrix.orggoosemania * maybe the comment to the _save method can be updated, it looks scary 18:57:52
@lubosmj:matrix.orglmjachkyall models which contain ArtifactFileField are affected by my change19:02:27
@lubosmj:matrix.orglmjachkyhttps://github.com/pulp/pulpcore/blob/354383883032277e7a1f7dc7ddf2dc0a5bc40fad/pulpcore/app/models/fields.py#L64-L6519:02:30
@lubosmj:matrix.orglmjachkyclass TemporaryDownloadedFile(TemporaryUploadedFile)19:02:47
@lubosmj:matrix.orglmjachkysince you cannot reproduce any bad behaviour, it is good anyway19:03:30
@goosemania:matrix.orggoosemania not any, just the 2 I came up with, there is still at least an issue dralley pointed to, https://pulp.plan.io/issues/9146 19:07:55
@lubosmj:matrix.orglmjachky * all models which contain ArtifactFileField are affected by my change19:14:26
@mikedep333:matrix.orgMichael DePaulo fao89: The galaxy import failed for a weird reason: https://galaxy.ansible.com/my-imports/4091?type=collection 19:32:17
@fao89:matrix.orgfao89not weird19:46:38
@fao89:matrix.orgfao89you need requires_ansible now19:46:51
@fao89:matrix.orgfao89https://github.com/pulp/pulp_installer/commit/8393f887490d8f32bf68a68ac6edebaf8db4622119:47:36
@mikedep333:matrix.orgMichael DePauloSigh, I guess I'll do a 3.7.7-1 release?19:49:23
@mikedep333:matrix.orgMichael DePauloI'll start on it now.20:01:17
@gerrod:matrix.orggerrodwhat do i give to pjournal to be able to scroll through the past logs?20:10:24
@gerrod:matrix.orggerrod bmbouter: I got the tests to work for the rbac content guard thanks to ina. If you want to have a look at it before you leave https://github.com/pulp/pulpcore/pull/1518/commits/904d8e65b6758b9041c4f164574b654bf6ffe6f1 20:21:21
@fao89:matrix.orgfao89
In reply to @gerrod:matrix.org
what do i give to pjournal to be able to scroll through the past logs?
I believe something like this --since "2020-07-10 15:10:00" --until "2020-07-12"
20:22:19
@mikedep333:matrix.orgMichael DePaulo fao89: https://github.com/pulp/pulp_installer/pull/713 20:24:14
@ace:kittenface.studioAnanace 21:50:45
@mikedep333:matrix.orgMichael DePaulo bmbouter, fao89: The pulp_installer release 3.7.7-1 is finally available. 22:01:38
1 Aug 2021
@swadeley:libera.chat@swadeley:libera.chat left the room.08:27:10
@jjeffers:libera.chatjjeffers left the room.11:40:51
@jjeffers:libera.chatjjeffers joined the room.11:47:03

There are no newer messages yet.


Back to Room List