!XfqLiaavxVgyMSiRwK:matrix.org

Ruma

270 Members
A set of Rust library crates for working with the Matrix protocol. https://www.ruma.io/ | https://github.com/ruma/ | https://liberapay.com/ruma/105 Servers

Load older messages


Timestamp Message
6 Jun 2020
19:52:53@jplatte:matrix.orgjplatteI wonder how many (de)serializers ruma will consist of in the end 😅
19:53:23@jplatte:matrix.orgjplatteConsidering ruma-serde already contains a serde_urlencoded fork bc. of the spec's unusual format for multi-value query parameters
19:53:48@jplatte:matrix.orgjplatte
In reply to @stoically:matrix.org
i never looked at their code yet, so i have no idea how much work that'd be, or what serde_json actually does
Well, you don't even need to understand most of it. You just have to delete lots of code ^^
19:54:19@stoically:matrix.orgstoic:D
19:54:23@stoically:matrix.orgstoicdeleting code sounds fun
20:02:17@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-events] DevinR528 synchronize pull request #111: Remove raw mod and TryFromRaw/FromRaw, add Deserialize to derive for event content [open] - https://github.com/ruma/ruma-events/pull/111
20:14:03@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-events] jplatte closed pull request #111: Remove raw mod and TryFromRaw/FromRaw, add Deserialize to derive for event content [closed] - https://github.com/ruma/ruma-events/pull/111
20:31:45@timo:koesters.xyzTimohttps://github.com/ruma/ruma/pull/24
20:31:20@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma] timokoesters opened pull request #24: Optimize /sync response [open] - https://github.com/ruma/ruma/pull/24
20:50:16@timo:koesters.xyzTimoShould be ready for review now
20:48:20@stoically:matrix.orgstoic

there's the host_dep feature in nightly cargo:

Prevents features enabled on build dependencies or proc-macros from being enabled for normal dependencies.

20:50:32@timo:koesters.xyzTimo * Should be ready for review
20:49:16@stoically:matrix.orgstoicthat helps at least as workaround with the sqlx-macros crate
20:50:35@timo:koesters.xyzTimo * Should be ready for review now
20:49:30@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma] timokoesters synchronize pull request #24: Optimize /sync response [open] - https://github.com/ruma/ruma/pull/24
21:53:56@jplatte:matrix.orgjplatte Ah okay, so the feature is only activated by a build dep. Yeah, then that helps 🙂
21:53:57@jplatte:matrix.orgjplatte
In reply to @stoically:matrix.org

there's the host_dep feature in nightly cargo:

Prevents features enabled on build dependencies or proc-macros from being enabled for normal dependencies.

* Ah okay, so the feature is only activated by a build dep. Yeah, then that helps 🙂
21:54:26@jplatte:matrix.orgjplatteAre you working on a serde_json fork now? Otherwise I might start that tomorrow.
21:54:55@jplatte:matrix.orgjplatte
In reply to @timo:koesters.xyz
Should be ready for review now
Left one small nit, otherwise looks very good (see review); thanks a lot!
23:56:30@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-events] DevinR528 opened pull request #112: Remove src/from_raw.rs and ruma-events-macro/src/from_raw.rs [open] - https://github.com/ruma/ruma-events/pull/112
7 Jun 2020
01:04:38@iinuwa:matrix.orgiinuwa

Hmm. Can someone tell me what I'm doing wrong here? The compiler is saying that Deserialize and Serialize are not found in this scope.

#[cfg(feature = "serde")]
use serde::{Deserialize, Serialize};
// ...
#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, AsRefStr, Display, EnumString)]
#[cfg_attr(feature = "serde", derive(Deserialize, Serialize))]
pub enum KeyAlgorithm {
// ...
}
01:18:12@devinr528:matrix.orgdevinr528Does it matter that one is cfg the other is cfg_attr?
01:20:00@iinuwa:matrix.orgiinuwa I don't think so... I think that #[cfg_attr] was for conditionally adding attributes and #[cfg] is for conditionally adding a code element.
01:24:40@iinuwa:matrix.orgiinuwacould be wrong though
01:24:42@iinuwa:matrix.orgiinuwa * could be wrong though
01:24:56@devinr528:matrix.orgdevinr528That makes sense I'd agree
05:26:08@stoically:matrix.orgstoic
In reply to @jplatte:matrix.org
Are you working on a serde_json fork now? Otherwise I might start that tomorrow.
looked briefly into it (and started deleting a few things), but if you want to give it a shot, that'd be great
05:55:40@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-federation-api] stoically opened pull request #9: Add query server key endpoints [open] - https://github.com/ruma/ruma-federation-api/pull/9
05:58:05@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-federation-api] stoically edited pull request #9: Add query server key endpoints [open] - https://github.com/ruma/ruma-federation-api/pull/9
06:04:48@_neb_github_=40jplatte=3amatrix.org:matrix.orgGithub [@jplatte:matrix.org] [ruma/ruma-federation-api] stoically synchronize pull request #9: Add query server key endpoints [open] - https://github.com/ruma/ruma-federation-api/pull/9

There are no newer messages yet.


Back to Room List