done

Does anyone have any thoughts on rho-lang ? 😁

@danielconstantin Not much, except it was very hard to get into the syntax haha. Promised myself I’d spend a day on it someday, that day hasn’t occurred yet ;).

@sohkai @bingen we really need to get Actor merged tomorrow

https://twitter.com/mhswende/status/1093995835518537728

Fun stuff

@channel @aragon/os@4.1.0-rc.1 has been released with an SafeERC20 implementation

@all @aragon/os@4.1.0-rc.1 has been released with an SafeERC20 implementation

Updated ERC1271 support in the Agent app: https://github.com/aragon/aragon-apps/pull/580/commits/fe86092ed206453f66337082874ebb46fe33fb28

Also added my comments in the EIP to what I think the final standard should be, although I am comfortable to push it out in the current state, specially since we can upgrade later: https://github.com/ethereum/EIPs/issues/1271#issuecomment-462719728

@sohkai changed the signature modes a little bit (removed Trezor’s old special case and added and invalid signature type) and refactored the tests (parametrized them to test different signature types)

i think you should merge https://github.com/aragon/aragon-apps/pull/625 into https://github.com/aragon/aragon-apps/pull/651 and let’s get those tests in

with this, i think we are ready for merging and releasing

I saw this other sig validator contract, and i am refactoring ours again :D

https://github.com/horizon-games/multi-token-standard/blob/0c917a439d91af7f480cd5822352a85341dab967/contracts/utils/SignatureValidator.sol#L120

I saw this other sig validator contract that I really liked, and i am refactoring ours again :D

Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/2467b4dafdffae176c43239c68685e7aa7eecec2

now handling ERC1271 validation in the library as well

Refactor ready @sohkai: https://github.com/aragon/aragon-apps/pull/580/commits/345a9d8aa4f411df6d2b5044a801b2cb7d9ca6ee

@jorge was running the agent coverage tests locally and for some reason the signature tests seemed to not work

@jorge about this:
https://github.com/aragon/aragon-apps/pull/657#discussion_r255435114
Tests are not passing now. Do you want me to raise it to 6.4e6, which would be closer to 80% of current limit, or to lower down the number of max allowed tokens?