13 Feb 2019 |
bridge-bot | <sohkai> Might as well use 6.5e6 and give that a shot
| 17:12:57 |
bridge-bot | <bingen> ok, sounds good (I said 6.4 because it’s 80% of 8 and because it’s now using 6.37, but I’ll do 6.5)
| 18:23:44 |
14 Feb 2019 |
bridge-bot | <jorge>
for some reason the signature tests seemed to not work
| 07:48:56 |
bridge-bot | <jorge> hmm but the tests were passing?
| 07:49:03 |
25 Feb 2019 |
bridge-bot | <sohkai> @jorge Would be great if you could take a look at https://github.com/aragon/aragon-apps/pull/686
| 17:28:23 |
28 Feb 2019 |
bridge-bot | <sohkai> @all Does anyone using VSCode like to try out a security-oriented solidity extension? One of the AGP-18 security partners built https://github.com/tintinweb/vscode-solidity-auditor and it looks really, really helpful 🔥. Feel free to file issues on github!
Installation instructions: https://github.com/tintinweb/vscode-solidity-auditor#installation
| 11:51:23 |
19 Mar 2019 |
bridge-bot | <gabi> The next two lines give File import callback not supported when compiling using 0x dev-tools: https://github.com/aragon/aragonOS/blob/dev/contracts/lib/ens/ENS.sol#L4
https://github.com/aragon/aragonOS/blob/dev/contracts/lib/ens/PublicResolver.sol#L3
I fixed it using double quotes. Is this a bug?
| 02:39:37 |
bridge-bot | <sohkai> Good question; the docs officially only use double quotes, so we should use those instead
| 09:14:48 |
bridge-bot | <sohkai> Perhaps it was old syntax from earlier versions of Solidity that have since been removed, but the newer contracts in ENS are now using the double quotes too :shrug:
| 09:18:51 |
27 Mar 2019 |
bridge-bot | <sohkai> https://blog.ethereum.org/2019/03/26/solidity-optimizer-and-abiencoderv2-bug/
| 09:42:12 |
28 Mar 2019 |
bridge-bot | <jorge> https://medium.com/@mykelp/introducing-polaris-ced195dd798e
| 11:46:50 |
bridge-bot | <jorge> pretty interesting price feed for tokens that uses uniswap prices and prevents manipulation by not taking the current price but a median of checkpoints. we should check it out for payroll
| 11:48:54 |
bridge-bot | <jorge> cc @sohkai @facuspagnuolo @lkngtn @bingen
| 11:48:54 |
bridge-bot | <jorge> it is live actually: https://github.com/marbleprotocol/polaris
| 11:49:41 |
29 Mar 2019 |
bridge-bot | <sohkai> https://github.com/ethereum/EIPs/pull/1884
SLOAD might go from 200 to 800 gas (not ridiculous, but a 4x)
| 12:09:02 |
30 Apr 2019 |
bridge-bot | <bingen> Hey guys, I need some Solidity expertise advice. I want to avoid this if :
https://github.com/aragon/aragon-court/blob/getLastPresent/contracts/lib/HexSumTree.sol#L196
- because it makes the code more expensive (even if it’s just an if)
- because
past value never changes once the initial function is called, so it’s the same for every iteration of the loop and every recursion step
- because for the case
sortition (where I have the same problem) adding this param makes me hit the stack too deep error
- beacuse it makes the code uglier
First idea I had is to just copy the whole function changing only that line, but this sucks of course (too much repeated code)
As far as I know there’s nothing similar in solidity to passing functions as parameters or dependency injection or any other fancy technique.
I also thought of overloading the function get , but it comes from Checkpointing and there is no Library inheritance either.
Any ideas?
| 10:48:13 |
bridge-bot | <jorge> IMO it is okey as it is, definitely cleaner than copying the entire function as in _sortition and _sortitionLastPresent
| 11:23:19 |
bridge-bot | <jorge> if this ends up being limited to just the current term (as I think we should do), then we could remove the option of doing it in the past all together and just allow linear searches
| 11:24:33 |
bridge-bot | <bingen> yes, that _sortition duplication is temporary, it was a quik work around for stack too deep issue, and I was waiting as you said to see if we really need both options or stick to just one
| 12:32:32 |
bridge-bot | <bingen> yes, that _sortition duplication is temporary, it was a quick work around for stack too deep issue, and I was waiting as you said to see if we really need both options or stick to just one
| 13:20:21 |
23 May 2019 |
bridge-bot | <danielconstantin> Is truffle supposed to compile dependencies? If so, why? security? 😕
(trying to update truffle to v5 which uses solc-js v0.5 and the compilation fails)
| 10:40:20 |
bridge-bot | <sohkai> Moving to truffle@5 is going to be a longer process across the entire development pipeline
| 16:33:43 |
bridge-bot | <sohkai> @danielconstantin Moving to truffle@5 is going to be a longer process across the entire development pipeline
| 16:33:51 |
bridge-bot | <sohkai> I imagine we could start doing it for the boilerplates though
| 16:34:02 |
bridge-bot | <sohkai> You should also be able to specify the solc version (it will have to be 0.4.24 ) in the truffle config
| 16:34:25 |
16 Jul 2019 |
bridge-bot | <sohkai> This is super cool: https://github.com/cgewecke/eth-gas-reporter/blob/master/docs/codechecks.md
| 09:17:32 |
bridge-bot | <gabi> Thanks for sharing it
| 14:21:38 |
17 Jul 2019 |
bridge-bot | <sohkai> A nice solidity build tool from a Nest grantee, @mcormier: https://github.com/macor161/quantal/
| 16:01:16 |
bridge-bot | <mcormier> Hey thanks Brett! :)
| 16:12:28 |
bridge-bot | <mcormier> Still a few months to go before production-ready though
| 16:12:51 |