!WutQDrNlCwVCYNngoo:matrix.org

Dev EVM

8 Members
1 Servers

Load older messages


Timestamp Message
17 Dec 2018
22:00:37@g_:matrix.orggabi joined the room.
22:30:22@lightcoin:matrix.orglight joined the room.
18 Dec 2018
04:06:00@griffgreen:matrix.orggriffgreen joined the room.
12:21:51@brettsun:matrix.orgbrettsun joined the room.
12:58:38@Smokyish:matrix.orgTatu joined the room.
14:02:13@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> hey @jorge Staking is ready for you to re-review except for: https://github.com/aragon/staking/pull/1#discussion_r241538035 I don't think I fully get it. How would would that front-running attack work? If we use a none wouldn't we be relying on order too? And: https://github.com/aragon/staking/pull/1#discussion_r241534907 I'll try to think about how to improve it, but let's discuss it before making any change.
14:05:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> hey @jorge Staking is ready for you to re-review except for: https://github.com/aragon/staking/pull/1#discussion_r241538035 I don't think I fully get it. How would would that front-running attack work? If we use a nonce wouldn't we be relying on order too? And: https://github.com/aragon/staking/pull/1#discussion_r241534907 I'll try to think about how to improve it, but let's discuss it before making any change.
14:25:21@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> Great decision to open this channel 💪
14:45:07@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19 I'm using cli v5.2.1 and ganache-core v3.2.1 . Also I update to the new voting and token-manager beta.2 I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80 I updated to the new initalization constructor in this way: `tokenManager.initialize(token, true, 0)` But the VM still returned exception. I'm lost here, could be related to the MiniMe token? By the way, the voting app works perfect
14:47:05@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> I have a question myself, I'm testing Kit.sol from react-kit-boilerplate to fix this issue: https://github.com/aragon/aragon-react-kit-boilerplate/issues/19 I'm using cli v5.2.1 and ganache-core v2.3.2 . Also I update to the new voting and token-manager beta.2 I found the VM is having problems with the token-manager. In specific here: https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L80 I updated to the new initalization constructor in this way: `tokenManager.initialize(token, true, 0)` But the VM still returned exception. I'm lost here, could be related to the MiniMe token? By the way, the voting app works perfect
15:25:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> @gabi Hmm, weird, the only require should be that the token's controller is the token manager, but that's already done in https://github.com/aragon/aragon-react-kit-boilerplate/blob/master/contracts/Kit.sol#L77
15:26:11@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> It might be worth upgrading to the `2.0.0` version (non-beta) and see what happens, although the interfaces should be exactly the same
15:27:10@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> It works without the token manager being initialized?
15:29:30@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> Ok I'll check with 2.0.0
15:30:13@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> If I remove all thing related to token manager it works just fine
15:34:26@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> Really weird... I don't think there should be anything related to the version bump but I'm pretty sure the aragen snapshot is using `2.0.0`
15:39:33@bridge-bot:matrix.orgbridge-bot[rocketchat] <gabi> I'll review it again in case I'm missing something
16:19:07@g_:matrix.orggabi removed their profile picture.
16:19:34@g_:matrix.orggabi set a profile picture.
21:50:30@bridge-bot:matrix.orgbridge-bot[rocketchat] <sohkai> `truffle@5.0.0` finally released! https://github.com/trufflesuite/truffle/releases/tag/v5.0.0
19 Dec 2018
13:54:05@geleeroyale:matrix.orggeleeroyalechanged room power levels.
23 Dec 2018
16:57:10@bridge-bot:matrix.orgbridge-bot[rocketchat] <bgits> Moving the discussion from #general regarding EVMScriptRunner to this channel as it seems more relevant. Regarding @jvluso last comment, I see this function in Voting.sol: https://github.com/aragon/aragon-apps/blob/master/apps/voting/contracts/Voting.sol#L187 - What would be helpful is seeing a client side example of how the `_evmScript` param is generated. My guess is it would require a 1) contract ABI, 2) function name, 3) function parameters? Seeing an actual example would be helpful.
21:18:08@bridge-bot:matrix.orgbridge-bot[rocketchat] <jvluso> I'll be able to answer this better once I'm at my computer, but iirc it's 4 bytes of the number of commands (00000001) the target address, 4 bytes of the number of bytes of data, and then the data. The best way however would be to use the aragon wrapper in aragon.js similar to https://github.com/jvluso/eth-aragon-keyring
24 Dec 2018
14:03:03@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Hi, @bgits you can find a simple example here: https://github.com/aragon/aragon-apps/blob/master/apps/voting/test/voting.js#L168
14:04:31@bridge-bot:matrix.orgbridge-bot[rocketchat] <bingen> Another one here: https://github.com/aragon/dao-kits/blob/master/kits/democracy/test/democracy.js#L330
27 Dec 2018
14:20:24@bridge-bot:matrix.orgbridge-bot[rocketchat] <bgits> thanks
14:22:14@bridge-bot:matrix.orgbridge-bot[rocketchat] <bgits> @jvluso This looks great: https://twitter.com/izqui9/status/1076013068616908800 - is there a public repo for it?
28 Dec 2018
02:52:41@bridge-bot:matrix.orgbridge-bot[rocketchat] <jvluso> https://github.com/jvluso/frame/tree/keyring - it's still being worked on here
2 Jan 2019
10:22:01@bridge-bot:matrix.orgbridge-bot[rocketchat] <jorge> Pretty interesting hack https://etherscan.io/address/0x3e8b42754c8eafdc8e732f4346126e920ede8548#code
15:02:15@izqui:matrix.orgJorge Izquierdo joined the room.

Show newer messages


Back to Room List