| 24 Apr 2024 |
 Michael Catanzaro | I'll try to be ready in about 1 hr from now | 17:48:56 |
| Michael Catanzaro | Actually I see you requesting info in #gnome-hackers:gnome.org, let me check there...
| 17:50:38 |
| Michael Catanzaro | In reply to @mcatanzaro:gnome.org
Anyway, I'll see if I can get to the image unload bug today OK, so I went back to August 9 on the assumption that 2.42 was good, but the unload bug actually predates that | 19:15:22 |
| Michael Catanzaro | Which is strange, because I don't remember this happening before? | 19:15:38 |
| Michael Catanzaro | I guess I can try going back as far as 2.40, but I'm getting nervous now... | 19:16:14 |
| Michael Catanzaro | My 2.40 build doesn't render anything. I don't think this can be bisected, sorry :( | 19:33:07 |
| Michael Catanzaro | philn https://github.com/WebKit/WebKit/commit/ab193bff49cf4e6ef3ecf8bf4ff744f86f7a41f2 broke the build if ENABLE(WEB_CODECS) is turned off. Now to investigate why is that off for me when it should clearly be on by default....
| 19:59:57 |
 philn | the error being? | 20:00:53 |
| philn | WebCodecs is enabled by default | 20:02:40 |
| Michael Catanzaro | In reply to @pnormand:igalia.com
the error being? First error is:
/home/mcatanzaro/Projects/WebKit/Source/WebCore/platform/gstreamer/VideoEncoderPrivateGStreamer.h:54:60: error: no member named 'VideoEncoder' in namespace 'WebCore'; did you mean 'GstVideoEncoder'?
54 | static Ref<WebKitVideoEncoderBitRateAllocation> create(WebCore::VideoEncoder::ScalabilityMode scalabilityMode)
| ^~~~~~~~~~~~~~~~~~~~~
| GstVideoEncoder
/usr/include/gstreamer-1.0/gst/video/gstvideoencoder.h:126:33: note: 'GstVideoEncoder' declared here
126 | typedef struct _GstVideoEncoder GstVideoEncoder;
| ^
(sorry, should have included that)
| 20:04:23 |
| Michael Catanzaro | Needs more ENABLE(WEB_CODECS) guards
| 20:04:43 |
| Michael Catanzaro | (Why does that need to be a build flag anyway? Does it really require external deps? Should probably be a runtime flag instead?) | 20:05:06 |
| philn | it's the usual thing, when implementing a new spec we ifdef... | 20:05:55 |
| philn | VideoDecoder was un-ifdefed iirc, but VideoEncoder still is... maybe we should fix that | 20:07:06 |
| Michael Catanzaro | In reply to @pnormand:igalia.com
it's the usual thing, when implementing a new spec we ifdef... Don't do that please, only use ifdefs if you need to avoid some build dependency | 20:14:09 |
| Michael Catanzaro | We should use runtime settings instead! | 20:14:27 |
| philn | well that code will be needed for WebRTC too so... | 20:14:38 |
| philn | there is a WebCodecs runtime flag too afaik | 20:14:50 |
| Michael Catanzaro | In reply to @pnormand:igalia.com
there is a WebCodecs runtime flag too afaik Sounds like the build flag can be removed, then? That's probably easier than trying to keep it working? Fewer bug reports for you? ;) | 20:15:27 |
| philn | Youenn should approve that | 20:16:08 |
| Michael Catanzaro | It doesn't look like it increases GStreamer build requirements | 20:16:39 |
| philn | no | 20:17:04 |
| philn | In reply to @pnormand:igalia.com
there is a WebCodecs runtime flag too afaik no websetting though | 20:20:36 |
| Michael Catanzaro | It doesn't need an API setting; you can use the features API if you really want to toggle it for whatever reason | 20:21:14 |
| Michael Catanzaro | philn What about ENABLE_MEDIA_STREAM; that one doesn't seem to have extra dependencies required either, does it? And it's also a frequent source of build failures
| 20:32:57 |
| philn | i suppose it can also be removed | 20:34:28 |
| philn | ENABLE_WEB_RTC cannot though (gst-webrtc build dep) | 20:34:55 |
| philn | again should be approved by Youenn imho | 20:35:51 |
| philn | some Apple platforms might still need those ifdefs, idk | 20:36:37 |
| Michael Catanzaro | Maybe | 20:38:05 |
