| 31 Mar 2020 |
 tgr | that works from PHP too | 12:19:37 |
| tgr | handles tab navigation and whatnot | 12:19:47 |
 rheingoldriver | oh, framed:false | 12:19:55 |
| rheingoldriver | except | 12:20:05 |
| rheingoldriver | wait how is it blue | 12:20:11 |
| tgr | that's hardcoded | 12:22:55 |
| tgr | (different icon) | 12:23:06 |
| tgr | blue for primary action, red for irreversible actions, it can be set via flags | 12:23:54 |
| rheingoldriver | oh hmmm maybe that would work | 12:24:18 |
| rheingoldriver | 
Download image.png | 12:25:46 |
| rheingoldriver | ok i way pref this | 12:25:55 |
| rheingoldriver | ty | 12:26:05 |
 yaronk | Whoa, blue! | 12:28:31 |
| yaronk | I think "primary action" means there shouldn't be more than one blue icon/button per row. | 12:29:30 |
| yaronk | ...since they can't all be primary. | 12:29:48 |
| rheingoldriver | i could readd the borders then | 12:30:10 |
| rheingoldriver | but i think having a black icon is really unintuitive that you can click it | 12:30:28 |
| yaronk | I don't know... I see black clickable icons everywhere. | 12:31:01 |
| yaronk | Or at least dark gray ones. | 12:31:13 |
| yaronk | Although... having a background around the icon that darkens when you hover over the icon could be a nice touch. | 12:32:43 |
| yaronk | I don't know if that kind of thing happens anywhere in MediaWiki, but it shows up in other UIs, like browsers. | 12:33:13 |
| yaronk | Oh, VisualEditor does it too. | 12:34:24 |
| rheingoldriver | i think the context is different | 12:39:32 |
| rheingoldriver | the border gives these the needed context | 12:39:53 |
| rheingoldriver | that they are buttons | 12:39:56 |
| rheingoldriver | i just dont like the extra vspace that the borders take up, and imo blue == having borders and lack | 12:40:14 |
| rheingoldriver | * i just dont like the extra vspace that the borders take up, and imo blue == having borders and black | 12:40:19 |
| rheingoldriver | but youre right it misuses the semantic meaning of the style so | 12:40:27 |
| rheingoldriver | buttons are better probably | 12:40:31 |
| yaronk | Check out the VisualEditor toolbar: https://en.wikipedia.org/wiki/Example?veaction=edit | 12:40:53 |
