Sender | Message | Time |
---|---|---|
15 Sep 2023 | ||
13:37:09 | ||
18 Sep 2023 | ||
09:57:59 | ||
09:58:01 | ||
09:58:02 | ||
19 Sep 2023 | ||
13:34:58 | ||
HI, I am trying to make sence about the --disable-forced-server-mode configure flag, is it doing anythin aparm from forciong the license module to be loaded at lib/cfg.c at L157?I might be wrong on this but I could not see any other uses for the SYSLOG_NG_ENABLE_FORCED_SERVER_MODE, also it seems like that the MainLoop->options->server_mode or the main_loop_is_server_mode is never used in the code.Am i missing something or it is only forcing the license module to be leaded(probably for PE)? | 14:35:09 | |
the server_mode variable is used in an internal repository | 14:36:18 | |
* the server_mode variable is used in an internal repository (we discussed this privately so that we don't make too much noise about PE modules here) | 14:47:20 | |
FYI, even though i could not find a clear reference, but seems astyle option --max-instatement-indent is replaced by --max-continuation-indent both astyle -h and the documentation page (https://astyle.sourceforge.net/astyle.html) refers only to --max-continuation-indent shall I fix it in .astylerc ? | 17:06:44 | |
In the most recent version of astyle, they completely removed a few options and I was unable to reproduce the old behavior of it, which was essential for us. Maybe I overlooked something, but I'm afraid as astyle gets updated in distros, we will eventually reach a point where it just won't work properly anymore. | 17:09:08 | |
hm, if I change to --max-continuation-indent in the most recent version of astyle, it generates a big diff, but it only removes some double line feeds. maybe we can disable that too and the diff will be identical | 17:17:45 | |
* hm, if I change to --max-continuation-indent in the most recent version of astyle, it generates a big diff, but it only removes some double line feeds. maybe we can disable that too and the diff may be identical | 17:19:44 | |
just trying to figure out why my CI build style-check fails, and found meanwhile this option change, yeah, probably eliminating it is a better option | 17:19:47 | |
Download image.png | 17:21:14 | |
I think --max-continuation-indent is needed, I'm just trying to figure out how to disable this behavior: | 17:21:14 | |
20 Sep 2023 | ||
Removing double line breaks might not be that intrusive, we won't even see it in git blame, as there would be no line which referred to the commit. | 06:37:40 | |
I would prefer keeping them, they are there for logical separation of different different entities we didn't want to create a completely new file for | 06:41:54 | |
22 Sep 2023 | ||
18:07:24 | ||
24 Sep 2023 | ||
14:22:56 | ||
25 Sep 2023 | ||
mranno alltilla1337 : just a quick heads up: the latest syslog-ng git snapshot before 4.4 compiled fine on all my RPM platforms, with Loki and S3 where supported. | 12:06:52 | |
I still need to give FreeBSD a try, but grpc is not supported there (only clang works, and it needs gcc), and there were no other changes | 12:08:08 | |
OK. It compiles fine on FreeBSD as well, I just need to fix packaging due to S3 | 12:20:05 | |
27 Sep 2023 | ||
12:29:47 | ||
14:28:51 | ||
28 Sep 2023 | ||
czp I think opening an issue would be great either way. We can collect the problems and ideas there. | 06:52:22 | |
OK. I wrote about it a few weeks ago somewhere, but probably it's easier to write an issue from scratch than to find it 🙂 | 07:08:04 | |
11:36:42 | ||
13:55:39 | ||
13:58:59 | ||
29 Sep 2023 | ||
Wow, GCC now actually works on FreeBSD, but compiling with CLANG still fails: https://github.com/syslog-ng/syslog-ng/issues/4652 | 08:01:38 |