26 Mar 2020 |
Tjark | The proposal deadline is next Tuesday (31.03). Yes you should submit a PR (including your progress over the last weeks; for example the squared images for MAGIC) and a proposal before Tuesday. | 19:56:33 |
Tjark | CTA is already in place! For FACT and HESS we don't have access to data. | 19:59:08 |
Tjark | You need to implement a class similar to the DL1DataWriter class in writer.py. Instead of reading the data from a simtel file, you need to read the data from the root file. For MAGIC you only need to change the event source (from the default CTA to the MAGIC one), since a plugin is already available. | 20:07:31 |
Tjark | I think I'm not getting your question. What do you mean with multi telescopes? | 20:08:31 |
ayushvpaliwal | What mentioned in idea page was initially we will make it to enable data in ROOT format from specific IACT. And afterwords from given collection of IACTs | 20:12:00 |
Tjark | Okay, I see! MAGIC is a collection of two IACTs and VERITAS is a collection of four IACTs. However, the data structure is the same for the files of each IACT in their array (collection). Shouldn’t cause any troubles scaling up for „multi telescopes“. | 20:41:46 |
27 Mar 2020 |
shlydv | I read the Magic root file using uproot and used bilinear interpolation in the image_mapper. The output image doesn't seem right though | 12:48:37 |
shlydv | Download index1.png | 12:48:44 |
shlydv | But each event in 'Events.MCerPhotEvt.fPixels.fPhot' had a shape of (1183,1) while MagicCam images have a size of (1039,1), right? So I used the first 1039 pixel values for this image. | 12:51:05 |
Tjark | Awesome progress! Yes, that's was right. The pixel values for indices >1039 are not relevant. | 16:51:16 |
Tjark | One side note: The image look like the default oversampling and not bilinear interpolation. Are you sure you passing "mapping_method={'MAGICCam': 'bilinear_interpolation'}" in the ImageMapper? | 16:54:17 |
shlydv | Oh yes I forgot that. Does this work? | 17:09:00 |
shlydv | Download final.png | 17:09:08 |
Tjark | That looks good! | 17:11:47 |
28 Mar 2020 |
shlydv | For the MAGIC files, we have to change this part of the code to the ctapipe_io_magic's MAGICEventSource, right? And then use the hdf5 files in CTLearn using the dl1reader. | 11:54:51 |
shlydv | Download InkedScreenshot from 2020-03-28 17-19-40_LI.jpg | 11:55:51 |
Tjark | Yes, instead of using the EventSource from ctapipe, we should use the EventSource from ctapipe_io_magic, which were build following the convention and syntax from ctapipe. | 11:57:38 |
shlydv | Great! | 11:58:11 |
Tjark | Did you tried to pass in the eventsource class plus settings from ctapipe_io_magic into the event_source_class & event_source_settings from the DL1DataWriter? Then you should execute the if case in your image. | 12:02:13 |
Tjark | I don't know if it's working out of the box, because for the CTA data additional steps are required (e.g calibrating the data). These steps should be skipped, when working with MAGIC (calibrated) data. | 12:06:24 |
shlydv | Oh. I haven't tried that. Will get back to you if I do it. | 12:07:50 |
Tjark | Great! However, those further tasks are not expected for the proposal and the PR. | 12:25:49 |
shlydv | Yeah sure. I am working on the proposal and PR too. Thanks! | 12:29:33 |
Tjark | @all Make sure to upload your proposal draft at the official google summer of code dashboard (https://summerofcode.withgoogle.com/dashboard/) as soon as possible. You can mark the status as 'Draft shared' or 'Final'. Last minute/hours upload make it challenging for us to add any input and/or review! | 12:38:41 |
29 Mar 2020 |
shlydv | Hey Tjark! I have written most of the proposal but have some queries regarding the timeline. Should I share the draft on the organizations page? | 07:11:50 |
Tjark | Yes, that would be good! Thanks. | 17:41:23 |
30 Mar 2020 |
ayushvpaliwal | Tjark: would you please comment something on draft? | 13:47:11 |
Tjark | I'm on it! | 14:28:10 |
Tjark | I'm on it! | 14:29:13 |
shlydv | Hey Tjark did you see the proposal draft? | 18:07:23 |