!RCMLMgpukegBXzqmsq:matrix.org

Dev Frontend

8 Members
1 Servers

Load older messages


Timestamp Message
11 Jan 2019
16:37:32@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

I think we also have the right side button

16:37:41@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

But we could send different messages to do different things

16:38:44@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

(I think the right side button changes from a plain button with a label to an icon when the screen gets smaller)

14 Jan 2019
10:10:44@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

@bpierre

10:10:46@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

It’s probably because of an update on the lazy config, and should resolve itself after merging master into this PR, then using lazy from aragon/ui (instead of the local springs.js that won’t be needed anymore) 👌

10:11:19@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

I've already rebased to the latest master, does it mean I can start using spirngs from aragon-ui?

10:11:55@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

Yes 👌

10:12:17@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

springs.js was just to backport the new springs until aragon-ui gets released

10:12:26@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

Sweet

10:12:36@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

I'll update the PR

10:12:39@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

Cool

10:12:55@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

(I’m reviewing the sidepanel PR on aragon-ui)

10:31:19@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

@bpierre does this ring a bell?

10:32:52@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

yes

10:33:00@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

pheww

10:33:05@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

jaja

10:33:06@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

Now I need to remember what it was

10:33:07@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

haha

10:33:15@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

pheew

10:34:07@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

mmm is it npm i?

10:36:15@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

Yes, thank you @bpierre

10:36:26@bridge-bot:matrix.orgbridge-bot [rocketchat] <aquigorka>

I need to remember to npm i after I rebase

10:36:38@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

Yeah, I always forget too :o

15:59:26@bridge-bot:matrix.orgbridge-bot [rocketchat] <sohkai>

Haha oh boy that error scared me

16:00:14@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

hehe

16:00:22@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

it’s the innerRef => ref change

16:00:40@bridge-bot:matrix.orgbridge-bot [rocketchat] <sohkai>

@bpierre created https://github.com/aragon/aragon-ui/issues/281 for the breakpoint discussion, although I think I must’ve missed some part of it (please edit it!)… is there a way to detect when the children don’t need to be rerendered to skip it?

16:02:11@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

Yes totally, the problem at the moment is not that we rerender, but that we unmount / mount, due to the way react-media API’s work: https://github.com/ReactTraining/react-media#basic-usage

16:02:30@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

It only supports one query, and it renders or not its children based on it

16:02:47@bridge-bot:matrix.orgbridge-bot [rocketchat] <bpierre>

While we would like instead to get a breakpointName value


Show newer messages


Back to Room List