18 Feb 2024 |
BassBot | [jaywink/socialhome] jaywink
merged
merge request !608: Bump Docker images to Python 3.10 | 14:00:15 |
BassBot | [jaywink/socialhome] jaywink
pushed
2 commits
to
master:
-
5f508c93
Switch from `django-debug-toolbar-user-switcher` to `django-debug-toolba…
-
03db352a
Merge branch 'jaywink/debug-toolbar-user-panel' into 'master' […]
| 14:00:28 |
BassBot | [jaywink/socialhome] jaywink
merged
merge request !609: Switch from `django-debug-toolbar-user-switcher` to `django-debug-toolbar-user-panel` | 14:00:28 |
BassBot | [jaywink/socialhome] jaywink
pushed
2 commits
to
master:
| 14:06:45 |
BassBot | [jaywink/socialhome] jaywink
created tag
v0.19.0 | 14:06:45 |
jaywink | oh Alain do you have that script to build both image variants to commit? I just built an amd64 image now | 14:32:02 |
Alain | The script is in my head. 🙂 I created a multiarch_release.sh script. I'm testing it right now. I'll push it as soon as I'm happy with it. It may mean the v0.19.0 image you already pushed will be replaced with this manifest. There are a few prerequisites that I'll document in the script. | 19:29:32 |
19 Feb 2024 |
BassBot | [jaywink/socialhome] alainstd
pushed
1 commit
to
master:
-
07d821e3
Add a build script for multi-architecture container images
| 13:25:59 |
Alain | I tested the script on a test build and it works. jaywink: do you want to try replacing v0.19.0 with it? | 13:30:47 |
jaywink | cool thanks! I'll give it a go tomorrow, not at own laptop today | 17:11:36 |
20 Feb 2024 |
BassBot | [jaywink/federation] alainstd
opened
merge request !183: Fixes addressing various manually tracked content issues.
Over time I spotted a few rendering issues, mainly concerning mention and tag linkification, and kept them in a list. With this merge request, my list is almost empty, for now...
Issues resolved:
-
Note._find_and_mark_mentions: When an AP Mention object href can't be found in the rendered content,
try the name property.
-
Ignore media objects that don't define a media type.
-
Prevent rendered content image duplication when an image is both in the AP payload rendered content
and defined as an attachment that doesn't set the inlineImage property.
-
Accept the application/ld+json type for webfinger AP links.
-
Mark an AP mention only if profile.finger is defined.
-
Handle escape sequences for inbound markdown mentions.
-
Extend the Unicode character range allowed in markdown mentions.
-
Discard illegal characters from tag text. Previously, this was done only on tag links.
TODOS implemented:
-
This is actually both a change and a fix. AP Image objects do not define properties matching the
HTML img tag alt and title properties. Image.name is used to render both alt and title, which IMHO is
wrong. With this change, markdown images defining the title property will be recognized instead of
being thrown away (the fix) and the title property, if defined, will have precedence over the
alt property as the Image.name value (the change). Before this change, the client app would properly
render the img tag from the markdown source (with distinct alt and title properties), but the Image
object would not federate and hence not be displayed on other platforms (namely Mastodon).
-
Instead of discarding the whole AP payload out when encountering an undefined or unlisted nested AP object,
log a warning and keep going. Ensure None is returned when a nested field only contains an undefined
object.
| 15:40:50 |
Alain | I promised I would do smaller PRs. Well, here's a somewhat large PR with a bunch of small commits. 🙂 Let's merge it before it gets too large. | 15:44:20 |
Alain | Looking at my instance log running on the branch above, I have a sudden itch to implement polls (Question objects), read-only at first. We're discarding a lot of those. | 19:11:17 |
jaywink | I won't stop you! | 19:26:30 |
26 Feb 2024 |
BassBot | [jaywink/federation] jaywink
approved
merge request !183: Fixes addressing various manually tracked content issues. | 21:39:42 |
29 Feb 2024 |
BassBot | [jaywink/federation] alainstd
merged
merge request !183: Fixes addressing various manually tracked content issues. | 00:58:05 |
BassBot | [jaywink/federation] alainstd
pushed
16 commits
to
master:
-
8a4863fc
Merge branch 'fix-CVE-2024-23832' into todos-and-issues
-
2ee17e4a
Merge branch 'master' into todos-and-issues
-
e992e2dc
Update CHANGELOG.
-
3dfe7d63
use markdownify instead of as md.
-
1f15583a
Merge branch 'todos-and-issues' into 'master' […]
| 00:58:05 |
| phizzapritta left the room. | 13:34:31 |
1 Mar 2024 |
jaywink | https://readthedocs.org/dashboard/socialhome/ and https://readthedocs.org/dashboard/federation/ fixed, they broke as Read The Docs started (rightfully) requiring a token for webhooks, notifications which I had ignored 😅
https://blog.readthedocs.com/security-update-on-incoming-webhooks/ | 23:42:31 |
jaywink | * https://socialhome.readthedocs.io and https://federation.readthedocs.io fixed, they broke as Read The Docs started (rightfully) requiring a token for webhooks, notifications which I had ignored 😅
https://blog.readthedocs.com/security-update-on-incoming-webhooks/ | 23:44:06 |
8 Mar 2024 |
| c10 left the room. | 17:50:19 |
Alain | So we now have an AP platform setting their profile url property to an array, which we do not handle. In their specific case, the array contains two uris, and one is actually a redirect to the other. In this case it's easy to decide which one to pick. I wonder if federation should handle this or leave it to socialhome. | 18:38:06 |
jaywink | weird, I wonder what the use case is? | 19:31:13 |
jaywink | I'd say federation should handle it though | 19:31:32 |
Alain | Federation already handles cases where the profile url is a Link object. I'm not too worried about this platform. Looks like their use case is to identify all URIs that redirected to the actual profile uri. | 20:16:15 |
Alain | That's my guess. | 20:17:03 |
Alain | It does seem to go against the AP spec. That wouldn't be a first. 🙂 | 20:21:19 |
jaywink | lots of people have lots of ideas | 20:57:35 |
jaywink | and AP is a bit loose :P | 20:57:47 |
Alain | Yeah, a tad loose. | 21:29:57 |