95 Members
Python for Solar Physics - https://sunpy.org - +sunpy:openastronomy.org for other channels9 Servers

Load older messages

Timestamp Message
21 Nov 2019
15:44:25@cadair:cadair.comCadairseems a shame to not be able to use reprojects coadd
15:47:37@dstansby:matrix.orgdstansbyScreenshot 2019-11-21 at 15.47.21.png
Screenshot 2019-11-21 at 15.47.21.png
15:54:49@cadair:cadair.comCadairI suppose the obvious hack would be to do two reprojects, reproject them all to HGC first and then reproject them again
15:55:07@cadair:cadair.comCadair dstansby: don't suppose you fancy a distraction and review https://github.com/sunpy/sunpy/pull/3504 ?! 😁
15:57:35@dstansby:matrix.orgdstansbyah that's a good idea, then I can do the weights properly too
16:09:30@cadair:cadair.comCadair Nabobalis: for the WISPR PR, did you see anything other than that one test fail?
16:09:44@cadair:cadair.comCadairbecause that test was just crap, but you were speaking like it was rather busted?
16:10:07@Nabobalis:matrix.orgNabobalisit was two tests in that file?
16:10:13@Nabobalis:matrix.orgNabobalis * it was two tests in that file?
16:10:28@Nabobalis:matrix.orgNabobalisif the test was crap, thats fine
16:15:30@wtbarnes:matrix.orgwtbarnes Sorry I’ve not caught up to all of this yet.
16:16:43@wtbarnes:matrix.orgwtbarnes@cadair @nabobalis the change log has been committed but I’ve not done the tag yet because I need to fix RTD
16:17:04@Nabobalis:matrix.orgNabobalisdid you update the PR stuart?
16:17:01@cadair:cadair.comCadair Nabobalis has now done that for us
16:17:07@Nabobalis:matrix.orgNabobalis * did you update the PR stuart?
In reply to @Nabobalis:matrix.org
did you update the PR stuart?
the wispr one? Not yet.
16:17:28@Nabobalis:matrix.orgNabobalisdid you just test the numbers better?
16:18:01@cadair:cadair.comCadairlooks like there is an online test which is buggered
16:18:05@cadair:cadair.comCadairso I am trying to pin that down
In reply to @Nabobalis:matrix.org
did you just test the numbers better?
yeah I fixed test_wcs by doing quantity comparisions
16:18:40@Nabobalis:matrix.orgNabobaliswell thats fine then
16:18:50@Nabobalis:matrix.orgNabobalisi clearly dont understand any of sunpy
16:21:48@wtbarnes:matrix.orgwtbarnes Ok so once #3531 is backported to the 1.0 branch then things should be good to go
16:21:49@_neb_github:matrix.orgGithubhttps://github.com/sunpy/sunpy/pull/3531 : Update .rtd-environment.yml
16:22:08@Nabobalis:matrix.orgNabobalisits already there
16:22:29@Nabobalis:matrix.orgNabobalisi just committed directly to 1.0 to test rtd
16:26:10@wtbarnes:matrix.orgwtbarnesAh ok. Missed that somehow. Thanks for doing that. 👍
16:27:34@cadair:cadair.comCadaircodecov is angry: https://dev.azure.com/sunpy/sunpy/_build/results?buildId=4447&view=logs&jobId=ee495bac-2f4a-5437-e8cd-3b8d0366407f&taskId=8145a9d6-5930-5de4-bb16-98bb8f85473f&lineStart=49&lineEnd=50&colStart=1&colEnd=1

There are no newer messages yet.

Back to Room List