27 Aug 2019 |
Thibaud | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org then this function would be defined as:
from draftjs_exporter.dom import DOM
def convert_icon_to_html(props):
text = props['children']
icon_name = text
return DOM.create_element('i', {
'class': 'rtfa fa %s' % icon_name,
})
I haven’t tried the code though | 09:55:56 |
Thibaud | In reply to@_slack_wagtailcms_UFCCF5RND:matrix.org image.png I don’t think it’s possible unfortunately. There might be variations in markup that are close, but with the current implementation of list items this would make "Here’s a third item" behave as if it was the first item in a new ordered list | 12:59:01 |
Thibaud | In reply to@_slack_wagtailcms_U9DQ4PP9R:matrix.org Thibaud - I’m integrating draftail into an application. The application is wagtail, but I’m putting this into the non-wagtail, react part. I’m getting this error when I ‘unmount’ a component. Might you have a suggestion?
> Warning: Can’t perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
in CommentEditor (created by CommentEditForm)
in div (created by CommentEditForm)
in form (created by CommentEditForm)
in CommentEditForm (created by CommentItem)
The error happens when the editor calls ‘save’ and my handler tries to update state, as in useState hook I’ve seen this before as well | 13:16:55 |
Thibaud | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I’ve seen this before as well I think this is exactly what you described, and probably a bug in Draftail – it should stop trying to call the "save" handler once unmounted | 13:18:32 |
Thibaud | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I think this is exactly what you described, and probably a bug in Draftail – it should stop trying to call the "save" handler once unmounted https://github.com/springload/draftail/issues/208 | 14:01:46 |
28 Aug 2019 |
| Hanz van Aardt changed their profile picture. | 01:26:09 |
29 Aug 2019 |
| scotchester changed their profile picture. | 17:57:33 |
30 Aug 2019 |
Martin Kimmig | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I haven’t tried the code though Hi Thibaud. I just tested it - and it seems to work 🙂 Thank you very very much! I highly appreciate your help! Have a nice weekend! | 07:36:56 |
Thibaud | In reply to@_slack_wagtailcms_UMQ2MVBEJ:matrix.org Hi Thibaud. I just tested it - and it seems to work 🙂 Thank you very very much! I highly appreciate your help! Have a nice weekend! Sweet :) You too | 09:19:36 |
2 Sep 2019 |
Jason Dilworth | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I don’t think it’s possible unfortunately. There might be variations in markup that are close, but with the current implementation of list items this would make "Here’s a third item" behave as if it was the first item in a new ordered list Ah that’s a real shame, I’m used to using some Markdown and having it ‘just work’ for want of a better phrase. I will ask the editors to just choose one type of list for now, thanks for the answer. | 15:46:16 |
Jason Dilworth | In reply to@_slack_wagtailcms_UFCCF5RND:matrix.org Ah that’s a real shame, I’m used to using some Markdown and having it ‘just work’ for want of a better phrase. I will ask the editors to just choose one type of list for now, thanks for the answer. (edited) Ah that’s ... => Thibaud Ah that’s ... | 15:46:31 |
Thibaud | In reply to@_slack_wagtailcms_UFCCF5RND:matrix.org Thibaud Ah that’s a real shame, I’m used to using some Markdown and having it ‘just work’ for want of a better phrase. I will ask the editors to just choose one type of list for now, thanks for the answer. I’ll check whether it would be possible to implement this but can’t promise anything | 20:06:23 |
Thibaud | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I’ll check whether it would be possible to implement this but can’t promise anything I see someone has just filed an issue for this, are they working with you or is it just a coincidence? https://github.com/springload/draftail/issues/209 | 20:06:53 |
5 Sep 2019 |
sharpertool | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org https://github.com/springload/draftail/issues/208 Thanks Thibaud | 22:45:46 |
6 Sep 2019 |
Jason Dilworth | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org I see someone has just filed an issue for this, are they working with you or is it just a coincidence? https://github.com/springload/draftail/issues/209 Just coincidence! | 10:02:13 |
Jason Dilworth | This might not be the place to ask, and please let me know if that’s the case, but does anyone know of a neat way to link to a RoutablePage within the editor? | 10:05:30 |
Thibaud | generally I don’t think RoutablePage URLs are exposed anywhere in the Wagtail UI, including the editor | 14:51:12 |
KalobTaulien | Sounds accurate. Although I wonder if that'd be a good idea to expose those urls in the page chooser modal? Got me thinking now haha | 18:03:32 |
9 Sep 2019 |
| tom changed their profile picture. | 11:39:32 |
sharpertool | Thibaud - is this something you recognize?
> const initialContent = { entityMap: {}, blocks: [] }
> const initialEditorState = createEditorStateFromRaw(initialContent)
I get an error on the 2nd line: “TypeError: cannot read property ‘getKey’ of undefined”
This is nearly a cut-paste from your docs, so not sure what I’m missing. | 16:16:42 |
sharpertool | Looks like you need at least this:
>>> {
entityMap: {},
blocks: [{text: ‘’, type: ‘unstyled’}]})
} | 20:20:34 |
10 Sep 2019 |
| thp44 changed their profile picture. | 15:31:37 |
12 Sep 2019 |
Thibaud | sharpertool yep – there is a bug / implementation detail in the Draft.js conversion that means the content needs to at least have one block | 13:47:45 |
Thibaud | (edited) ... one block => ... one block in it | 13:47:46 |
Thibaud | The editor wouldn’t be usable anyway if it was initialised with "no blocks", but the way this fails is a bit annoying | 13:48:21 |
| mattwestcott changed their profile picture. | 15:18:06 |
| scotchester changed their profile picture. | 15:51:32 |
| sharpertool changed their profile picture. | 21:44:16 |
sharpertool | In reply to@_slack_wagtailcms_U0ME9SGR1:matrix.org The editor wouldn’t be usable anyway if it was initialised with "no blocks", but the way this fails is a bit annoying Well, maybe the example can be updated to represent the minimal required value | 21:44:27 |
| flipperpa changed their profile picture. | 23:21:24 |