!KXuIZXQfZbpAMwZnrm:matrix.org

EinsteinPy

18 Members
Chat about EinsteinPy, a Python library for General Relativity1 Servers

Load older messages


Timestamp Message
14 Mar 2019
16:32:38@ritzvik:matrix.orgritzvikRedacted or Malformed Event
16:36:57@ritzvik:matrix.orgritzvik
// to set upstream branch
git remote add upstream https://github.com/einsteinpy/einsteinpy
// to fetch head pointer
git fetch upstream
// to overwrite the changes with new ones
git reset --hard upstream/master
// to check the commits
git log --oneline
// to open a new branch for development
git checkout -b <name_of_branch>

happy development

16:37:42@ritzvik:matrix.orgritzvik
In reply to @gitter_raphaelreyna:matrix.org
Hello. So I think I can speed up the for loop for $\Gamma^{1}{l,k}$ and $\Gamma^{2}{l,k}$ in the christoffels method in kerr_utils.py. Do I make these changes in my own forked version and then start another pull request? Apologies again for the basic questions.
sure!. Do what u feel best
16:38:31@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter)thanks ritzvik!
16:39:11@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter) (edited) thanks ritzvik! => thanks @ritzvik!
16:39:34@ritzvik:matrix.orgritzvik raphaelreyna: always open a new branch for development . Never directly do it on the master. I've learnt it the hard way
16:39:46@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter)gotcha
16:40:12@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter)should I then merge that into my master branch before submitting the new pull request?
16:41:57@ritzvik:matrix.orgritzvik

No, push that specific branch to github

git push origin <name_of_branch>

make a pull request from there.
Master can fall behind or stay in sync with upstream, but never diverge

16:43:58@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter) ah ok I see. I'll be working on this a bit later today. Thanks again for your help and explanations @ritzvik.
16:45:42@ritzvik:matrix.orgritzvik

ah ok I see. I'll be working on this a bit later today. Thanks again for your help and explanations @ritzvik.

FYI today for you is tonight for us. We are from India. 😁 Contribute whenever u feel like

16:55:07@shreyasbapat:matrix.orgshreyasbapatgit rebase!
16:55:18@shreyasbapat:matrix.orgshreyasbapatAlways rebase
15 Mar 2019
22:12:06@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter) So I think I have managed to speed up the christoffels method a bit more in kerr_utils.py. Now that issue #108 is closed, do I open a new issue for the pull request or use the same issue number?
22:12:32@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter)Also, sorry for pushing the change to my master branch, totally forgot to start a development branch.
22:14:01@shreyasbapat:matrix.orgshreyasbapatIt's fine :) > Also, sorry for pushing the change to my master branch, totally forgot to start a development branch.
22:14:21@shreyasbapat:matrix.orgshreyasbapatYou can open a separate issue
22:14:29@shreyasbapat:matrix.orgshreyasbapatIt will be better for tracking
22:15:06@gitter_raphaelreyna:matrix.orgRaphael Reyna (Gitter)sounds good. thanks!
22:16:29@shreyasbapat:matrix.orgshreyasbapat:)
17 Mar 2019
05:57:13@raphaelreyna:matrix.orgraphaelreynaHi guys, sorry for the mess with the commits. I for some reason didn't realise that I could run the tests myself and didn't have to keep commiting to test
05:58:56@ritzvik:matrix.orgritzvik
In reply to @raphaelreyna:matrix.org
Hi guys, sorry for the mess with the commits. I for some reason didn't realise that I could run the tests myself and didn't have to keep commiting to test
No problem. I guess everybody starts as a newbie
08:31:34@shreyasbapat:matrix.orgshreyasbapat
In reply to @raphaelreyna:matrix.org
Hi guys, sorry for the mess with the commits. I for some reason didn't realise that I could run the tests myself and didn't have to keep commiting to test
It's perfectly fine!
08:34:01@shreyasbapat:matrix.orgshreyasbapatGuys we will be having a feature planning meeting on Tuesday for our 0.1.1 release. All are invited to join.
08:34:15@shreyasbapat:matrix.orgshreyasbapatI will post the link for the meeting soon
18 Mar 2019
08:45:16@astrojuanlu:matrix.orgastrojuanlu joined the room.
08:45:23@astrojuanlu:matrix.orgastrojuanluhi all! 👋🏽
08:45:44@shreyasbapat:matrix.orgshreyasbapat Woah! Welcome astrojuanlu :O
08:49:14@shreyasbapat:matrix.orgshreyasbapatI was having confusion about how to decide what should be in and what should be out (features). As we don't still know who is using EinsteinPy. But people are surely using it as we see from conda downloads. Juan guided me on how to decide what feature to keep and what not to. Will discuss it in tomorrow's meeting
08:51:53@ritzvik:matrix.orgritzvik astrojuanlu: Welcome here!!

There are no newer messages yet.


Back to Room List