• f4056feb Update Hindi translation by Guntupalli Karunakar

• 1f974715 Add Bulgarian translation by Alexander Shopov

This patch adds explicit removal of potential dangling buffering probe.

Not removing the old probe can prevent playback until the entire application is restarted.

The broken state could be reached by pressing the play button again, while some buffering was already in progress.

Some issues sound like they might be somewhat related, in that the playback never comes back, once in failure mode.

• https://gitlab.gnome.org/World/Shortwave/-/issues/718
• https://gitlab.gnome.org/World/Shortwave/-/issues/503

Clippy seems to look at some cached checkout.

The current nightly build (and local build of main branch) lacks support for .ico files. This is a regression.

From gdk-pixbuf I get the Unrecognized image file format error. (Found by adding extra print statements in a local build)

Notice how "Radio Zusa" and "INTERGALACTIC FM .*" have a favicon in the stable release, but only the placeholder in the nightly version.

Version 3.2.0-devel (nightly installed on 2024-05-09): Version 3.2.0:

It seems org.gnome.Platform changed what pixbuf loaders they ship by default.

org.gnome.Platform/x86_64/45:

$ python3 -c "import gi.repository.GdkPixbuf as pixbuf;from pprint import pprint;pprint([(f.get_name(), f.get_mime_types()) for f in pixbuf.Pixbuf.get_formats()])"
<string>:1: PyGIWarning: GdkPixbuf was imported without specifying a version first. Use gi.require_version('GdkPixbuf', '2.0') before import to ensure that the right version gets loaded.
[('png', ['image/png']),
 ('jpeg', ['image/jpeg']),
 ('ani', ['application/x-navi-animation']),
 ('avif', ['image/avif']),
 ('bmp', ['image/bmp', 'image/x-bmp', 'image/x-MS-bmp']),
 ('gif', ['image/gif']),
 ('icns', ['image/x-icns']),
 ('ico',
 ['image/x-icon',
 'image/x-ico',
 'image/x-win-bitmap',
 'image/vnd.microsoft.icon',
 'application/ico',
 'image/ico',
 'image/icon',
 'text/ico']),
 ('pnm',
 ['image/x-portable-anymap',
 'image/x-portable-bitmap',
 'image/x-portable-graymap',
 'image/x-portable-pixmap']),
 ('qtif', ['image/x-quicktime', 'image/qtif']),
 ('svg',
 ['image/svg+xml',
 'image/svg',
 'image/svg-xml',
 'image/vnd.adobe.svg+xml',
 'text/xml-svg',
 'image/svg+xml-compressed']),
 ('tga', ['image/x-tga']),
 ('tiff', ['image/tiff']),
 ('xbm', ['image/x-xbitmap']),
 ('xpm', ['image/x-xpixmap'])]

org.gnome.Platform/x86_64/46 and org.gnome.Platform/x86_64/master:

$ python3 -c "import gi.repository.GdkPixbuf as pixbuf;from pprint import pprint;pprint([(f.get_name(), f.get_mime_types()) for f in pixbuf.Pixbuf.get_formats()])"
<string>:1: PyGIWarning: GdkPixbuf was imported without specifying a version first. Use gi.require_version('GdkPixbuf', '2.0') before import to ensure that the right version gets loaded.
[('png', ['image/png']),
 ('jpeg', ['image/jpeg']),
 ('avif', ['image/avif']),
 ('gif', ['image/gif']),
 ('jxl', ['image/jxl']),
 ('svg',
 ['image/svg+xml',
 'image/svg',
 'image/svg-xml',
 'image/vnd.adobe.svg+xml',
 'text/xml-svg',
 'image/svg+xml-compressed']),
 ('tiff', ['image/tiff']),
 ('webp', ['image/webp', 'audio/x-riff'])]

(the python one liner is from https://gitlab.gnome.org/GNOME/gnome-build-meta/-/issues/502)

Since gdk-pixbuf version 2.42.11 (via https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/merge_requests/163) some unmaintained loaders were disabled by default for attack surface reduction.

Some folks want to re-enable them: https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/merge_requests/169

But Michael Catanzaro wrote on the redhat issue tracker:

To be clear:

• gdk-pixbuf is unsafe, period (if you are loading an untrusted image)
• Removing obscure decoders makes it somewhat safer, but doesn't make the remaining decoders safe to use

To me it looks like they should and will be going away in the future.

He also mentions glycin, which may be interesting... :eyes:

When no favicon could be loaded, make sure the SidebarController's favicon is reset to the placeholder.

Closes #711

• 9e7bf91b Fix persisting favicons of previous station […] by Philipp Bartsch
• 54f9f950 Merge branch 'previous-favicon' into 'main' […]

Came here to request this feature as well. While, well thought out and written, this might be worth breaking up into multiple issues.

Note that I don't get crashes, but #575 which was reporting this was duped on that issue: On one station I listen to and where Shortwave find "tracks", Shortwave is absolutely spamming journald with such messages: shortwave[1274489]: ERROR shortwave::audio::backend::gstreamer_backend > Unable to determine correct recording value: 295581 seconds.

• 33391e74 Update Portuguese translation by Hugo Carvalho

Shortwave using the default search delay (150ms) in its SearchEntry widget is surely wasteful, because pretty much nobody can type that fast, and you're essentially having the userbase DDoS whatever stations index registry servers you are querying. It would probably create expensive roundtrips on high-latency (ex: mobile/rural) connections. I would suggest using a 500ms search-delay property value instead.

Same principles and logic as https://gitlab.gnome.org/GNOME/gnome-calendar/-/issues/1170, https://github.com/getting-things-gnome/gtg/issues/281, https://gitlab.gnome.org/GNOME/Incubator/papers/-/issues/101, https://gitlab.gnome.org/GNOME/gnome-software/-/issues/2580, etc.