• 0dd7222f window: Port to bottom sheets […] by Christopher Davis
• 0e62b412 Merge branch 'wip/cdavis/port-to-bottom-sheets' into 'main' […]

• 7ca74afb i18n: Update POTFILES

• 6f49cd0b Update Hebrew translation by Yosef Or Boczko

• 0d785ed7 Update Chinese (China) translation by Luming Zh

• cf2d90cd Update Georgian translation by Ekaterine Papava

• 447e54c9 Update Russian translation by Artur S0

• 9090c7dd Update Persian translation by Danial Behzadi

• 20bd475d metainfo: drop wrong comment
• df5f2915 audio: Create new SwPlayer class

Goals

• Get rid of app::Action enum
• Get rid of Controller trait -> Make use of property bindings instead
• Separate GTK UI from logic (Player contains both the logic and gtk widget machinery)

Unblock

• https://gitlab.gnome.org/World/Shortwave/-/issues/704
• https://gitlab.gnome.org/World/Shortwave/-/issues/471
• https://gitlab.gnome.org/World/Shortwave/-/issues/475

volume_button.connect_value_changed(move |_, value| {
            // 1
            SwApplication::default().player().set_volume(value);

            // 2
            SwApplication::default()
                .imp()
                .legacy_player
                .set_volume(value);
        });

So I'm trying to port everything to a new SwPlayer class. Setting volume only works for 1 but not for 2. But both are calling the exactly same methods

legacy / 1 set_volume method

    pub fn set_volume(&self, volume: f64) {
        debug!("Set volume: {}", &volume);
        self.backend.borrow().gstreamer.set_volume(volume);

        settings_manager::set_double(Key::PlaybackVolume, volume);
    }

new SwPlayer set_volume method:

        fn set_volume(&self, volume: f64) {
            debug!("Set volume: {}", &volume);
            self.backend.borrow().gstreamer.set_volume(volume);
            self.volume.set(volume);

            settings_manager::set_double(Key::PlaybackVolume, volume);
        }

I can verify that both are calling gstreamer.set_volume which calls

            pulsesink.set_property("volume", pa_volume);
            dbg!(pulsesink.property::<f64>("volume"));

Both are coming from the same thread. But only 1 actually sets the volume. 2 doesn't change the volume, but sets the same pulsesink property (= I can see the debug output)

???

What is this?? The volume gets set on gstreamer side, but it has no effect?! I'm updating the pulsesink property, but it just gets ignored when I call it from the new gobject class.

0:00:12.994361666     2 0x5576a175d560 DEBUG                  pulse pulsesink.c:2426:gst_pulsesink_set_volume:<pulsesink> setting volume to 0.272284
0:00:12.994379650     2 0x5576a175d560 DEBUG                  pulse pulsesink.c:2470:gst_pulsesink_set_volume:<pulsesink> we have no ringbuffer
0:00:12.994404496     2 0x5576a175d560 DEBUG                  pulse pulsesink.c:2644:gst_pulsesink_get_sink_input_info:<pulsesink> we have no ringbuffer

1. the bottom sheet calls the new SwPlayer class
2. The mini player calls the old legacy player

Both end up on gstreamer side. But only 2) works, as you can see in pavucontrol. I don't get it why the volume doesn't get applied when gets called from the new class. It's 1:1 the same codepath.

            pulsesink.set_property("volume", pa_volume);
            dbg!(pulsesink.property::<f64>("volume"));
            dbg!(std::thread::current().id());

Both print the same thread ID