9 Jul 2024 |
Gitlab Notifications | [World/Shortwave] alicem
commented on
merge request !493: Draft: Port to AdwSpinner
1.6.beta
| 20:19:45 |
Gitlab Notifications | [World/Shortwave] alicem
commented on
merge request !493: Draft: Port to AdwSpinner
should the sizes be left as they were?
no. They were already wrong
| 20:20:00 |
Gitlab Notifications | [World/Shortwave] alicem
commented on
merge request !493: Draft: Port to AdwSpinner
Tho note that in cases like this you need to make AdwSpinner smaller manually
| 20:20:24 |
Gitlab Notifications | [World/Shortwave] alicem
commented on
merge request !493: Draft: Port to AdwSpinner
i.e. size=16 for all where it was default. Those where it was 40 should be just the default value.
| 20:20:56 |
Gitlab Notifications | [World/Shortwave] msandova
commented on
merge request !493: Draft: Port to AdwSpinner
Thanks!
| 20:23:24 |
Gitlab Notifications | [World/Shortwave] msandova
changed the title of
merge request !493 to Port to AdwSpinner | 20:44:12 |
10 Jul 2024 |
| @philippe62141:club1.fr left the room. | 08:33:46 |
11 Jul 2024 |
Gitlab Notifications | [World/Shortwave] haecker-felix
merged
merge request !492: readme: Update Flathub badge | 07:50:16 |
Gitlab Notifications | [World/Shortwave] haecker-felix
pushed
2 commits
to
main:
-
2d4fb7a4
readme: Update Flathub badge
by Brage Fuglseth
-
d8b75647
Merge branch 'bragefuglseth-main-patch-37744' into 'main' […]
| 07:50:16 |
Gitlab Notifications | [World/Shortwave] teoulas
commented on
issue #500: use new ability to fetch multiple stations at once
First of all, thanks for the nice app!
I got to this issue from https://gitlab.gnome.org/World/Shortwave/-/issues/715 - I'm also facing API rate limits due to the number of saved stations in my list.
I just tried a POST with multiple UUIDs and it seems to work now, even with UUIDs that don't exist in the database. See the following curl example:
curl --silent --request POST \
--url https://nl1.api.radio-browser.info/json/stations/byuuid \
--header 'content-type: application/json' \
--data '{
"uuids": [
"9a544b89-b2ef-11e8-afe1-52543be04c81",
"963cf00c-0601-11e8-ae97-52543be04c81",
"random",
"aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
]
}' | jq ".[].stationuuid"
"963cf00c-0601-11e8-ae97-52543be04c81"
"9a544b89-b2ef-11e8-afe1-52543be04c81"
Maybe it's worth trying this approach again. Would be great to close this issue along with #715.
| 14:29:21 |
Gitlab Notifications | [World/Shortwave] teoulas
commented on
issue #500: use new ability to fetch multiple stations at once
First of all, thanks for the nice app!
I got to this issue from https://gitlab.gnome.org/World/Shortwave/-/issues/715 - I'm also facing API rate limits due to the number of saved stations in my list.
I just tried a POST with multiple UUIDs and it seems to work now, even with UUIDs that don't exist in the database. See the following curl example:
curl --silent --request POST \
--url https://nl1.api.radio-browser.info/json/stations/byuuid \
--header 'content-type: application/json' \
--data '{
"uuids": [
"9a544b89-b2ef-11e8-afe1-52543be04c81",
"963cf00c-0601-11e8-ae97-52543be04c81",
"random",
"aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa"
]
}' | jq ".[].stationuuid"
"963cf00c-0601-11e8-ae97-52543be04c81"
"9a544b89-b2ef-11e8-afe1-52543be04c81"
Maybe it's worth trying this approach again. Would be great to close this issue along with #715.
| 14:34:06 |
Gitlab Notifications | [World/Shortwave] alicem
commented on
merge request !493: Port to AdwSpinner
Missed this one
| 16:48:29 |
13 Jul 2024 |
Gitlab Notifications | [World/Shortwave] msandova
opened
merge request !494: Update to gtk4-rs 0.9
Depends on https://gitlab.gnome.org/World/Shortwave/-/merge_requests/491
| 16:26:53 |
Felix | wait what, we have gtk4-rs 0.9 now? ._. | 16:27:24 |
Maximiliano 🥑 | YES | 16:27:46 |
Felix | Download image.png | 16:27:55 |
Maximiliano 🥑 | well yeah | 16:28:00 |
Felix | the joys 🥲 | 16:28:01 |
Maximiliano 🥑 | you see | 16:28:02 |
Maximiliano 🥑 | the new clone macro allows rustfmt to do its thing | 16:28:16 |
Maximiliano 🥑 | hence the size | 16:28:20 |
Maximiliano 🥑 | see the diff without whitespace changes, that will make it more legible | 16:28:45 |
Felix | In reply to @msandova:gnome.org YES any other changes beside new clone macro? | 16:29:22 |
Maximiliano 🥑 | There was a single function which passed a @weak sender which was not actually being used | 16:29:46 |
Maximiliano 🥑 | and adw_dialog_present's argument is now nullable | 16:30:07 |
Felix | In reply to @msandova:gnome.org There was a single function which passed a @weak sender which was not actually being used yes, absolutely possible, I'm still in process of ripping out the message passing infrastructure and there are some leftovers left. | 16:30:49 |
Maximiliano 🥑 | I mean, the surprise is that there was only 1 unnecesary weak ref | 16:31:10 |
Felix | the biggest part being the audio backend | 16:31:08 |
Maximiliano 🥑 | the average app I port has like 1-5 | 16:31:17 |
Felix | In reply to @msandova:gnome.org I mean, the surprise is that there was only 1 unnecesary weak ref I already removed many of them few weeks ago | 16:31:29 |