| 9 Jan 2024 |
|  jackcurtisviers joined the room. | 15:17:28 |
|  pertinax5488 changed their display name from pertinax to pertinax5488. | 17:49:47 |
|  .xolve joined the room. | 21:10:29 |
|  clearbluesky joined the room. | 21:47:52 |
|  kotenoru joined the room. | 23:21:29 |
| 10 Jan 2024 |
|  potatoef changed their profile picture. | 11:33:02 |
|  guillaume0404 joined the room. | 18:46:49 |
|  djbpitt joined the room. | 21:54:13 |
| 11 Jan 2024 |
|  bharath_50557 joined the room. | 09:18:45 |
|  flensersteel joined the room. | 11:04:07 |
 fommil | a recent update in mill seems to have broken the ensime plugin, is anybody aware of what needs to be changed to get this line compiling again?
val coursierDeps = allIvyDeps.map(module.resolveCoursierDependency()).toList
the error is [error] found : mill.scalalib.Dep => coursier.Dependency
[error] (which expands to) mill.scalalib.Dep => coursier.core.Dependency
[error] required: mill.scalalib.BoundDep => ?
[error] val coursierDeps = allIvyDeps.map(module.resolveCoursierDependency()).toList
[error] ^
| 14:46:22 |
| fommil | Redacted or Malformed Event | 14:46:46 |
| fommil | * a recent update in mill seems to have broken the ensime plugin, is anybody aware of what needs to be changed to get this line compiling again?
val coursierDeps = allIvyDeps.map(module.resolveCoursierDependency()).toList
val withSources = Resolution(
coursierDeps
.map(d =>
d.withAttributes(
d.attributes.withClassifier(coursier.Classifier("sources"))
)
)
.toSeq
)
the error is [error] found : mill.scalalib.Dep => coursier.Dependency
[error] (which expands to) mill.scalalib.Dep => coursier.core.Dependency
[error] required: mill.scalalib.BoundDep => ?
[error] val coursierDeps = allIvyDeps.map(module.resolveCoursierDependency()).toList
[error] ^
| 14:48:59 |
| fommil | maybe converting the mill.scalalib.Dep to a mill.scalalib.BoundDep would help out somehow? There's no obvious way to do that here http://mill-build.com/api/latest/mill/scalalib/Dep.html | 14:53:03 |
| fommil | looks like one of the many breaking changes in the 0.11.0 release. lihaoyi where's the best place to learn about migrating the API changes? | 14:58:54 |
| fommil | this part of the code is just enforcing that all the sources should be downloaded for all the dependencies, I suspect the metals support does something similar. | 15:00:08 |
| fommil | https://github.com/com-lihaoyi/mill/blob/main/contrib/bloop/src/mill/contrib/bloop/BloopImpl.scala#L328 seems relevant | 15:01:10 |
| fommil | allIvyDeps.map(_.dep)
seems to work as the replacement, same as the change in the Bloop impl | 15:03:51 |
| fommil | it's a shame that the ensime plugin isn't included in the contrib module, but hey ho, life goes on. | 15:04:32 |
| fommil | https://gist.github.com/fommil/a5618ddc16f38465ff6d50c9da9ec9b9
is the full version of the plugin that seems to work for 0.11.x | 15:08:11 |
 Tobias Roeser | fommil: IIRC, I offered you to add the ensime plugin to the contrib section, but you declined. | 15:08:29 |
| Tobias Roeser | * fommil: IIRC, I offered you to add the ensime plugin to the contrib repo, but you declined. | 15:08:43 |
| Tobias Roeser | In reply to @tobiasroeser:matrix.org
fommil: IIRC, I offered you to add the ensime plugin to the contrib repo, but you declined. https://github.com/com-lihaoyi/mill/discussions/2075#discussioncomment-3932673 | 15:09:41 |
| fommil | I said "Thanks for the offer. However, if the user still needs to extends Ensime if it's distributed under contrib, then I'm not sure it makes any sense to have it distributed as part of Mill." which seems to be the end of the conversation, I wouldn't call that "declining". Do users need to manually enable a bloop plugin, for example? | 15:11:33 |
| Tobias Roeser | So let me quote myself: "You can add a new module to the contrib section and open a PR.". It's up to you. | 15:12:39 |
| fommil | I'm potentially interested in that, if the value is that these sorts of breaking API changes are fixed as they are introduced.
What is the UX like for bloop / metals / intellij, are those plugins automatically enabled or does the user need to extends Something to turn them on? | 15:14:03 |
| Tobias Roeser | Yeah. We try to keep contrib plugin compiling and their test suites pass. | 15:14:39 |
| fommil | I don't have a test suite, would that be a requirement? | 15:14:57 |
| Tobias Roeser | It's a soft requirement to keep it functional without manual testing, I guess. Otherwise, only compile issues can be detected. | 15:16:24 |
| Tobias Roeser | The UX should change from the way it's currently enabled. Depends on if it can act as external module (https://mill-build.com/mill/Modules.html#_external_modules) or if it needs per-module configuration. | 15:18:02 |
