| 17 May 2018 |
 TravisR | !github create "Make angular cli happy about the project structure" "I've never used the tool myself, but it should probably work with the project layout. May require using it in anger." | 19:43:18 |
 MTRNord | I still expected the plugin to work :) as that cli should work still on projects that dont use it | 19:43:28 |
 GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live opened issue #100: Make angular cli happy about the project structure [open] - https://github.com/turt2live/evelium/issues/100 | 19:43:40 |
 @_neb_github:matrix.org | Created issue: https://github.com/turt2live/evelium/issues/100 | 19:43:41 |
| MTRNord | but I can live with out it just fine :) | 19:43:52 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] MTRNord opened pull request #101: Replace momentjs with pipes from ngx-moment [open] - https://github.com/turt2live/evelium/pull/101 | 19:56:38 |
| TravisR | 
Download image.png | 19:59:18 |
| TravisR | pffft... tests... | 19:59:19 |
| MTRNord | atleast one is happy :D and atleast you do actually add tests in angular ;P I have only the auto generated e2e tests from the cli and never touched them "because I dont know what I want to happen" ;P | 20:00:14 |
| TravisR | There's no tests in Evelium :p | 20:00:38 |
| TravisR | in fact, I delete them when they get auto-added | 20:00:47 |
 Cadair | Lol | 20:00:52 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live closed pull request #101: Replace momentjs with pipes from ngx-moment [closed] - https://github.com/turt2live/evelium/pull/101 | 20:01:33 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live closed issue #88: Angular doesn't like having moment timestamps for some reason [closed] - https://github.com/turt2live/evelium/issues/88 | 20:01:33 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] web-flow pushed 2 commits to master: https://github.com/turt2live/evelium/commit/458138dbfacec1fd451fe44429e9eada2373da5b
MTRNord: Replace momentjs with pipes from ngx-moment and factor it out to its own component
turt2live: Merge pull request #101 from MTRNord/fix-88
Replace momentjs with pipes from ngx-moment | 20:01:33 |
| * MTRNord just leaves them to make people think I would have implemented them ;P I will not add any tests before a stable 1.0.0 release in my software ;P (so after version 0.9999.9 propably ^^) | 20:02:05 |
| TravisR | Most of the things I build are small enough that they can be manually tested. For instance, it's pretty obvious if the Haiku bot stops working. | 20:05:03 |
| TravisR | Dimension and Evelium are large enough though where it makes sense to look at unit tests at the least. | 20:05:16 |
| MTRNord | TravisR: oh well :( you can reopen 88 it happened again :/ so my fix didn't fix it just moved it to a new code :/ | 20:09:08 |
| MTRNord | ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'null: 18 minutes ago'. Current value: 'null: 19 minutes ago'. | 20:09:18 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live reopened issue #88: Angular doesn't like having moment timestamps for some reason [open] - https://github.com/turt2live/evelium/issues/88 | 20:09:49 |
| TravisR | oh well, at least it's using filters now :p | 20:09:56 |
| MTRNord | TravisR: But I now know from a stackoverflow it is caused by the amTimeAgo which checks against Data.now() | 20:12:59 |
| MTRNord | the bad part: the fix for that is already applied on the lib | 20:15:03 |
| MTRNord | https://stackoverflow.com/a/37885072/4929236 | 20:15:46 |
| MTRNord | ps caching the displayNames of readreciepts reduces the event time by 3 seconds :) makes the ui a lot faster after initial load. but my current code doesn't respect name changes so not gonna PR it yet. | 21:03:43 |
| MTRNord | from being 14% of all js calls it is down to 2,66% | 21:04:25 |
| TravisR | wait, that's not cached? | 21:04:42 |
| MTRNord | TravisR: nope on each hover it does a request from what I see | 21:05:32 |
| MTRNord | TravisR: or to be more exyact it calls User.getDisambiguatedName on each hover | 21:06:15 |
