| 17 May 2018 |
 TravisR | in fact, I delete them when they get auto-added | 20:00:47 |
 @cadair:cadair.com | Lol | 20:00:52 |
 GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live closed pull request #101: Replace momentjs with pipes from ngx-moment [closed] - https://github.com/turt2live/evelium/pull/101 | 20:01:33 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live closed issue #88: Angular doesn't like having moment timestamps for some reason [closed] - https://github.com/turt2live/evelium/issues/88 | 20:01:33 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] web-flow pushed 2 commits to master: https://github.com/turt2live/evelium/commit/458138dbfacec1fd451fe44429e9eada2373da5b
MTRNord: Replace momentjs with pipes from ngx-moment and factor it out to its own component
turt2live: Merge pull request #101 from MTRNord/fix-88
Replace momentjs with pipes from ngx-moment | 20:01:33 |
| *  MTRNord just leaves them to make people think I would have implemented them ;P I will not add any tests before a stable 1.0.0 release in my software ;P (so after version 0.9999.9 propably ^^) | 20:02:05 |
| TravisR | Most of the things I build are small enough that they can be manually tested. For instance, it's pretty obvious if the Haiku bot stops working. | 20:05:03 |
| TravisR | Dimension and Evelium are large enough though where it makes sense to look at unit tests at the least. | 20:05:16 |
| MTRNord | TravisR: oh well :( you can reopen 88 it happened again :/ so my fix didn't fix it just moved it to a new code :/ | 20:09:08 |
| MTRNord | ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'null: 18 minutes ago'. Current value: 'null: 19 minutes ago'. | 20:09:18 |
| GitHub [@travis:t2l.io] (deprecated) | [turt2live/evelium] turt2live reopened issue #88: Angular doesn't like having moment timestamps for some reason [open] - https://github.com/turt2live/evelium/issues/88 | 20:09:49 |
| TravisR | oh well, at least it's using filters now :p | 20:09:56 |
| MTRNord | TravisR: But I now know from a stackoverflow it is caused by the amTimeAgo which checks against Data.now() | 20:12:59 |
| MTRNord | the bad part: the fix for that is already applied on the lib | 20:15:03 |
| MTRNord | https://stackoverflow.com/a/37885072/4929236 | 20:15:46 |
| MTRNord | ps caching the displayNames of readreciepts reduces the event time by 3 seconds :) makes the ui a lot faster after initial load. but my current code doesn't respect name changes so not gonna PR it yet. | 21:03:43 |
| MTRNord | from being 14% of all js calls it is down to 2,66% | 21:04:25 |
| TravisR | wait, that's not cached? | 21:04:42 |
| MTRNord | TravisR: nope on each hover it does a request from what I see | 21:05:32 |
| MTRNord | TravisR: or to be more exyact it calls User.getDisambiguatedName on each hover | 21:06:15 |
| TravisR | well, that would do it for sure. Good spot. | 21:06:25 |
| MTRNord | and according to the profiling each hover calls the api over and over | 21:06:55 |
| TravisR | Weird. I would have thought angular would have magic-cached that to be honest. | 21:07:47 |
| MTRNord | but it still is the most called api :) but atleast less of them | 21:08:02 |
| TravisR | for fixing the cache: can probably just invalidate the user when you see a new member event for them. | 21:08:18 |
| MTRNord | well I now did put it into a object array inside the class for read-receipts :) not the best place to put it but enough for testing the difference | 21:09:12 |
| MTRNord | I will tommorow implement this in a better way that is better to reuse. propably should implement this check/cache to the User.getDisambiguatedName method instead | 21:10:09 |
| TravisR | moving it to the User class is probably better, yea. It's also used for the timeline | 21:13:06 |
| 21 May 2018 |
|  @lazz:disroot.org left the room. | 20:19:20 |
| 23 May 2018 |
|  Half-Shot changed their display name from Half-Shot to Half-Shot (Away until 29th). | 11:57:38 |
