5446 Members
2 Servers

Load older messages

6 Dec 2023
@_discord_281034481773707264:t2bot.iomorg7672 not sure if the issue has always been or if it is a regression 09:02:02
@_discord_281034481773707264:t2bot.iomorg7672 This commit maybe
@_discord_281034481773707264:t2bot.iomorg7672 Yeah that was it 09:09:26
@_discord_281034481773707264:t2bot.iomorg7672 We have to remove the trailing 0, not sure where to fix that. Either before calling


Or inside ProfileManager::LoadProfile, or both..?

The fix :

while (!profile_name.empty() && profile_name.back() == 0)
@_discord_281034481773707264:t2bot.iomorg7672 https://gitlab.com/CalcProgrammer1/OpenRGB/-/merge_requests/2180
ryleu you can try this build
@_discord_176686431329189888:t2bot.iochr1sno If this is an issue in the network manager why are we applying the fix in the profile manager?? 09:41:36
@_discord_281034481773707264:t2bot.iomorg7672 As it's a public method, I think the check has to be done here to insure the input validity. It will also benefits to all other calls to LoadProfile/SaveProfile/DeleteProfile. 09:48:54
@_discord_281034481773707264:t2bot.iomorg7672 The issue is in ProfileManager, not in NetworkManager 09:49:28
@_discord_176686431329189888:t2bot.iochr1sno The problem is coming from the network manager specifically not handling strings properly 09:49:39
@_discord_281034481773707264:t2bot.iomorg7672 that's where the strings are concatenated 09:49:39
@_discord_176686431329189888:t2bot.iochr1sno If that were the case we would have issues with every other "load profile" call which we don't. What is the value of the string in the network manager prior to calling LoadProfile()?? 09:50:59
@_discord_281034481773707264:t2bot.iomorg7672 same as shown in the screenshot of the debug panel 09:51:24
@_discord_281034481773707264:t2bot.iomorg7672 ^ 09:51:29
@_discord_176686431329189888:t2bot.iochr1sno So the network manager is passing around a bad string 09:51:56
@_discord_176686431329189888:t2bot.iochr1sno that's were the problem should be fixed. 09:52:07
@_discord_176686431329189888:t2bot.iochr1sno What happens if you change line 800 to

and let the assign function find the null character?
@_discord_281034481773707264:t2bot.iomorg7672 according to the assign reference, it will copy the null char as well 09:59:11
c-string (3)    

string& assign (const char* s);

(3) c-string
    Copies the null-terminated character sequence (C-string) pointed by s.
@_discord_281034481773707264:t2bot.iomorg7672 or maybe i'm not understanding it correctly? 10:00:19
@_discord_281034481773707264:t2bot.iomorg7672 yeah, looks like it removes the null char 10:01:42
@_discord_176686431329189888:t2bot.iochr1sno I think passing the size is forcing the assign function to copy the null character into the data part of the string. 10:04:58
@_discord_176686431329189888:t2bot.iochr1sno 🤔 Concerning that no data inbound is being sanitised. 10:07:18
@_discord_600130839870963725:t2bot.ioryleu i can try that build after i get back 23:13:05
7 Dec 2023
@_discord_451026503086637056:t2bot.ione0_951 changed their display name from NE0_93 to ne0_951.01:35:54
@_discord_443138768015458305:t2bot.iosatired_ changed their display name from Satired to satired_.02:24:17
@_discord_673346421134721045:t2bot.iodeat0101010 changed their profile picture.18:55:29
@_discord_294951812966907904:t2bot.iozeerbeste changed their display name from thomas to zeerbeste.22:33:36
9 Dec 2023
@_discord_216205285231034368:t2bot.ioterdog changed their profile picture.23:09:10
13 Dec 2023
@_discord_358933783027777536:t2bot.iofrostybiscuit changed their display name from FrostyBiscuit to frostybiscuit.16:44:46
@_discord_324311714105655296:t2bot.iocampblor changed their display name from Campblor to campblor.20:38:05

Show newer messages

Back to Room ListRoom Version: 6