10 Apr 2024 |
adamw | that's https://github.com/osbuild/osbuild/blob/main/stages/org.osbuild.buildstamp#L13 | 18:15:03 |
pwhalen | thanks | 18:16:18 |
adamw | i'll file an issue so we can tag it from openqa and pull the osbuild folks in if needed | 18:17:22 |
adamw | https://pagure.io/fedora-iot/issue/57 | 18:21:17 |
Micah Abbott | pwhalen (maybe adamw ) can i suggest we capture these, umm...."challenges" in the ticket we have tracking the F40 final candidates - https://github.com/fedora-iot/iot-distro/issues/39
it would be good if we can use this to improve our SOP next time
| 18:21:24 |
pwhalen | Micah Abbottwill do
| 18:22:02 |
adamw | huh. i wonder why openqa suddenly noticed this, though? that's odd. | 18:25:34 |
adamw | oh, because the previous composes didn't have the pre-release note... | 18:26:51 |
adamw | see e.g. https://openqa.fedoraproject.org/tests/2548916#step/_boot_to_anaconda/9 , no red text, and there's no timbuktu warning clickthrough either | 18:27:15 |
adamw | so, what changed in 0410.0? | 18:27:28 |
pwhalen | good question! perhaps an upgrade to osbuild | 18:28:27 |
pwhalen | doesn't appear to have changed - osbuild_version': '109 | 18:30:45 |
pwhalen | osbuild/images went from 47-51 | 18:31:36 |
adamw | that sounds plausible as a suspect | 18:31:57 |
adamw | 6df70ab24a736a126e4003ba01d51fa119986f82 | 18:32:37 |
adamw | riiight, yeah, this is bringing back memories | 18:32:47 |
adamw | i think i told them that'd go wrong at final, then we forgot about it | 18:33:03 |
Micah Abbott | https://github.com/osbuild/images/pull/522#issuecomment-2004526301 | 18:35:33 |
Micah Abbott | it's like you predicted this would happen, Adam | 18:35:42 |
adamw | haha, yup | 18:37:06 |
adamw | adding a told-ya-so comment. although, to be fair, it's harder to magically dtrt for IoT since you just have one compose stream per release and all the composes are 'candidates' in productmd terms | 18:37:29 |
adamw | like, i don't see how osbuild could possibly 'decide' whether the compose should show warnings or not, there's just gonna have to be a button for you folks to press to turn it on and off | 18:38:01 |
Micah Abbott | sounds like we need that flag/option to say isFinal=True | 18:48:38 |
adamw | right now we do, yeah. but then up to, say, yesterday we probably didn't. though...i think before osbuild, iot images just never displayed the warnings | 18:57:03 |
adamw | so maybe going back to that is okay, though getting it right might be nicer. | 18:57:30 |
Micah Abbott | if we could configure that in here https://pagure.io/fedora-iot/pungi-iot/blob/f40/f/fedora-iot.conf#_225-236
...that feels like we would have more control in our own destiny | 18:58:18 |
adamw | that doesn't really feel like the appropriate place for the lever to me | 18:59:05 |
Micah Abbott | 🤷 | 18:59:16 |
Micah Abbott | i don't know where all the levers live | 18:59:22 |
adamw | i mean, it should be in that file but probably not per-image | 18:59:48 |